All of lore.kernel.org
 help / color / mirror / Atom feed
* Some warnings
@ 2012-07-11  9:56 Artem Bityutskiy
  2012-07-11  9:58 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Artem Bityutskiy @ 2012-07-11  9:56 UTC (permalink / raw)
  To: Ted Ts'o; +Cc: Ext4 Mailing List

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

Hi Ted,

just out of curiosity I've checked the patches you have in the 'dev'
branch with aiaiai - it did not fine anything very bad (but sometimes it
does!), but detected that few warnings.

--------------------------------------------------------------------------------

Successfully built configuration "x86_64_defconfig,x86_64,", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
@@ @@
+fs/ext4/resize.c: In function ‘ext4_update_super’:
+fs/ext4/resize.c:1200:9: warning: unused variable ‘ret’ [-Wunused-variable]
@@ @@
+fs/ext4/super.c: In function ‘ext4_statfs’:
+fs/ext4/super.c:4779:15: warning: variable ‘overhead’ set but not used [-Wunused-but-set-variable]

--------------------------------------------------------------------------------

The first one is sparse complaining about using dynamic array as a local
variable which has a potential to blow the stack, generally speaking.

The other ones are just gcc warnings.

In short, aiaia is a script which builds the kernel before patching (and
uses sparse/smatch/coccinelle/cppplus while building) and after patching
and compares to build logs in a smart way, and then tells you about new
warnings/complaints from gcc/sparse/smatch/coccinelle. It also checks
bisectability and reports about failures. I find it very useful for
verifying incoming patches.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Some warnings
  2012-07-11  9:56 Some warnings Artem Bityutskiy
@ 2012-07-11  9:58 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2012-07-11  9:58 UTC (permalink / raw)
  To: Ted Ts'o; +Cc: Ext4 Mailing List

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Wed, 2012-07-11 at 12:56 +0300, Artem Bityutskiy wrote:
> In short, aiaia is a script which builds the kernel before patching (and
> uses sparse/smatch/coccinelle/cppplus while building) and after patching
> and compares to build logs in a smart way, and then tells you about new
> warnings/complaints from gcc/sparse/smatch/coccinelle. It also checks
> bisectability and reports about failures. I find it very useful for
> verifying incoming patches.

Oh, and the important point is that you may use parallel build, so if
you have a relatively fast machine, you do not have to wait too long. I
use -j18, for example.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-11  9:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-11  9:56 Some warnings Artem Bityutskiy
2012-07-11  9:58 ` Artem Bityutskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.