* [PATCH] dell-laptop: Add 6 machines to touchpad led quirk
@ 2012-07-13 8:39 AceLan Kao
2012-07-28 4:16 ` Matthew Garrett
2012-08-03 13:43 ` Carlos Alberto Lopez Perez
0 siblings, 2 replies; 5+ messages in thread
From: AceLan Kao @ 2012-07-13 8:39 UTC (permalink / raw)
To: platform-driver-x86, Matthew Garrett
Add the following machines into quirk,
Isnpiron 5420, Isnpiron 5520, Isnpiron 5720,
Isnpiron 7420, Isnpiron 7520, Isnpiron 7720
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
drivers/platform/x86/dell-laptop.c | 54 ++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 5f78aac..4e96e8c 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -206,6 +206,60 @@ static struct dmi_system_id __devinitdata dell_quirks[] = {
},
.driver_data = &quirk_dell_vostro_v130,
},
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 5420",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5420"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 5520",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5520"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 5720",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5720"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 7420",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7420"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 7520",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7520"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 7720",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7720"),
+ },
+ .driver_data = &quirk_dell_vostro_v130,
+ },
{ }
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dell-laptop: Add 6 machines to touchpad led quirk
2012-07-13 8:39 [PATCH] dell-laptop: Add 6 machines to touchpad led quirk AceLan Kao
@ 2012-07-28 4:16 ` Matthew Garrett
2012-07-30 1:21 ` AceLan Kao
2012-08-03 13:43 ` Carlos Alberto Lopez Perez
1 sibling, 1 reply; 5+ messages in thread
From: Matthew Garrett @ 2012-07-28 4:16 UTC (permalink / raw)
To: AceLan Kao; +Cc: platform-driver-x86
I can keep adding these, but are you really certain that there's no way
at all to probe this via either the PS/2 interface or the Dell DMI
structures?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dell-laptop: Add 6 machines to touchpad led quirk
2012-07-28 4:16 ` Matthew Garrett
@ 2012-07-30 1:21 ` AceLan Kao
0 siblings, 0 replies; 5+ messages in thread
From: AceLan Kao @ 2012-07-30 1:21 UTC (permalink / raw)
To: Matthew Garrett; +Cc: platform-driver-x86
Dear Matthew,
Good idea, I'll raise this issue to our PM to see if there is a way
do detect it and will get back to you.
Best regards,
AceLan Kao.
2012/7/28 Matthew Garrett <mjg59@srcf.ucam.org>:
> I can keep adding these, but are you really certain that there's no way
> at all to probe this via either the PS/2 interface or the Dell DMI
> structures?
>
> --
> Matthew Garrett | mjg59@srcf.ucam.org
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dell-laptop: Add 6 machines to touchpad led quirk
2012-07-13 8:39 [PATCH] dell-laptop: Add 6 machines to touchpad led quirk AceLan Kao
2012-07-28 4:16 ` Matthew Garrett
@ 2012-08-03 13:43 ` Carlos Alberto Lopez Perez
2012-08-06 1:49 ` AceLan Kao
1 sibling, 1 reply; 5+ messages in thread
From: Carlos Alberto Lopez Perez @ 2012-08-03 13:43 UTC (permalink / raw)
To: AceLan Kao; +Cc: platform-driver-x86, Matthew Garrett
[-- Attachment #1: Type: text/plain, Size: 2343 bytes --]
On 13/07/12 10:39, AceLan Kao wrote:
> Add the following machines into quirk,
> Isnpiron 5420, Isnpiron 5520, Isnpiron 5720,
> Isnpiron 7420, Isnpiron 7520, Isnpiron 7720
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
> drivers/platform/x86/dell-laptop.c | 54 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index 5f78aac..4e96e8c 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -206,6 +206,60 @@ static struct dmi_system_id __devinitdata dell_quirks[] = {
> },
> .driver_data = &quirk_dell_vostro_v130,
> },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 5420",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5420"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 5520",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5520"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 5720",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5720"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 7420",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7420"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 7520",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7520"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "Dell Inspiron 7720",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7720"),
> + },
> + .driver_data = &quirk_dell_vostro_v130,
> + },
> { }
> };
>
Perhaps this needs a sed "s/Isnpiron/Inspiron/g" ???
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dell-laptop: Add 6 machines to touchpad led quirk
2012-08-03 13:43 ` Carlos Alberto Lopez Perez
@ 2012-08-06 1:49 ` AceLan Kao
0 siblings, 0 replies; 5+ messages in thread
From: AceLan Kao @ 2012-08-06 1:49 UTC (permalink / raw)
To: Carlos Alberto Lopez Perez; +Cc: platform-driver-x86, Matthew Garrett
Dear Carlos,
Yes, you are right.
I copy/paste the wrong word all over the patch.
I just submitted a patch for it, thanks for your report.
Best regards,
AceLan Kao.
2012/8/3 Carlos Alberto Lopez Perez <clopez@igalia.com>:
> On 13/07/12 10:39, AceLan Kao wrote:
>> Add the following machines into quirk,
>> Isnpiron 5420, Isnpiron 5520, Isnpiron 5720,
>> Isnpiron 7420, Isnpiron 7520, Isnpiron 7720
>>
>> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
>> ---
>> drivers/platform/x86/dell-laptop.c | 54 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index 5f78aac..4e96e8c 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -206,6 +206,60 @@ static struct dmi_system_id __devinitdata dell_quirks[] = {
>> },
>> .driver_data = &quirk_dell_vostro_v130,
>> },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 5420",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5420"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 5520",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5520"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 5720",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 5720"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 7420",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7420"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 7520",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7520"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "Dell Inspiron 7720",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Isnpiron 7720"),
>> + },
>> + .driver_data = &quirk_dell_vostro_v130,
>> + },
>> { }
>> };
>>
>
> Perhaps this needs a sed "s/Isnpiron/Inspiron/g" ???
>
--
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-06 1:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-13 8:39 [PATCH] dell-laptop: Add 6 machines to touchpad led quirk AceLan Kao
2012-07-28 4:16 ` Matthew Garrett
2012-07-30 1:21 ` AceLan Kao
2012-08-03 13:43 ` Carlos Alberto Lopez Perez
2012-08-06 1:49 ` AceLan Kao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.