* [PATCH] libceph: trivial fix for the incorrect debug output
@ 2012-07-15 6:45 Jiaju Zhang
2012-07-16 12:55 ` Alex Elder
0 siblings, 1 reply; 3+ messages in thread
From: Jiaju Zhang @ 2012-07-15 6:45 UTC (permalink / raw)
To: ceph-devel; +Cc: Jiaju Zhang
This is a trivial fix for the debug output, as it is inconsistent
with the function name so may confuse people when debugging.
Signed-off-by: Jiaju Zhang <jjzhang@suse.de>
---
net/ceph/osd_client.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 1ffebed..ad6d745 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd)
static void remove_all_osds(struct ceph_osd_client *osdc)
{
- dout("__remove_old_osds %p\n", osdc);
+ dout("__remove_all_osds %p\n", osdc);
mutex_lock(&osdc->request_mutex);
while (!RB_EMPTY_ROOT(&osdc->osds)) {
struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libceph: trivial fix for the incorrect debug output
2012-07-15 6:45 [PATCH] libceph: trivial fix for the incorrect debug output Jiaju Zhang
@ 2012-07-16 12:55 ` Alex Elder
2012-07-16 14:41 ` Jiaju Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Alex Elder @ 2012-07-16 12:55 UTC (permalink / raw)
To: Jiaju Zhang; +Cc: ceph-devel
On 07/15/2012 01:45 AM, Jiaju Zhang wrote:
> This is a trivial fix for the debug output, as it is inconsistent
> with the function name so may confuse people when debugging.
>
> Signed-off-by: Jiaju Zhang <jjzhang@suse.de>
I have been converting these to use __func__ whenever I touch
code nearby. Mind if I do that here as well?
Reviewed-by: Alex Elder <elder@inktank.com>
> ---
> net/ceph/osd_client.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 1ffebed..ad6d745 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd)
>
> static void remove_all_osds(struct ceph_osd_client *osdc)
> {
> - dout("__remove_old_osds %p\n", osdc);
> + dout("__remove_all_osds %p\n", osdc);
dout("%s %p\n", __func__, osdc);
> mutex_lock(&osdc->request_mutex);
> while (!RB_EMPTY_ROOT(&osdc->osds)) {
> struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libceph: trivial fix for the incorrect debug output
2012-07-16 12:55 ` Alex Elder
@ 2012-07-16 14:41 ` Jiaju Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jiaju Zhang @ 2012-07-16 14:41 UTC (permalink / raw)
To: Alex Elder; +Cc: ceph-devel
On Mon, 2012-07-16 at 07:55 -0500, Alex Elder wrote:
> On 07/15/2012 01:45 AM, Jiaju Zhang wrote:
> > This is a trivial fix for the debug output, as it is inconsistent
> > with the function name so may confuse people when debugging.
> >
> > Signed-off-by: Jiaju Zhang <jjzhang@suse.de>
>
> I have been converting these to use __func__ whenever I touch
> code nearby. Mind if I do that here as well?
>
> Reviewed-by: Alex Elder <elder@inktank.com>
Oh, please do;) Using __func__ would be good.
Thanks for the review.
Thanks,
Jiaju
>
> > ---
> > net/ceph/osd_client.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> > index 1ffebed..ad6d745 100644
> > --- a/net/ceph/osd_client.c
> > +++ b/net/ceph/osd_client.c
> > @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd)
> >
> > static void remove_all_osds(struct ceph_osd_client *osdc)
> > {
> > - dout("__remove_old_osds %p\n", osdc);
> > + dout("__remove_all_osds %p\n", osdc);
>
> dout("%s %p\n", __func__, osdc);
>
> > mutex_lock(&osdc->request_mutex);
> > while (!RB_EMPTY_ROOT(&osdc->osds)) {
> > struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-16 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-15 6:45 [PATCH] libceph: trivial fix for the incorrect debug output Jiaju Zhang
2012-07-16 12:55 ` Alex Elder
2012-07-16 14:41 ` Jiaju Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.