* [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc
@ 2012-07-16 22:17 Marek Vasut
2012-07-16 22:56 ` Dan Williams
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2012-07-16 22:17 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, Marek Vasut, Jaroslav Kysela, Takashi Iwai,
Mark Brown, Dan Williams, Arjan van de Ven, James Bottomley
This caused the following crash:
[ 3.950000] sgtl5000 0-000a: Using internal LDO instead of VDDD
[ 3.960000] sgtl5000 0-000a: sgtl5000 revision 0x11
[ 3.970000] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[ 3.970000] pgd = c0004000
[ 3.970000] [00000000] *pgd=00000000
[ 3.970000] Internal error: Oops: 817 [#1] ARM
[ 3.970000] Modules linked in:
[ 3.970000] CPU: 0 Not tainted (3.5.0-rc7-next-20120716-00024-g47a3902-dirty #1814)
[ 3.970000] PC is at async_run_entry_fn+0x3c/0x1cc
[ 3.970000] LR is at process_one_work+0x12c/0x3c8
[ 3.970000] pc : [<c0039a84>] lr : [<c002ead8>] psr: 60000093
[ 3.970000] sp : c74fff38 ip : 00000000 fp : c74fe000
[ 3.970000] r10: c7447d98 r9 : c2fc7f40 r8 : c2fc7f48
[ 3.970000] r7 : c0039a48 r6 : c7403e00 r5 : c74f7d40 r4 : c2fc7f48
[ 3.970000] r3 : 60000013 r2 : 00000000 r1 : c2fc7f80 r0 : c7447da0
[ 3.970000] Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 3.970000] Control: 0005317f Table: 42fd0000 DAC: 00000017
[ 3.970000] Process kworker/u:1 (pid: 16, stack limit = 0xc74fe270)
[ 3.970000] Stack: (0xc74fff38 to 0xc7500000)
[ 3.970000] ff20: c06480d4 c003afe4
[ 3.970000] ff40: 00000001 c7444e60 a0000093 00000000 c2fc7f48 c74f7d40 c7403e00 c0039a48
[ 3.970000] ff60: 00000000 00000000 c06480d4 c002ead8 00000000 c745bf1c 00000001 c74f7d40
[ 3.970000] ff80: c06480d4 c74f7d50 c74fe000 c05ff124 c06255d9 c0647fc4 00000089 c002f518
[ 3.970000] ffa0: 00000013 00000000 00000000 c745bf14 c74f7d40 c002f3b4 00000013 00000000
[ 3.970000] ffc0: 00000000 00000000 00000000 c00335d8 00000000 00000000 c74f7d40 00000000
[ 3.970000] ffe0: c74fffe0 c74fffe0 c745bf14 c0033554 c000fb70 c000fb70 ffbbfaa5 eaeafefe
[ 3.970000] [<c0039a84>] (async_run_entry_fn+0x3c/0x1cc) from [<c002ead8>] (process_one_work+0x12c/0x3c8)
[ 3.970000] [<c002ead8>] (process_one_work+0x12c/0x3c8) from [<c002f518>] (worker_thread+0x164/0x36c)
[ 3.970000] [<c002f518>] (worker_thread+0x164/0x36c) from [<c00335d8>] (kthread+0x84/0x90)
[ 3.970000] [<c00335d8>] (kthread+0x84/0x90) from [<c000fb70>] (kernel_thread_exit+0x0/0x8)
[ 3.970000] Code: e59a200c e28a0008 e58a900c e9080005 (e5829000)
[ 3.970000] ---[ end trace 7e75d80e67ab9651 ]---
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: <alsa-devel@alsa-project.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: James Bottomley <JBottomley@Parallels.com>
---
sound/soc/soc-dapm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
V2: CC proper people, hopefully proper mailing list
Adjust the patch subject with proper tags
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index eded657..e491eb0 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1572,7 +1572,7 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
struct snd_soc_dapm_context *d;
LIST_HEAD(up_list);
LIST_HEAD(down_list);
- LIST_HEAD(async_domain);
+ ASYNC_DOMAIN_EXCLUSIVE(async_domain);
enum snd_soc_bias_level bias;
trace_snd_soc_dapm_start(card);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc
2012-07-16 22:17 [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc Marek Vasut
@ 2012-07-16 22:56 ` Dan Williams
2012-07-17 7:28 ` James Bottomley
0 siblings, 1 reply; 5+ messages in thread
From: Dan Williams @ 2012-07-16 22:56 UTC (permalink / raw)
To: Marek Vasut
Cc: alsa-devel, linux-kernel, Jaroslav Kysela, Takashi Iwai,
Mark Brown, Arjan van de Ven, James Bottomley
On Mon, Jul 16, 2012 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
[..]
> sound/soc/soc-dapm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> V2: CC proper people, hopefully proper mailing list
> Adjust the patch subject with proper tags
>
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index eded657..e491eb0 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -1572,7 +1572,7 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
> struct snd_soc_dapm_context *d;
> LIST_HEAD(up_list);
> LIST_HEAD(down_list);
> - LIST_HEAD(async_domain);
> + ASYNC_DOMAIN_EXCLUSIVE(async_domain);
> enum snd_soc_bias_level bias;
>
Thanks. This was folded into the resend that was submitted week [1]
Regards,
Dan
[1]: http://marc.info/?l=linux-scsi&m=134188683322951&w=2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc
2012-07-16 22:56 ` Dan Williams
@ 2012-07-17 7:28 ` James Bottomley
0 siblings, 0 replies; 5+ messages in thread
From: James Bottomley @ 2012-07-17 7:28 UTC (permalink / raw)
To: Dan Williams
Cc: Marek Vasut, alsa-devel, linux-kernel, Jaroslav Kysela,
Takashi Iwai, Mark Brown, Arjan van de Ven
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1134 bytes --]
On Mon, 2012-07-16 at 15:56 -0700, Dan Williams wrote:
> On Mon, Jul 16, 2012 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> [..]
> > sound/soc/soc-dapm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > V2: CC proper people, hopefully proper mailing list
> > Adjust the patch subject with proper tags
> >
> > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> > index eded657..e491eb0 100644
> > --- a/sound/soc/soc-dapm.c
> > +++ b/sound/soc/soc-dapm.c
> > @@ -1572,7 +1572,7 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
> > struct snd_soc_dapm_context *d;
> > LIST_HEAD(up_list);
> > LIST_HEAD(down_list);
> > - LIST_HEAD(async_domain);
> > + ASYNC_DOMAIN_EXCLUSIVE(async_domain);
> > enum snd_soc_bias_level bias;
> >
>
> Thanks. This was folded into the resend that was submitted week [1]
OK, I missed that with the cockup in the cover letters.
James
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc
@ 2012-07-17 7:28 ` James Bottomley
0 siblings, 0 replies; 5+ messages in thread
From: James Bottomley @ 2012-07-17 7:28 UTC (permalink / raw)
To: Dan Williams
Cc: Marek Vasut, alsa-devel, linux-kernel, Jaroslav Kysela,
Takashi Iwai, Mark Brown, Arjan van de Ven
On Mon, 2012-07-16 at 15:56 -0700, Dan Williams wrote:
> On Mon, Jul 16, 2012 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> [..]
> > sound/soc/soc-dapm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > V2: CC proper people, hopefully proper mailing list
> > Adjust the patch subject with proper tags
> >
> > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> > index eded657..e491eb0 100644
> > --- a/sound/soc/soc-dapm.c
> > +++ b/sound/soc/soc-dapm.c
> > @@ -1572,7 +1572,7 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
> > struct snd_soc_dapm_context *d;
> > LIST_HEAD(up_list);
> > LIST_HEAD(down_list);
> > - LIST_HEAD(async_domain);
> > + ASYNC_DOMAIN_EXCLUSIVE(async_domain);
> > enum snd_soc_bias_level bias;
> >
>
> Thanks. This was folded into the resend that was submitted week [1]
OK, I missed that with the cockup in the cover letters.
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc
2012-07-17 7:28 ` James Bottomley
(?)
@ 2012-07-17 7:50 ` Marek Vasut
-1 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-07-17 7:50 UTC (permalink / raw)
To: James Bottomley
Cc: Dan Williams, alsa-devel, linux-kernel, Jaroslav Kysela,
Takashi Iwai, Mark Brown, Arjan van de Ven
Dear James Bottomley,
> On Mon, 2012-07-16 at 15:56 -0700, Dan Williams wrote:
> > On Mon, Jul 16, 2012 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> > [..]
> >
> > > sound/soc/soc-dapm.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > V2: CC proper people, hopefully proper mailing list
> > >
> > > Adjust the patch subject with proper tags
> > >
> > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> > > index eded657..e491eb0 100644
> > > --- a/sound/soc/soc-dapm.c
> > > +++ b/sound/soc/soc-dapm.c
> > > @@ -1572,7 +1572,7 @@ static int dapm_power_widgets(struct
> > > snd_soc_dapm_context *dapm, int event)
> > >
> > > struct snd_soc_dapm_context *d;
> > > LIST_HEAD(up_list);
> > > LIST_HEAD(down_list);
> > >
> > > - LIST_HEAD(async_domain);
> > > + ASYNC_DOMAIN_EXCLUSIVE(async_domain);
> > >
> > > enum snd_soc_bias_level bias;
> >
> > Thanks. This was folded into the resend that was submitted week [1]
>
> OK, I missed that with the cockup in the cover letters.
Well, the main point is it's now fixed. Thanks guys! :-)
> James
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-17 8:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-16 22:17 [PATCH V2] [SCSI] async: Fixup arguments of async_synchronize_full_domain in alsa-soc Marek Vasut
2012-07-16 22:56 ` Dan Williams
2012-07-17 7:28 ` James Bottomley
2012-07-17 7:28 ` James Bottomley
2012-07-17 7:50 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.