[PATCH] xentop.c: Change curses painting behavior to avoid flicker

* [PATCH] xentop.c: Change curses painting behavior to avoid flicker
@ 2012-07-04 18:55 Jason McCarver
  2012-07-17 13:24 ` Ian Jackson
  0 siblings, 1 reply; 6+ messages in thread
From: Jason McCarver @ 2012-07-04 18:55 UTC (permalink / raw)
  To: xen-devel; +Cc: ian.jackson, ian.campbell, stefano.stabellini

Currently, xentop calls clear() before drawing the screen and calling
refresh().  This causes the entire screen to be repainted from scratch
on each call to refresh().  It is inefficient and causes visible flicker
when using xentop.

This patch fixes this by calling erase() instead of clear() which overwrites
the current screen with blanks instead.  The screen is then drawn as usual
in the top() function and refresh() is called.  This method allows curses
to only repaint the characters that have changed since the last call
to refresh(), thus avoiding the flicker and sending fewer characters to
the terminal.

In the event the screen becomes corrupted, this patch accepts a CTRL-L
keystroke from the user which will call clear() and force a repaint of
the entire screen.

Signed-off-by: Jason McCarver <slam@parasite.cc>

diff -r 42f76d536b11 -r b1bf5533d565 tools/xenstat/xentop/xentop.c

--- a/tools/xenstat/xentop/xentop.c	Tue Jul 03 13:39:01 2012 +0100
+++ b/tools/xenstat/xentop/xentop.c	Wed Jul 04 13:53:25 2012 -0500
@@ -57,6 +57,7 @@
 #endif
 
 #define KEY_ESCAPE '\x1B'
+#define KEY_REPAINT '\x0C'
 
 #ifdef HOST_SunOS
 /* Old curses library on Solaris takes non-const strings. Also, ERR interferes
@@ -383,6 +384,9 @@ static int handle_key(int ch)
 		case 'd': case 'D':
 			set_prompt("Delay(sec)", set_delay);
 			break;
+		case KEY_REPAINT:
+			clear();
+			break;
 		case 'q': case 'Q': case KEY_ESCAPE:
 			return 0;
 		}
@@ -1201,7 +1205,7 @@ int main(int argc, char **argv)
 		do {
 			gettimeofday(&curtime, NULL);
 			if(ch != ERR || (curtime.tv_sec - oldtime.tv_sec) >= delay) {
-				clear();
+				erase();
 				top();
 				oldtime = curtime;
 				refresh();

^ permalink raw reply	[flat|nested] 6+ messages in thread