* [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define
@ 2012-07-18 13:01 Torben Hohn
2012-07-18 18:28 ` Roberto Nibali
2012-07-18 21:10 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Torben Hohn @ 2012-07-18 13:01 UTC (permalink / raw)
To: alsa-devel
Cc: Torben Hohn, Sascha Hauer, Mark Brown, Richard Zhao, Shawn Guo,
Timur Tabi
The MX31 Audmux also has 7 Ports.
This patch adds the missing define, and makes the debugfs code iterate
over that port too.
Signed-off-by: Torben Hohn <torbenh@linutronix.de>
---
sound/soc/fsl/imx-audmux.c | 2 +-
sound/soc/fsl/imx-audmux.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index 0803274..e7c800e 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -156,7 +156,7 @@ static void __init audmux_debugfs_init(void)
return;
}
- for (i = 0; i < MX31_AUDMUX_PORT6_SSI_PINS_6 + 1; i++) {
+ for (i = 0; i < MX31_AUDMUX_PORT7_SSI_PINS_7 + 1; i++) {
snprintf(buf, sizeof(buf), "ssi%d", i);
if (!debugfs_create_file(buf, 0444, audmux_debugfs_root,
(void *)i, &audmux_debugfs_fops))
diff --git a/sound/soc/fsl/imx-audmux.h b/sound/soc/fsl/imx-audmux.h
index 04ebbab..b8ff44b 100644
--- a/sound/soc/fsl/imx-audmux.h
+++ b/sound/soc/fsl/imx-audmux.h
@@ -14,6 +14,7 @@
#define MX31_AUDMUX_PORT4_SSI_PINS_4 3
#define MX31_AUDMUX_PORT5_SSI_PINS_5 4
#define MX31_AUDMUX_PORT6_SSI_PINS_6 5
+#define MX31_AUDMUX_PORT7_SSI_PINS_7 6
#define MX51_AUDMUX_PORT1_SSI0 0
#define MX51_AUDMUX_PORT2_SSI1 1
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define
2012-07-18 13:01 [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define Torben Hohn
@ 2012-07-18 18:28 ` Roberto Nibali
2012-07-18 21:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Roberto Nibali @ 2012-07-18 18:28 UTC (permalink / raw)
To: Torben Hohn
Cc: alsa-devel, Sascha Hauer, Mark Brown, Richard Zhao, Shawn Guo,
Timur Tabi
Hi
On Wed, Jul 18, 2012 at 3:01 PM, Torben Hohn <torbenh@linutronix.de> wrote:
> The MX31 Audmux also has 7 Ports.
> This patch adds the missing define, and makes the debugfs code iterate
> over that port too.
>
> Signed-off-by: Torben Hohn <torbenh@linutronix.de>
> ---
> sound/soc/fsl/imx-audmux.c | 2 +-
> sound/soc/fsl/imx-audmux.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index 0803274..e7c800e 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -156,7 +156,7 @@ static void __init audmux_debugfs_init(void)
> return;
> }
>
> - for (i = 0; i < MX31_AUDMUX_PORT6_SSI_PINS_6 + 1; i++) {
> + for (i = 0; i < MX31_AUDMUX_PORT7_SSI_PINS_7 + 1; i++) {
> snprintf(buf, sizeof(buf), "ssi%d", i);
> if (!debugfs_create_file(buf, 0444, audmux_debugfs_root,
> (void *)i, &audmux_debugfs_fops))
> diff --git a/sound/soc/fsl/imx-audmux.h b/sound/soc/fsl/imx-audmux.h
> index 04ebbab..b8ff44b 100644
> --- a/sound/soc/fsl/imx-audmux.h
> +++ b/sound/soc/fsl/imx-audmux.h
> @@ -14,6 +14,7 @@
> #define MX31_AUDMUX_PORT4_SSI_PINS_4 3
> #define MX31_AUDMUX_PORT5_SSI_PINS_5 4
> #define MX31_AUDMUX_PORT6_SSI_PINS_6 5
> +#define MX31_AUDMUX_PORT7_SSI_PINS_7 6
There was a similar fix for the kernel part about three months ago.
Also, the i.MX25 has 7 SSI ports, so this patch is good and safe.
Cheers
Roberto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define
2012-07-18 13:01 [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define Torben Hohn
2012-07-18 18:28 ` Roberto Nibali
@ 2012-07-18 21:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-07-18 21:10 UTC (permalink / raw)
To: Torben Hohn; +Cc: alsa-devel, Shawn Guo, Richard Zhao, Sascha Hauer, Timur Tabi
[-- Attachment #1.1: Type: text/plain, Size: 210 bytes --]
On Wed, Jul 18, 2012 at 03:01:17PM +0200, Torben Hohn wrote:
> The MX31 Audmux also has 7 Ports.
> This patch adds the missing define, and makes the debugfs code iterate
> over that port too.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-18 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 13:01 [PATCH] ASoC imx-audmux: add MX31_AUDMUX_PORT7_SSI_PINS_7 define Torben Hohn
2012-07-18 18:28 ` Roberto Nibali
2012-07-18 21:10 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.