[PATCH] mac80211: flush stations before stop beaconing

[PATCH] mac80211: flush stations before stop beaconing

[Eliad Peller]

When AP interface is going down, the stations
are flushed (in ieee80211_do_stop()) only after
the beaconing was stopped.

However, drivers might rely on stations being
removed before the beaconing was stopped, in
order to clean up properly.

Fix it by flushing the stations on ap stop.

(we already do the same for other interface
types, e.g. in ieee80211_set_disassoc())

Signed-off-by: Eliad Peller <eliad@wizery.com>
---
 net/mac80211/cfg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 6e4098e..c7df257 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -924,6 +924,7 @@ static int ieee80211_stop_ap(struct wiphy *wiphy, struct net_device *dev)
 
 	kfree_rcu(old, rcu_head);
 
+	sta_info_flush(sdata->local, sdata);
 	ieee80211_bss_info_change_notify(sdata, BSS_CHANGED_BEACON_ENABLED);
 
 	return 0;
-- 
1.7.6.401.g6a319

Re: [PATCH] mac80211: flush stations before stop beaconing

[Johannes Berg]

On Wed, 2012-07-18 at 15:36 +0300, Eliad Peller wrote:
> When AP interface is going down, the stations
> are flushed (in ieee80211_do_stop()) only after
> the beaconing was stopped.
> 
> However, drivers might rely on stations being
> removed before the beaconing was stopped, in
> order to clean up properly.
> 
> Fix it by flushing the stations on ap stop.
> 
> (we already do the same for other interface
> types, e.g. in ieee80211_set_disassoc())
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>

Applied, thanks.

johannes