* [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
@ 2012-07-18 16:49 ` olaf
0 siblings, 0 replies; 8+ messages in thread
From: olaf @ 2012-07-18 16:49 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-fbdev, Olaf Hering
From: Tony Breeds <tony@bakeyournoodle.com>
These devices are set to 640x480 by firmware, switch them to 800x600@60
so that the graphical installer can run on remote console.
Reported by IBM during SLES10 SP2 beta testing:
https://bugzilla.novell.com/show_bug.cgi?idF1002
LTC50817
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff --git a/drivers/video/aty/radeon_monitor.c b/drivers/video/aty/radeon_monitor.c
index 9261c91..5c23eac 100644
--- a/drivers/video/aty/radeon_monitor.c
+++ b/drivers/video/aty/radeon_monitor.c
@@ -730,6 +730,25 @@ static void radeon_videomode_to_var(struct fb_var_screeninfo *var,
var->vmode = mode->vmode;
}
+#ifdef CONFIG_PPC_PSERIES
+static int is_powerblade(const char *model)
+{
+ struct device_node *root;
+ const char* cp;
+ int len, l, rc = 0;
+
+ root = of_find_node_by_path("/");
+ if (root && model) {
+ l = strlen(model);
+ cp = of_get_property(root, "model", &len);
+ if (cp)
+ rc = memcmp(model, cp, min(len, l)) = 0;
+ of_node_put(root);
+ }
+ return rc;
+}
+#endif
+
/*
* Build the modedb for head 1 (head 2 will come later), check panel infos
* from either BIOS or EDID, and pick up the default mode
@@ -865,6 +884,22 @@ void __devinit radeon_check_modes(struct radeonfb_info *rinfo, const char *mode_
has_default_mode = 1;
}
+#ifdef CONFIG_PPC_PSERIES
+ if (!has_default_mode && (
+ is_powerblade("IBM,8842") || /* JS20 */
+ is_powerblade("IBM,8844") || /* JS21 */
+ is_powerblade("IBM,7998") || /* JS12/JS21/JS22 */
+ is_powerblade("IBM,0792") || /* QS21 */
+ is_powerblade("IBM,0793") /* QS22 */
+ )) {
+ printk("Falling back to 800x600 on JSxx hardware\n");
+ if (fb_find_mode(&info->var, info, "800x600@60",
+ info->monspecs.modedb,
+ info->monspecs.modedb_len, NULL, 8) != 0)
+ has_default_mode = 1;
+ }
+#endif
+
/*
* Still no mode, let's pick up a default from the db
*/
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
@ 2012-07-18 16:49 ` olaf
0 siblings, 0 replies; 8+ messages in thread
From: olaf @ 2012-07-18 16:49 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-fbdev, Olaf Hering
From: Tony Breeds <tony@bakeyournoodle.com>
These devices are set to 640x480 by firmware, switch them to 800x600@60
so that the graphical installer can run on remote console.
Reported by IBM during SLES10 SP2 beta testing:
https://bugzilla.novell.com/show_bug.cgi?id=461002
LTC50817
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff --git a/drivers/video/aty/radeon_monitor.c b/drivers/video/aty/radeon_monitor.c
index 9261c91..5c23eac 100644
--- a/drivers/video/aty/radeon_monitor.c
+++ b/drivers/video/aty/radeon_monitor.c
@@ -730,6 +730,25 @@ static void radeon_videomode_to_var(struct fb_var_screeninfo *var,
var->vmode = mode->vmode;
}
+#ifdef CONFIG_PPC_PSERIES
+static int is_powerblade(const char *model)
+{
+ struct device_node *root;
+ const char* cp;
+ int len, l, rc = 0;
+
+ root = of_find_node_by_path("/");
+ if (root && model) {
+ l = strlen(model);
+ cp = of_get_property(root, "model", &len);
+ if (cp)
+ rc = memcmp(model, cp, min(len, l)) == 0;
+ of_node_put(root);
+ }
+ return rc;
+}
+#endif
+
/*
* Build the modedb for head 1 (head 2 will come later), check panel infos
* from either BIOS or EDID, and pick up the default mode
@@ -865,6 +884,22 @@ void __devinit radeon_check_modes(struct radeonfb_info *rinfo, const char *mode_
has_default_mode = 1;
}
+#ifdef CONFIG_PPC_PSERIES
+ if (!has_default_mode && (
+ is_powerblade("IBM,8842") || /* JS20 */
+ is_powerblade("IBM,8844") || /* JS21 */
+ is_powerblade("IBM,7998") || /* JS12/JS21/JS22 */
+ is_powerblade("IBM,0792") || /* QS21 */
+ is_powerblade("IBM,0793") /* QS22 */
+ )) {
+ printk("Falling back to 800x600 on JSxx hardware\n");
+ if (fb_find_mode(&info->var, info, "800x600@60",
+ info->monspecs.modedb,
+ info->monspecs.modedb_len, NULL, 8) != 0)
+ has_default_mode = 1;
+ }
+#endif
+
/*
* Still no mode, let's pick up a default from the db
*/
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* RE: [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
2012-07-18 16:49 ` olaf
@ 2012-07-19 5:02 ` Jingoo Han
-1 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2012-07-19 5:02 UTC (permalink / raw)
To: olaf, 'Benjamin Herrenschmidt'; +Cc: linuxppc-dev, linux-fbdev
On Thursday, July 19, 2012 1:49 AM, olaf@aepfle.de wrote:
> From: Tony Breeds <tony@bakeyournoodle.com>
>
> These devices are set to 640x480 by firmware, switch them to 800x600@60
> so that the graphical installer can run on remote console.
>
> Reported by IBM during SLES10 SP2 beta testing:
>
> https://bugzilla.novell.com/show_bug.cgi?idF1002
> LTC50817
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
If the author is Tony Breeds, please add 'Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>'.
Best regards,
Jingoo Han
>
> diff --git a/drivers/video/aty/radeon_monitor.c b/drivers/video/aty/radeon_monitor.c
> index 9261c91..5c23eac 100644
> --- a/drivers/video/aty/radeon_monitor.c
> +++ b/drivers/video/aty/radeon_monitor.c
> @@ -730,6 +730,25 @@ static void radeon_videomode_to_var(struct fb_var_screeninfo *var,
> var->vmode = mode->vmode;
> }
>
> +#ifdef CONFIG_PPC_PSERIES
> +static int is_powerblade(const char *model)
> +{
> + struct device_node *root;
> + const char* cp;
> + int len, l, rc = 0;
> +
> + root = of_find_node_by_path("/");
> + if (root && model) {
> + l = strlen(model);
> + cp = of_get_property(root, "model", &len);
> + if (cp)
> + rc = memcmp(model, cp, min(len, l)) = 0;
> + of_node_put(root);
> + }
> + return rc;
> +}
> +#endif
> +
> /*
> * Build the modedb for head 1 (head 2 will come later), check panel infos
> * from either BIOS or EDID, and pick up the default mode
> @@ -865,6 +884,22 @@ void __devinit radeon_check_modes(struct radeonfb_info *rinfo, const char *mode_
> has_default_mode = 1;
> }
>
> +#ifdef CONFIG_PPC_PSERIES
> + if (!has_default_mode && (
> + is_powerblade("IBM,8842") || /* JS20 */
> + is_powerblade("IBM,8844") || /* JS21 */
> + is_powerblade("IBM,7998") || /* JS12/JS21/JS22 */
> + is_powerblade("IBM,0792") || /* QS21 */
> + is_powerblade("IBM,0793") /* QS22 */
> + )) {
> + printk("Falling back to 800x600 on JSxx hardware\n");
> + if (fb_find_mode(&info->var, info, "800x600@60",
> + info->monspecs.modedb,
> + info->monspecs.modedb_len, NULL, 8) != 0)
> + has_default_mode = 1;
> + }
> +#endif
> +
> /*
> * Still no mode, let's pick up a default from the db
> */
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
@ 2012-07-19 5:02 ` Jingoo Han
0 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2012-07-19 5:02 UTC (permalink / raw)
To: olaf, 'Benjamin Herrenschmidt'; +Cc: linuxppc-dev, linux-fbdev
On Thursday, July 19, 2012 1:49 AM, olaf@aepfle.de wrote:
> From: Tony Breeds <tony@bakeyournoodle.com>
>
> These devices are set to 640x480 by firmware, switch them to 800x600@60
> so that the graphical installer can run on remote console.
>
> Reported by IBM during SLES10 SP2 beta testing:
>
> https://bugzilla.novell.com/show_bug.cgi?id=461002
> LTC50817
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
If the author is Tony Breeds, please add 'Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>'.
Best regards,
Jingoo Han
>
> diff --git a/drivers/video/aty/radeon_monitor.c b/drivers/video/aty/radeon_monitor.c
> index 9261c91..5c23eac 100644
> --- a/drivers/video/aty/radeon_monitor.c
> +++ b/drivers/video/aty/radeon_monitor.c
> @@ -730,6 +730,25 @@ static void radeon_videomode_to_var(struct fb_var_screeninfo *var,
> var->vmode = mode->vmode;
> }
>
> +#ifdef CONFIG_PPC_PSERIES
> +static int is_powerblade(const char *model)
> +{
> + struct device_node *root;
> + const char* cp;
> + int len, l, rc = 0;
> +
> + root = of_find_node_by_path("/");
> + if (root && model) {
> + l = strlen(model);
> + cp = of_get_property(root, "model", &len);
> + if (cp)
> + rc = memcmp(model, cp, min(len, l)) == 0;
> + of_node_put(root);
> + }
> + return rc;
> +}
> +#endif
> +
> /*
> * Build the modedb for head 1 (head 2 will come later), check panel infos
> * from either BIOS or EDID, and pick up the default mode
> @@ -865,6 +884,22 @@ void __devinit radeon_check_modes(struct radeonfb_info *rinfo, const char *mode_
> has_default_mode = 1;
> }
>
> +#ifdef CONFIG_PPC_PSERIES
> + if (!has_default_mode && (
> + is_powerblade("IBM,8842") || /* JS20 */
> + is_powerblade("IBM,8844") || /* JS21 */
> + is_powerblade("IBM,7998") || /* JS12/JS21/JS22 */
> + is_powerblade("IBM,0792") || /* QS21 */
> + is_powerblade("IBM,0793") /* QS22 */
> + )) {
> + printk("Falling back to 800x600 on JSxx hardware\n");
> + if (fb_find_mode(&info->var, info, "800x600@60",
> + info->monspecs.modedb,
> + info->monspecs.modedb_len, NULL, 8) != 0)
> + has_default_mode = 1;
> + }
> +#endif
> +
> /*
> * Still no mode, let's pick up a default from the db
> */
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
2012-07-19 5:02 ` Jingoo Han
@ 2012-07-19 5:20 ` Olaf Hering
-1 siblings, 0 replies; 8+ messages in thread
From: Olaf Hering @ 2012-07-19 5:20 UTC (permalink / raw)
To: Jingoo Han, 'Tony Breeds'; +Cc: linux-fbdev, linuxppc-dev
On Thu, Jul 19, Jingoo Han wrote:
> On Thursday, July 19, 2012 1:49 AM, olaf@aepfle.de wrote:
> > From: Tony Breeds <tony@bakeyournoodle.com>
> >
> > These devices are set to 640x480 by firmware, switch them to 800x600@60
> > so that the graphical installer can run on remote console.
> >
> > Reported by IBM during SLES10 SP2 beta testing:
> >
> > https://bugzilla.novell.com/show_bug.cgi?idF1002
> > LTC50817
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> If the author is Tony Breeds, please add 'Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>'.
He provided the initial version of the change, but did not add his tag
back in 2009. Tony, perhaps you can do that now?
Olaf
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
@ 2012-07-19 5:20 ` Olaf Hering
0 siblings, 0 replies; 8+ messages in thread
From: Olaf Hering @ 2012-07-19 5:20 UTC (permalink / raw)
To: Jingoo Han, 'Tony Breeds'; +Cc: linux-fbdev, linuxppc-dev
On Thu, Jul 19, Jingoo Han wrote:
> On Thursday, July 19, 2012 1:49 AM, olaf@aepfle.de wrote:
> > From: Tony Breeds <tony@bakeyournoodle.com>
> >
> > These devices are set to 640x480 by firmware, switch them to 800x600@60
> > so that the graphical installer can run on remote console.
> >
> > Reported by IBM during SLES10 SP2 beta testing:
> >
> > https://bugzilla.novell.com/show_bug.cgi?id=461002
> > LTC50817
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> If the author is Tony Breeds, please add 'Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>'.
He provided the initial version of the change, but did not add his tag
back in 2009. Tony, perhaps you can do that now?
Olaf
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx
2012-07-18 16:49 ` olaf
@ 2012-07-19 5:48 ` Tony Breeds
-1 siblings, 0 replies; 8+ messages in thread
From: Tony Breeds @ 2012-07-19 5:48 UTC (permalink / raw)
To: olaf; +Cc: linux-fbdev, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
On Wed, Jul 18, 2012 at 06:49:04PM +0200, olaf@aepfle.de wrote:
Thanks for following this up.
> From: Tony Breeds <tony@bakeyournoodle.com>
>
> These devices are set to 640x480 by firmware, switch them to 800x600@60
> so that the graphical installer can run on remote console.
>
> Reported by IBM during SLES10 SP2 beta testing:
>
> https://bugzilla.novell.com/show_bug.cgi?id=461002
> LTC50817
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-07-19 5:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 16:49 [PATCH] radeonfb: Add quirk for the graphics adapter in some JSxx olaf
2012-07-18 16:49 ` olaf
2012-07-19 5:02 ` Jingoo Han
2012-07-19 5:02 ` Jingoo Han
2012-07-19 5:20 ` Olaf Hering
2012-07-19 5:20 ` Olaf Hering
2012-07-19 5:48 ` Tony Breeds
2012-07-19 5:48 ` Tony Breeds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.