[PATCH BlueZ 1/2] time: fix byte position

[PATCH BlueZ 1/2] time: fix byte position

[João Paulo Rechi Vita]

The position of the "Time Zone" and "Daylight Saving Time" fields on
the Local Time Information characteristic was inverted. This commit
fix their position.
---
 time/server.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/time/server.c b/time/server.c
index be6e196..ddf88ae 100644
--- a/time/server.c
+++ b/time/server.c
@@ -107,13 +107,13 @@ static uint8_t local_time_info_read(struct attribute *a,
 
 	tzset();
 
-	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
-	 * for the local time or not. The offset is unknown. */
-	value[0] = daylight ? 0xff : 0x00;
-
 	/* Convert POSIX "timezone" (seconds West of GMT) to Time Profile
 	 * format (offset from UTC in number of 15 minutes increments). */
-	value[1] = (uint8_t) (-1 * timezone / (60 * 15));
+	value[0] = (uint8_t) (-1 * timezone / (60 * 15));
+
+	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
+	 * for the local time or not. The offset is unknown. */
+	value[1] = daylight ? 0xff : 0x00;
 
 	attrib_db_update(adapter, a->handle, NULL, value, sizeof(value), NULL);
 
-- 
1.7.10.4

[PATCH BlueZ 2/2] time: fix daylight variable description

[João Paulo Rechi Vita]

---
 time/server.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/time/server.c b/time/server.c
index ddf88ae..a5f151e 100644
--- a/time/server.c
+++ b/time/server.c
@@ -111,8 +111,9 @@ static uint8_t local_time_info_read(struct attribute *a,
 	 * format (offset from UTC in number of 15 minutes increments). */
 	value[0] = (uint8_t) (-1 * timezone / (60 * 15));
 
-	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
-	 * for the local time or not. The offset is unknown. */
+	/* FIXME: POSIX "daylight" variable only indicates if DST is used for
+	 * the local time or not. Both the offset and wheter it's currently
+	 * active is unknown. */
 	value[1] = daylight ? 0xff : 0x00;
 
 	attrib_db_update(adapter, a->handle, NULL, value, sizeof(value), NULL);
-- 
1.7.10.4

Re: [PATCH BlueZ 2/2] time: fix daylight variable description

[Anderson Lizardo]

Hi Joao,

On Thu, Jul 5, 2012 at 2:37 PM, João Paulo Rechi Vita
<jprvita@openbossa.org> wrote:
> -       /* FIXME: POSIX "daylight" variable only indicates whether there is DST
> -        * for the local time or not. The offset is unknown. */
> +       /* FIXME: POSIX "daylight" variable only indicates if DST is used for
> +        * the local time or not. Both the offset and wheter it's currently

small typo: wheter -> whether

> +        * active is unknown. */
>         value[1] = daylight ? 0xff : 0x00;

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Re: [PATCH BlueZ 1/2] time: fix byte position

[Anderson Lizardo]

Hi Joao,

On Thu, Jul 5, 2012 at 2:37 PM, João Paulo Rechi Vita
<jprvita@openbossa.org> wrote:
> The position of the "Time Zone" and "Daylight Saving Time" fields on
> the Local Time Information characteristic was inverted. This commit
> fix their position.
> ---
>  time/server.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Patch looks good.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

[PATCH BlueZ] time: fix daylight variable description

[João Paulo Rechi Vita]

---
 time/server.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/time/server.c b/time/server.c
index ddf88ae..d7bcf2d 100644
--- a/time/server.c
+++ b/time/server.c
@@ -111,8 +111,9 @@ static uint8_t local_time_info_read(struct attribute *a,
 	 * format (offset from UTC in number of 15 minutes increments). */
 	value[0] = (uint8_t) (-1 * timezone / (60 * 15));
 
-	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
-	 * for the local time or not. The offset is unknown. */
+	/* FIXME: POSIX "daylight" variable only indicates if DST is used for
+	 * the local time or not. Both the offset and whether it's currently
+	 * active is unknown. */
 	value[1] = daylight ? 0xff : 0x00;
 
 	attrib_db_update(adapter, a->handle, NULL, value, sizeof(value), NULL);
-- 
1.7.10.4

Re: [PATCH BlueZ 1/2] time: fix byte position

[Joao Paulo Rechi Vita]

On Thu, Jul 5, 2012 at 6:39 PM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Hi Joao,
>
> On Thu, Jul 5, 2012 at 2:37 PM, João Paulo Rechi Vita
> <jprvita@openbossa.org> wrote:
>> The position of the "Time Zone" and "Daylight Saving Time" fields on
>> the Local Time Information characteristic was inverted. This commit
>> fix their position.
>> ---
>>  time/server.c |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> Patch looks good.
>

Is there something preventing this patches to being merged? I see
Gustavo is already sending the directory move patches, and this will
probably not apply after his patches.

-- 
João Paulo Rechi Vita
Openbossa Labs - INdT

Re: [PATCH BlueZ 1/2] time: fix byte position

[Johan Hedberg]

Hi,

On Tue, Jul 10, 2012, Joao Paulo Rechi Vita wrote:
> On Thu, Jul 5, 2012 at 6:39 PM, Anderson Lizardo
> <anderson.lizardo@openbossa.org> wrote:
> > Hi Joao,
> >
> > On Thu, Jul 5, 2012 at 2:37 PM, João Paulo Rechi Vita
> > <jprvita@openbossa.org> wrote:
> >> The position of the "Time Zone" and "Daylight Saving Time" fields on
> >> the Local Time Information characteristic was inverted. This commit
> >> fix their position.
> >> ---
> >>  time/server.c |   10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > Patch looks good.
> 
> Is there something preventing this patches to being merged? I see
> Gustavo is already sending the directory move patches, and this will
> probably not apply after his patches.

No particular reason why they weren't applied before the directory
restructuring. Could you please resend them to match the latest tree?

Johan

[PATCH BlueZ 1/2] time: fix byte position

[João Paulo Rechi Vita]

The position of the "Time Zone" and "Daylight Saving Time" fields on
the Local Time Information characteristic was inverted. This commit
fix their position.
---
 profiles/time/server.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/profiles/time/server.c b/profiles/time/server.c
index be6e196..ddf88ae 100644
--- a/profiles/time/server.c
+++ b/profiles/time/server.c
@@ -107,13 +107,13 @@ static uint8_t local_time_info_read(struct attribute *a,
 
 	tzset();
 
-	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
-	 * for the local time or not. The offset is unknown. */
-	value[0] = daylight ? 0xff : 0x00;
-
 	/* Convert POSIX "timezone" (seconds West of GMT) to Time Profile
 	 * format (offset from UTC in number of 15 minutes increments). */
-	value[1] = (uint8_t) (-1 * timezone / (60 * 15));
+	value[0] = (uint8_t) (-1 * timezone / (60 * 15));
+
+	/* FIXME: POSIX "daylight" variable only indicates whether there is DST
+	 * for the local time or not. The offset is unknown. */
+	value[1] = daylight ? 0xff : 0x00;
 
 	attrib_db_update(adapter, a->handle, NULL, value, sizeof(value), NULL);
 
-- 
1.7.10.4

Re: [PATCH BlueZ 1/2] time: fix byte position

[Johan Hedberg]

Hi João Paulo,

On Thu, Jul 19, 2012, João Paulo Rechi Vita wrote:
> The position of the "Time Zone" and "Daylight Saving Time" fields on
> the Local Time Information characteristic was inverted. This commit
> fix their position.
> ---
>  profiles/time/server.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Applied. Thanks.

Johan