From: Vinod Koul <vinod.koul-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Cc: dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] dma: tegra: enable/disable dma clock Date: Fri, 20 Jul 2012 11:32:21 +0530 [thread overview] Message-ID: <1342764141.1726.199.camel@vkoul-udesk3> (raw) In-Reply-To: <1342601769-13852-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > Enable the DMA clock when registering DMA driver and > disable clock when removing the DMA driver. > > The failure was observed on Tegra20 based system by > Stephen Warren. However, it is working fine on tegra30 > based system and probably becasue uboot enable the clock > on Tegra30. Don't know much about the clock subsystem, but shouldn't the clocks be enabled runtime..... when you actually start using the controller?? > > Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > Reported-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> > --- > drivers/dma/tegra20-apb-dma.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index d52dbc6..ccfdaf4 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1255,6 +1255,12 @@ static int __devinit tegra_dma_probe(struct platform_device *pdev) > } > } > > + ret = clk_prepare_enable(tdma->dma_clk); > + if (ret < 0) { > + dev_err(&pdev->dev, "clk_prepare_enable failed: %d\n", ret); > + goto err_pm_disable; > + } > + > /* Reset DMA controller */ > tegra_periph_reset_assert(tdma->dma_clk); > udelay(2); > @@ -1363,6 +1369,7 @@ static int __devexit tegra_dma_remove(struct platform_device *pdev) > if (!pm_runtime_status_suspended(&pdev->dev)) > tegra_dma_runtime_suspend(&pdev->dev); > > + clk_disable_unprepare(tdma->dma_clk); > return 0; > } > -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@linux.intel.com> To: Laxman Dewangan <ldewangan@nvidia.com> Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org, swarren@nvidia.com, linux-tegra@vger.kernel.org Subject: Re: [PATCH] dma: tegra: enable/disable dma clock Date: Fri, 20 Jul 2012 11:32:21 +0530 [thread overview] Message-ID: <1342764141.1726.199.camel@vkoul-udesk3> (raw) In-Reply-To: <1342601769-13852-1-git-send-email-ldewangan@nvidia.com> On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > Enable the DMA clock when registering DMA driver and > disable clock when removing the DMA driver. > > The failure was observed on Tegra20 based system by > Stephen Warren. However, it is working fine on tegra30 > based system and probably becasue uboot enable the clock > on Tegra30. Don't know much about the clock subsystem, but shouldn't the clocks be enabled runtime..... when you actually start using the controller?? > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > Reported-by: Stephen Warren <swarren@wwwdotorg.org> > --- > drivers/dma/tegra20-apb-dma.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index d52dbc6..ccfdaf4 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1255,6 +1255,12 @@ static int __devinit tegra_dma_probe(struct platform_device *pdev) > } > } > > + ret = clk_prepare_enable(tdma->dma_clk); > + if (ret < 0) { > + dev_err(&pdev->dev, "clk_prepare_enable failed: %d\n", ret); > + goto err_pm_disable; > + } > + > /* Reset DMA controller */ > tegra_periph_reset_assert(tdma->dma_clk); > udelay(2); > @@ -1363,6 +1369,7 @@ static int __devexit tegra_dma_remove(struct platform_device *pdev) > if (!pm_runtime_status_suspended(&pdev->dev)) > tegra_dma_runtime_suspend(&pdev->dev); > > + clk_disable_unprepare(tdma->dma_clk); > return 0; > } > -- ~Vinod
next prev parent reply other threads:[~2012-07-20 6:02 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-18 8:56 [PATCH] dma: tegra: enable/disable dma clock Laxman Dewangan 2012-07-18 8:56 ` Laxman Dewangan [not found] ` <1342601769-13852-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2012-07-20 6:02 ` Vinod Koul [this message] 2012-07-20 6:02 ` Vinod Koul 2012-07-20 6:04 ` Laxman Dewangan 2012-07-20 6:04 ` Laxman Dewangan [not found] ` <5008F4D8.9070108-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2012-07-20 6:40 ` Vinod Koul 2012-07-20 6:40 ` Vinod Koul 2012-07-20 6:34 ` Laxman Dewangan 2012-07-20 6:34 ` Laxman Dewangan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1342764141.1726.199.camel@vkoul-udesk3 \ --to=vinod.koul-vuqaysv1563yd54fqh9/ca@public.gmane.org \ --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.