* superfluous "got a timer mode" message?
@ 2012-07-20 9:22 Andre Przywara
2012-07-20 9:33 ` [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?) Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Andre Przywara @ 2012-07-20 9:22 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, xen-devel
Hi,
while starting some guests I saw this on my terminal:
got a timer mode string: "no_missed_ticks_pending"
I suppose this is a debug leftover? At least we may want to somehow log
this instead of doing "fprintf(stderr" and scare the user?
I actually changed my config file from timer_mode=2 to this one to get
rid of the warning, now I only got a new "warning" in return...
Replacing fprintf with LOG didn't help, so I leave it to you to do a
proper fix ;-)
Regards,
Andre
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?)
2012-07-20 9:22 superfluous "got a timer mode" message? Andre Przywara
@ 2012-07-20 9:33 ` Ian Campbell
2012-07-20 11:03 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2012-07-20 9:33 UTC (permalink / raw)
To: Andre Przywara; +Cc: Ian Jackson, xen-devel
On Fri, 2012-07-20 at 10:22 +0100, Andre Przywara wrote:
> Hi,
>
> while starting some guests I saw this on my terminal:
>
> got a timer mode string: "no_missed_ticks_pending"
>
> I suppose this is a debug leftover?
Indeed, lets remove it.
8<--------------------------
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1342776718 -3600
# Node ID 27860c8b0968414787b4f077b8e1a21c9d85d5c2
# Parent f3ad5f33c34a5e981d9ffd56f112b96a86e36109
xl: remove stray timer mode debug print
Reported-by: Andre Przywara <andre.przywara@amd.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r f3ad5f33c34a -r 27860c8b0968 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Fri Jul 20 10:31:07 2012 +0100
+++ b/tools/libxl/xl_cmdimpl.c Fri Jul 20 10:31:58 2012 +0100
@@ -836,7 +836,6 @@ static void parse_config_data(const char
}
b_info->u.hvm.timer_mode = l;
} else if (!xlu_cfg_get_string(config, "timer_mode", &buf, 0)) {
- fprintf(stderr, "got a timer mode string: \"%s\"\n", buf);
if (libxl_timer_mode_from_string(buf, &b_info->u.hvm.timer_mode)) {
fprintf(stderr, "ERROR: invalid value \"%s\" for \"timer_mode\"\n",
buf);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?)
2012-07-20 9:33 ` [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?) Ian Campbell
@ 2012-07-20 11:03 ` Ian Jackson
2012-07-23 12:14 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Ian Jackson @ 2012-07-20 11:03 UTC (permalink / raw)
To: Ian Campbell; +Cc: Andre Przywara, xen-devel
Ian Campbell writes ("[PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?)"):
> xl: remove stray timer mode debug print
>
> Reported-by: Andre Przywara <andre.przywara@amd.com>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?)
2012-07-20 11:03 ` Ian Jackson
@ 2012-07-23 12:14 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2012-07-23 12:14 UTC (permalink / raw)
To: Ian Jackson; +Cc: Andre Przywara, xen-devel
On Fri, 2012-07-20 at 12:03 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?)"):
> > xl: remove stray timer mode debug print
> >
> > Reported-by: Andre Przywara <andre.przywara@amd.com>
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-23 12:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-20 9:22 superfluous "got a timer mode" message? Andre Przywara
2012-07-20 9:33 ` [PATCH] xl: remove stray timer mode debug print (Was: Re: superfluous "got a timer mode" message?) Ian Campbell
2012-07-20 11:03 ` Ian Jackson
2012-07-23 12:14 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.