* [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment
@ 2012-07-20 21:04 Stefan Weil
2012-07-21 9:48 ` Stefan Hajnoczi
2012-07-23 18:49 ` Blue Swirl
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Weil @ 2012-07-20 21:04 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code,
but left the related comment at a location where it no longer
belongs to.
The patch moves the comment to the correct callback and improves the text.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/qdev.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/qdev.h b/hw/qdev.h
index 247dd1e..a2cbd9d 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -78,12 +78,6 @@ struct DeviceState {
int alias_required_for_version;
};
-/*
- * This callback is used to create Open Firmware device path in accordance with
- * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus bindings
- * can be found here http://playground.sun.com/1275/bindings/.
- */
-
#define TYPE_BUS "bus"
#define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS)
#define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS)
@@ -95,6 +89,11 @@ struct BusClass {
/* FIXME first arg should be BusState */
void (*print_dev)(Monitor *mon, DeviceState *dev, int indent);
char *(*get_dev_path)(DeviceState *dev);
+ /*
+ * This callback is used to create Open Firmware device path in accordance
+ * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus
+ * bindings can be found at http://playground.sun.com/1275/bindings/.
+ */
char *(*get_fw_dev_path)(DeviceState *dev);
int (*reset)(BusState *bus);
};
--
1.7.10
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment
2012-07-20 21:04 [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment Stefan Weil
@ 2012-07-21 9:48 ` Stefan Hajnoczi
2012-07-23 18:49 ` Blue Swirl
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-07-21 9:48 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Fri, Jul 20, 2012 at 11:04:49PM +0200, Stefan Weil wrote:
> Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code,
> but left the related comment at a location where it no longer
> belongs to.
>
> The patch moves the comment to the correct callback and improves the text.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/qdev.h | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment
2012-07-20 21:04 [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment Stefan Weil
2012-07-21 9:48 ` Stefan Hajnoczi
@ 2012-07-23 18:49 ` Blue Swirl
2012-07-23 21:46 ` Peter Maydell
1 sibling, 1 reply; 5+ messages in thread
From: Blue Swirl @ 2012-07-23 18:49 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code,
> but left the related comment at a location where it no longer
> belongs to.
>
> The patch moves the comment to the correct callback and improves the text.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/qdev.h | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/hw/qdev.h b/hw/qdev.h
> index 247dd1e..a2cbd9d 100644
> --- a/hw/qdev.h
> +++ b/hw/qdev.h
> @@ -78,12 +78,6 @@ struct DeviceState {
> int alias_required_for_version;
> };
>
> -/*
> - * This callback is used to create Open Firmware device path in accordance with
> - * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus bindings
> - * can be found here http://playground.sun.com/1275/bindings/.
> - */
> -
> #define TYPE_BUS "bus"
> #define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS)
> #define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS)
> @@ -95,6 +89,11 @@ struct BusClass {
> /* FIXME first arg should be BusState */
> void (*print_dev)(Monitor *mon, DeviceState *dev, int indent);
> char *(*get_dev_path)(DeviceState *dev);
> + /*
> + * This callback is used to create Open Firmware device path in accordance
> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus
> + * bindings can be found at http://playground.sun.com/1275/bindings/.
> + */
The links are dead. Since you are improving the text, maybe you could
find archived versions.
> char *(*get_fw_dev_path)(DeviceState *dev);
> int (*reset)(BusState *bus);
> };
> --
> 1.7.10
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment
2012-07-23 18:49 ` Blue Swirl
@ 2012-07-23 21:46 ` Peter Maydell
2012-07-24 17:49 ` Stefan Weil
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2012-07-23 21:46 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-trivial, Stefan Weil, qemu-devel
On 23 July 2012 19:49, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
>> + /*
>> + * This callback is used to create Open Firmware device path in accordance
>> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus
>> + * bindings can be found at http://playground.sun.com/1275/bindings/.
>> + */
>
> The links are dead. Since you are improving the text, maybe you could
> find archived versions.
Hard to tell not knowing what the original links were, but maybe
for bus bindings:
http://www.openfirmware.org/ofwg/home.html#OFDbussupps
I suspect that finding a publicly downloadable copy of IEEE1275 is
going to be tricky given it's a commercially published standards doc.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment
2012-07-23 21:46 ` Peter Maydell
@ 2012-07-24 17:49 ` Stefan Weil
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Weil @ 2012-07-24 17:49 UTC (permalink / raw)
To: Peter Maydell; +Cc: Blue Swirl, qemu-devel
Am 23.07.2012 23:46, schrieb Peter Maydell:
> On 23 July 2012 19:49, Blue Swirl<blauwirbel@gmail.com> wrote:
>> On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil<sw@weilnetz.de> wrote:
>>> + /*
>>> + * This callback is used to create Open Firmware device path in accordance
>>> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus
>>> + * bindings can be found at http://playground.sun.com/1275/bindings/.
>>> + */
>>
>> The links are dead. Since you are improving the text, maybe you could
>> find archived versions.
>
> Hard to tell not knowing what the original links were, but maybe
> for bus bindings:
> http://www.openfirmware.org/ofwg/home.html#OFDbussupps
>
> I suspect that finding a publicly downloadable copy of IEEE1275 is
> going to be tricky given it's a commercially published standards doc.
>
> -- PMM
http://www.openfirmware.com/1275/bindings/ seems to be the new
location of the 2nd link.
http://www.openfirmware.info/IEEE_1275-1994 has a link to
http://www.openbios.org/data/docs/of1275.pdf, but it looks like there is a
server configuration problem (error 403). I'll send a mail to the webmaster
of openbios.org.
Regards,
Stefan W.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-24 17:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-20 21:04 [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment Stefan Weil
2012-07-21 9:48 ` Stefan Hajnoczi
2012-07-23 18:49 ` Blue Swirl
2012-07-23 21:46 ` Peter Maydell
2012-07-24 17:49 ` Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.