Re: [PATCH 0 of 3 v5/leftover] Automatic NUMA placement for xl

From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	David Vrabel <dvrabel@cantab.net>
Subject: Re: [PATCH 0 of 3 v5/leftover] Automatic NUMA placement for	xl
Date: Mon, 23 Jul 2012 12:38:26 +0200	[thread overview]
Message-ID: <1343039906.4998.11.camel@Solace> (raw)
In-Reply-To: <1342786124.26734.108.camel@zakaz.uk.xensource.com>

[-- Attachment #1.1: Type: text/plain, Size: 1793 bytes --]

On Fri, 2012-07-20 at 13:08 +0100, Ian Campbell wrote:
> On Fri, 2012-07-20 at 13:00 +0100, Ian Campbell wrote:
> > Even if we just blindly store the current result today as the expected
> > one then when someone makes a tweak we can manually inspect the
> > differences in the output and say "yes, that seems sane" or "no, that's
> > mad". The need to do this will be encoded in the diff which makes the
> > change (since you'd have to patch the test suite...)
> 
> BTW, this is mostly what we do for
> tools/libxl/check-xl-{disk,vif}-parse.
> 
That is very nice, although our case here is a bit different. I can put
together a similar script, and I can also think about some test cases
and methods to check how things are going.

The tricky part is I _can't_ run xl just like we do in that file, as
there's not a specific command for running just the placement, and I
can't invoke `cl create', can I? :-P

So, it seems I should write a sort of C program from which to trigger
the libxl domain creation, after taking care of intercepting and
properly replacing quite a bit of functions to either nops or (e.g., in
case of libxl_get_cpu_topology(), etc) proper reads of the test
database. Also, this involves quite a bit of libxl internal function.
Will I be able to intercept them too? Not sure, I need to check...

How does that sound? I'll think about and try to implement this in next
days, any thoughts that may come to your mind, do feel free to
share. :-D

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel