From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>,
xen-devel <xen-devel@lists.xen.org>,
Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH 1 of 3 v4/leftover] libxl: enable automatic placement of guests on NUMA nodes
Date: Tue, 17 Jul 2012 19:01:04 +0100 [thread overview]
Message-ID: <20485.43104.764629.337904@mariner.uk.xensource.com> (raw)
In-Reply-To: <1342540755.16704.11.camel@zakaz.uk.xensource.com>
Ian Campbell writes ("Re: [PATCH 1 of 3 v4/leftover] libxl: enable automatic placement of guests on NUMA nodes"):
> On Tue, 2012-07-17 at 16:55 +0100, Ian Jackson wrote:
> > 1. This macro max() should be in libxl_internal.h.
> > 2. It should be MAX so people are warned it's a macro
> > 3. It should have all the necessary ()s for macro precedence safety
>
> You probably also want to do the necessary tricks to avoid multiple
> evaluation of the arguments?
Those tricks are a pain. I think in general macros are `allowed' to
do this provided their names are SHOUTY. That's why it should be
called `MAX'.
Ian.
next prev parent reply other threads:[~2012-07-17 18:01 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 15:03 [PATCH 0 of 3 v4/leftover] Automatic NUMA placement for xl Dario Faggioli
2012-07-10 15:03 ` [PATCH 1 of 3 v4/leftover] libxl: enable automatic placement of guests on NUMA nodes Dario Faggioli
2012-07-17 15:55 ` Ian Jackson
2012-07-16 17:13 ` [PATCH 0 of 3 v5/leftover] Automatic NUMA placement for xl Dario Faggioli
2012-07-16 17:13 ` [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes Dario Faggioli
2012-07-17 18:04 ` [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes [and 1 more messages] Ian Jackson
2012-07-17 20:23 ` Ian Campbell
2012-07-18 0:31 ` Dario Faggioli
2012-07-18 10:44 ` Ian Jackson
2012-07-18 0:22 ` Dario Faggioli
2012-07-18 8:27 ` Dario Faggioli
2012-07-18 9:13 ` Ian Campbell
2012-07-18 9:43 ` Dario Faggioli
2012-07-18 9:53 ` Ian Campbell
2012-07-18 10:08 ` Dario Faggioli
2012-07-18 11:00 ` Ian Jackson
2012-07-18 13:14 ` Ian Campbell
2012-07-18 13:35 ` Dario Faggioli
2012-07-19 12:47 ` Dario Faggioli
2012-07-18 13:40 ` Andre Przywara
2012-07-18 13:54 ` Juergen Gross
2012-07-18 14:00 ` Dario Faggioli
2012-07-19 14:43 ` Ian Jackson
2012-07-19 18:37 ` Andre Przywara
2012-07-21 1:46 ` Dario Faggioli
2012-07-18 10:53 ` Ian Jackson
2012-07-18 13:12 ` Ian Campbell
2012-07-18 9:47 ` Dario Faggioli
2012-07-19 12:21 ` [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes Andre Przywara
2012-07-19 14:22 ` Dario Faggioli
2012-07-20 8:19 ` Andre Przywara
2012-07-20 9:39 ` Dario Faggioli
2012-07-20 10:01 ` Dario Faggioli
2012-07-20 8:20 ` Dario Faggioli
2012-07-20 8:26 ` Andre Przywara
2012-07-20 8:38 ` Juergen Gross
2012-07-20 9:52 ` Dario Faggioli
2012-07-20 9:56 ` Juergen Gross
2012-07-20 9:44 ` Dario Faggioli
2012-07-20 11:47 ` Andre Przywara
2012-07-20 12:54 ` Dario Faggioli
2012-07-20 13:07 ` Andre Przywara
2012-07-21 1:44 ` Dario Faggioli
2012-07-16 17:13 ` [PATCH 2 of 3 v5/leftover] libxl: have NUMA placement deal with cpupools Dario Faggioli
2012-07-16 17:13 ` [PATCH 3 of 3 v5/leftover] Some automatic NUMA placement documentation Dario Faggioli
2012-07-20 11:07 ` [PATCH 0 of 3 v5/leftover] Automatic NUMA placement for xl David Vrabel
2012-07-20 11:43 ` Andre Przywara
2012-07-20 12:00 ` Ian Campbell
2012-07-20 12:08 ` Ian Campbell
2012-07-23 10:38 ` Dario Faggioli
2012-07-23 10:42 ` Ian Campbell
2012-07-23 15:31 ` Dario Faggioli
2012-07-23 10:23 ` Dario Faggioli
2012-07-20 12:14 ` David Vrabel
2012-07-17 15:59 ` [PATCH 1 of 3 v4/leftover] libxl: enable automatic placement of guests on NUMA nodes Ian Campbell
2012-07-17 18:01 ` Ian Jackson [this message]
2012-07-17 22:15 ` Dario Faggioli
2012-07-10 15:03 ` [PATCH 2 of 3 v4/leftover] libxl: have NUMA placement deal with cpupools Dario Faggioli
2012-07-10 15:03 ` [PATCH 3 of 3 v4/leftover] Some automatic NUMA placement documentation Dario Faggioli
2012-07-16 17:03 ` [PATCH 0 of 3 v4/leftover] Automatic NUMA placement for xl Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20485.43104.764629.337904@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=raistlin@linux.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.