Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2012-07-04 at 13:17 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1341404234 -7200
> # Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
> # Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
> libxl: fix unitialized variables in libxl__primary_console_find

Olaf,

I have a vague recollection of some discussion of this and a different
fix but I can't actually find any such discussion and the patch is still
in my queue. Is this still needed?

> gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
> LIBXL_DOMAIN_TYPE_INVALID properly:

That's kind of lame of gcc...

I wonder if default: abort() might be more appropriate (I'm not sure
what our policy here ended up being).

> cc1: warnings being treated as errors
> libxl.c: In function 'libxl_primary_console_exec':
> libxl.c:1408:14: error: 'domid' may be used uninitialized in this function
> libxl.c:1409:9: error: 'cons_num' may be used uninitialized in this function
> libxl.c:1410:24: error: 'type' may be used uninitialized in this function
> libxl.c: In function 'libxl_primary_console_get_tty':
> libxl.c:1421:14: error: 'domid' may be used uninitialized in this function
> libxl.c:1422:9: error: 'cons_num' may be used uninitialized in this function
> libxl.c:1423:24: error: 'type' may be used uninitialized in this function
> make[3]: *** [libxl.o] Error 1
> 
> Fix this by adding a default case.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r 42f76d536b11 -r 5668cb98eebb tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1392,6 +1392,7 @@ static int libxl__primary_console_find(l
>              *type = LIBXL_CONSOLE_TYPE_PV;
>              break;
>          case LIBXL_DOMAIN_TYPE_INVALID:
> +        default:
>              rc = ERROR_INVAL;
>              goto out;
>          }
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel