From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find
Date: Mon, 23 Jul 2012 15:43:48 +0200 [thread overview]
Message-ID: <20120723134348.GA32746@aepfle.de> (raw)
In-Reply-To: <1343040673.4091.16.camel@zakaz.uk.xensource.com>
On Mon, Jul 23, Ian Campbell wrote:
> On Wed, 2012-07-04 at 13:17 +0100, Olaf Hering wrote:
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1341404234 -7200
> > # Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
> > # Parent 42f76d536b116d2ebad1b6705ae51ecd171d2581
> > libxl: fix unitialized variables in libxl__primary_console_find
>
> Olaf,
>
> I have a vague recollection of some discussion of this and a different
> fix but I can't actually find any such discussion and the patch is still
> in my queue. Is this still needed?
Yes.
> > gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
> > LIBXL_DOMAIN_TYPE_INVALID properly:
>
> That's kind of lame of gcc...
>
> I wonder if default: abort() might be more appropriate (I'm not sure
> what our policy here ended up being).
libxl__domain_type is a simple and internal function. Perhaps a comment
about why a 'default' case exists is enough.
Olaf
next prev parent reply other threads:[~2012-07-23 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 12:17 [PATCH] libxl: fix unitialized variables in libxl__primary_console_find Olaf Hering
2012-07-23 10:51 ` Ian Campbell
2012-07-23 13:43 ` Olaf Hering [this message]
2012-07-24 8:45 ` Ian Campbell
2012-07-30 19:04 ` Olaf Hering
2012-07-30 16:35 Olaf Hering
2012-08-01 11:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723134348.GA32746@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.