Re: [PATCH 2 of 4 v6/leftover] xl: inform libxl if there was a cpumap in the config file

From: Dario Faggioli <raistlin@linux.it>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2 of 4 v6/leftover] xl: inform libxl if there was a cpumap in the config file
Date: Mon, 23 Jul 2012 15:35:56 +0200	[thread overview]
Message-ID: <1343050556.4998.16.camel@Solace> (raw)
In-Reply-To: <20493.12221.272930.55159@mariner.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1475 bytes --]

On Mon, 2012-07-23 at 12:04 +0100, Ian Jackson wrote:
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -212,7 +212,8 @@ int libxl__build_pre(libxl__gc *gc, uint
> >       * call to libxl_set_vcpuaffinity_all() will do the actual placement,
> >       * whatever that turns out to be.
> >       */
> > -    if (libxl_bitmap_is_full(&info->cpumap)) {
> > +    if (libxl_defbool_val(info->numa_placement) &&
> > +        libxl_bitmap_is_full(&info->cpumap)) {
> >          int rc = numa_place_domain(gc, info);
> 
> Shouldn't this be
> 
>   -    if (libxl_bitmap_is_full(&info->cpumap)) {
>   +    if (libxl_defbool_val(info->numa_placement)) {
>   +        if (!libxl_bitmap_is_full(&info->cpumap)) {
>   +            rc = ERROR_INVAL;
>   +            LOG blah blah invalid not supported
>   +            goto out;
>   +        }
> 
> or the equivalent ?
> 
Mmm... So that if one manage in setting numa_placement to true but also
specify a cpumap we bail out, right? Yes, I think I can go for this.

> Apart from that it looks good to me.
> 
Cool. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel