Re: [PATCH 1 of 4 v6/leftover] libxl: enable automatic placement of guests on NUMA nodes

From: Dario Faggioli <raistlin@linux.it>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1 of 4 v6/leftover] libxl: enable automatic placement of guests on NUMA nodes
Date: Mon, 23 Jul 2012 18:16:13 +0200	[thread overview]
Message-ID: <1343060173.4998.44.camel@Solace> (raw)
In-Reply-To: <20493.29389.201770.581611@mariner.uk.xensource.com>

[-- Attachment #1.1: Type: text/plain, Size: 2490 bytes --]

On Mon, 2012-07-23 at 16:50 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [PATCH 1 of 4 v6/leftover] libxl: enable automatic placement of guests on NUMA nodes"):
> > On Mon, 2012-07-23 at 12:38 +0100, Ian Jackson wrote:
> > > This probably deserves a log message.
> > 
> > It's there: it's being printed by libxl__get_numa_candidate(). It's like
> > that to avoid printing more of them, which would be confusing, e.g.,
> > something like this:
> > 
> >  libxl: ERROR Too many nodes
> >  libxl: ERROR No placement found
> > 
> > Is that acceptable?
> 
> Two messages is better than one vague one.  
>
I agree, but in this specific case, it looked particularly ugly, as we
were telling the user that we decided not to run placement _and_ also
that he should be worried because placement did not succeeded! :-O

> One message would be
> better but then you have to make sure of course that every path
> prints exactly one message.
>
What I want is no path producing two (or more) conflicting indications. 

Basically, putting the message saying that we haven't found any
placement in the function that actually looks for the placement
--instead than in its callers-- I ensure that either an error happens
(and it's logged) before the placement itself could take place, or it
manages in running, does not find anything a log that... And this all
looks reasonable to me.

Also, I tested the various path (by creating fake nodes, etc.), and it
seems to behave as you ask. I'll double check that, if it turns out to
be that way, are you fine with it?

> > Well, it is for me, but as we agreed on 8, I went for that. What I
> > wanted was just make sure we (or whoever else) know/remember that 16
> > cold work too, in case that turns out to be useful in future. That being
> > said, if you agree on raising the cap to 16 right now, I'll be glad to
> > do that. :-D
> 
> I don't have a particular opinion on exactly what the cap should be.
> It should be sufficiently tight to prevent runaways.  A 2^16 worst
> case computation on domain start is certainly arguably acceptable.
> 
Ok, I'll go for 16 then (and will fix the 65536-->65535).

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel