* [PATCH] ipv4: Remove redundant assignment
@ 2012-07-23 14:11 Lin Ming
2012-07-23 20:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lin Ming @ 2012-07-23 14:11 UTC (permalink / raw)
To: David Miller; +Cc: netdev
It is redundant to set no_addr and accept_local to 0 and then set them
with other values just after that.
Signed-off-by: Lin Ming <mlin@ss.pku.edu.cn>
---
net/ipv4/fib_frontend.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index f277cf0..8732cc7 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -258,7 +258,6 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
fl4.flowi4_tos = tos;
fl4.flowi4_scope = RT_SCOPE_UNIVERSE;
- no_addr = accept_local = 0;
no_addr = idev->ifa_list == NULL;
accept_local = IN_DEV_ACCEPT_LOCAL(idev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv4: Remove redundant assignment
2012-07-23 14:11 [PATCH] ipv4: Remove redundant assignment Lin Ming
@ 2012-07-23 20:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-23 20:09 UTC (permalink / raw)
To: mlin; +Cc: netdev
From: Lin Ming <mlin@ss.pku.edu.cn>
Date: Mon, 23 Jul 2012 22:11:21 +0800
> It is redundant to set no_addr and accept_local to 0 and then set them
> with other values just after that.
>
> Signed-off-by: Lin Ming <mlin@ss.pku.edu.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-23 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-23 14:11 [PATCH] ipv4: Remove redundant assignment Lin Ming
2012-07-23 20:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.