* [PATCH] menuconfig: make keys u/d move to the previous/next dialog page
@ 2012-07-24 14:23 Benjamin Poirier
2012-07-24 17:38 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Poirier @ 2012-07-24 14:23 UTC (permalink / raw)
To: Michal Marek; +Cc: Lucas De Marchi, Arnaud Lacombe, linux-kbuild, linux-kernel
... just like less(1) for example.
Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
---
scripts/kconfig/lxdialog/textbox.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index 154c2dd..805200f 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -190,6 +190,7 @@ do_resize:
break;
case 'B': /* Previous page */
case 'b':
+ case 'u':
case KEY_PPAGE:
if (begin_reached)
break;
@@ -214,6 +215,7 @@ do_resize:
break;
case KEY_NPAGE: /* Next page */
case ' ':
+ case 'd':
if (end_reached)
break;
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] menuconfig: make keys u/d move to the previous/next dialog page
2012-07-24 14:23 [PATCH] menuconfig: make keys u/d move to the previous/next dialog page Benjamin Poirier
@ 2012-07-24 17:38 ` Randy Dunlap
2012-07-24 20:12 ` [PATCH v2 1/2] menuconfig: add u, d, q command keys in text boxes Benjamin Poirier
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2012-07-24 17:38 UTC (permalink / raw)
To: Benjamin Poirier
Cc: Michal Marek, Lucas De Marchi, Arnaud Lacombe, linux-kbuild,
linux-kernel
On 07/24/2012 07:23 AM, Benjamin Poirier wrote:
> ... just like less(1) for example.
>
Looks like some help text in mconf.c and nconf.c should be updated
also...
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
> ---
> scripts/kconfig/lxdialog/textbox.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
> index 154c2dd..805200f 100644
> --- a/scripts/kconfig/lxdialog/textbox.c
> +++ b/scripts/kconfig/lxdialog/textbox.c
> @@ -190,6 +190,7 @@ do_resize:
> break;
> case 'B': /* Previous page */
> case 'b':
> + case 'u':
> case KEY_PPAGE:
> if (begin_reached)
> break;
> @@ -214,6 +215,7 @@ do_resize:
> break;
> case KEY_NPAGE: /* Next page */
> case ' ':
> + case 'd':
> if (end_reached)
> break;
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] menuconfig: add u, d, q command keys in text boxes
2012-07-24 17:38 ` Randy Dunlap
@ 2012-07-24 20:12 ` Benjamin Poirier
2012-07-24 20:12 ` [PATCH v2 2/2] nconf: add u, d command keys in scroll windows Benjamin Poirier
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Poirier @ 2012-07-24 20:12 UTC (permalink / raw)
To: Michal Marek
Cc: Lucas De Marchi, Arnaud Lacombe, linux-kbuild, linux-kernel,
Randy Dunlap
They function just like they do in less(1).
Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
---
scripts/kconfig/lxdialog/textbox.c | 3 +++
scripts/kconfig/mconf.c | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index 154c2dd..4e5de60 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -129,6 +129,7 @@ do_resize:
case 'e':
case 'X':
case 'x':
+ case 'q':
delwin(box);
delwin(dialog);
return 0;
@@ -190,6 +191,7 @@ do_resize:
break;
case 'B': /* Previous page */
case 'b':
+ case 'u':
case KEY_PPAGE:
if (begin_reached)
break;
@@ -214,6 +216,7 @@ do_resize:
break;
case KEY_NPAGE: /* Next page */
case ' ':
+ case 'd':
if (end_reached)
break;
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index f606738..f584a28 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -105,10 +105,10 @@ static const char mconf_readme[] = N_(
"Text Box (Help Window)\n"
"--------\n"
"o Use the cursor keys to scroll up/down/left/right. The VI editor\n"
-" keys h,j,k,l function here as do <SPACE BAR> and <B> for those\n"
-" who are familiar with less and lynx.\n"
+" keys h,j,k,l function here as do <u>, <d>, <SPACE BAR> and <B> for \n"
+" those who are familiar with less and lynx.\n"
"\n"
-"o Press <E>, <X>, <Enter> or <Esc><Esc> to exit.\n"
+"o Press <E>, <X>, <q>, <Enter> or <Esc><Esc> to exit.\n"
"\n"
"\n"
"Alternate Configuration Files\n"
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] nconf: add u, d command keys in scroll windows
2012-07-24 20:12 ` [PATCH v2 1/2] menuconfig: add u, d, q command keys in text boxes Benjamin Poirier
@ 2012-07-24 20:12 ` Benjamin Poirier
2012-07-26 10:30 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Poirier @ 2012-07-24 20:12 UTC (permalink / raw)
To: Michal Marek
Cc: Lucas De Marchi, Arnaud Lacombe, linux-kbuild, linux-kernel,
Randy Dunlap
They function just like they do in less(1).
Also correct some discrepancy between the help text and the code wrt
function keys.
Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
---
scripts/kconfig/nconf.c | 6 +++---
scripts/kconfig/nconf.gui.c | 8 +++++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index 8c0eb65..8087e4d 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -83,10 +83,10 @@ static const char nconf_readme[] = N_(
"Text Box (Help Window)\n"
"--------\n"
"o Use the cursor keys to scroll up/down/left/right. The VI editor\n"
-" keys h,j,k,l function here as do <SPACE BAR> for those\n"
-" who are familiar with less and lynx.\n"
+" keys h,j,k,l function here as do <u>, <d> and <SPACE BAR> for\n"
+" those who are familiar with less and lynx.\n"
"\n"
-"o Press <Enter>, <F1>, <F5>, <F7> or <Esc> to exit.\n"
+"o Press <Enter>, <F1>, <F5>, <F9>, <q> or <Esc> to exit.\n"
"\n"
"\n"
"Alternate Configuration Files\n"
diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c
index 3b18dd8..379003c 100644
--- a/scripts/kconfig/nconf.gui.c
+++ b/scripts/kconfig/nconf.gui.c
@@ -604,9 +604,11 @@ void show_scroll_win(WINDOW *main_window,
switch (res) {
case KEY_NPAGE:
case ' ':
+ case 'd':
start_y += text_lines-2;
break;
case KEY_PPAGE:
+ case 'u':
start_y -= text_lines+2;
break;
case KEY_HOME:
@@ -632,10 +634,10 @@ void show_scroll_win(WINDOW *main_window,
start_x++;
break;
}
- if (res == 10 || res == 27 || res == 'q'
- || res == KEY_F(F_BACK) || res == KEY_F(F_EXIT)) {
+ if (res == 10 || res == 27 || res == 'q' ||
+ res == KEY_F(F_HELP) || res == KEY_F(F_BACK) ||
+ res == KEY_F(F_EXIT))
break;
- }
if (start_y < 0)
start_y = 0;
if (start_y >= total_lines-text_lines)
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] nconf: add u, d command keys in scroll windows
2012-07-24 20:12 ` [PATCH v2 2/2] nconf: add u, d command keys in scroll windows Benjamin Poirier
@ 2012-07-26 10:30 ` Michal Marek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Marek @ 2012-07-26 10:30 UTC (permalink / raw)
To: Benjamin Poirier
Cc: Lucas De Marchi, Arnaud Lacombe, linux-kbuild, linux-kernel,
Randy Dunlap
On Tue, Jul 24, 2012 at 04:12:03PM -0400, Benjamin Poirier wrote:
> They function just like they do in less(1).
> Also correct some discrepancy between the help text and the code wrt
> function keys.
>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
Applied to kbuild.git#kconfig, thanks.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-26 10:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-24 14:23 [PATCH] menuconfig: make keys u/d move to the previous/next dialog page Benjamin Poirier
2012-07-24 17:38 ` Randy Dunlap
2012-07-24 20:12 ` [PATCH v2 1/2] menuconfig: add u, d, q command keys in text boxes Benjamin Poirier
2012-07-24 20:12 ` [PATCH v2 2/2] nconf: add u, d command keys in scroll windows Benjamin Poirier
2012-07-26 10:30 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.