* [PATCH] i18n: leave \n out of translated diffstat
@ 2012-07-26 12:52 Nguyễn Thái Ngọc Duy
2012-07-26 17:46 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2012-07-26 12:52 UTC (permalink / raw)
To: git; +Cc: Nguyễn Thái Ngọc Duy
GETTEXT_POISON scrapes everything in translated strings, including \n.
t4205.12 however needs this \n in matching the end result. Keep this
\n out of translation to make t4205.12 happy.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
I haven't followed recent i18n patches closely. Jiang may have
already fixed this in one of his patches. Anyway just in case
everybody does miss this..
Should I resend parseopt i18n marking series now or wait until rc
period is over?
diff.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/diff.c b/diff.c
index 62cbe14..95706a5 100644
--- a/diff.c
+++ b/diff.c
@@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions)
if (!files) {
assert(insertions == 0 && deletions == 0);
- return fputs(_(" 0 files changed\n"), fp);
+ return fprintf(fp, "%s\n", _(" 0 files changed"));
}
strbuf_addf(&sb,
--
1.7.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i18n: leave \n out of translated diffstat
2012-07-26 12:52 [PATCH] i18n: leave \n out of translated diffstat Nguyễn Thái Ngọc Duy
@ 2012-07-26 17:46 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-07-26 17:46 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> diff --git a/diff.c b/diff.c
> index 62cbe14..95706a5 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions)
>
> if (!files) {
> assert(insertions == 0 && deletions == 0);
> - return fputs(_(" 0 files changed\n"), fp);
> + return fprintf(fp, "%s\n", _(" 0 files changed"));
> }
Good.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-26 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-26 12:52 [PATCH] i18n: leave \n out of translated diffstat Nguyễn Thái Ngọc Duy
2012-07-26 17:46 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.