From: Archit Taneja <archit@ti.com> To: tomi.valkeinen@ti.com Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, sumit.semwal@ti.com, rob@ti.com, Archit Taneja <archit@ti.com> Subject: [RFC 17/17] OMAPDSS: VENC: Add a get_timing function for VENC interface Date: Wed, 01 Aug 2012 10:43:28 +0000 [thread overview] Message-ID: <1343817088-29645-18-git-send-email-archit@ti.com> (raw) In-Reply-To: <1343817088-29645-1-git-send-email-archit@ti.com> Add function omapdss_venc_get_timing() which returns the timings maintained by the VENC interface driver in it's driver data. This is just used once by the driver during it's probe. This prevents the need for the panel driver to configure default timings in it's probe. Int the VENC interface's probe, the timings field is set to PAL as a default value. The get_timing op makes more sense for interfaces which can be configured to a default timing. Signed-off-by: Archit Taneja <archit@ti.com> --- drivers/video/omap2/dss/dss.h | 2 ++ drivers/video/omap2/dss/venc.c | 13 +++++++++++++ drivers/video/omap2/dss/venc_panel.c | 11 +++++------ 3 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/dss.h b/drivers/video/omap2/dss/dss.h index 69b6ab9..3fe76c0 100644 --- a/drivers/video/omap2/dss/dss.h +++ b/drivers/video/omap2/dss/dss.h @@ -474,6 +474,8 @@ int omapdss_venc_display_enable(struct omap_dss_device *dssdev); void omapdss_venc_display_disable(struct omap_dss_device *dssdev); void omapdss_venc_set_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings); +void omapdss_venc_get_timings(struct omap_dss_device *dssdev, + struct omap_video_timings *timings); int omapdss_venc_check_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings); u32 omapdss_venc_get_wss(struct omap_dss_device *dssdev); diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c index d96025e..42f97ac 100644 --- a/drivers/video/omap2/dss/venc.c +++ b/drivers/video/omap2/dss/venc.c @@ -579,6 +579,18 @@ void omapdss_venc_set_timings(struct omap_dss_device *dssdev, mutex_unlock(&venc.venc_lock); } +void omapdss_venc_get_timings(struct omap_dss_device *dssdev, + struct omap_video_timings *timings) +{ + DSSDBG("venc_set_timings\n"); + + mutex_lock(&venc.venc_lock); + + *timings = venc.timings; + + mutex_unlock(&venc.venc_lock); +} + int omapdss_venc_check_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings) { @@ -768,6 +780,7 @@ static int __init omap_venchw_probe(struct platform_device *pdev) mutex_init(&venc.venc_lock); venc.wss_data = 0; + venc.timings = omap_dss_pal_timings; venc_mem = platform_get_resource(venc.pdev, IORESOURCE_MEM, 0); if (!venc_mem) { diff --git a/drivers/video/omap2/dss/venc_panel.c b/drivers/video/omap2/dss/venc_panel.c index 350b0d9..fe9958d 100644 --- a/drivers/video/omap2/dss/venc_panel.c +++ b/drivers/video/omap2/dss/venc_panel.c @@ -84,14 +84,13 @@ static DEVICE_ATTR(output_type, S_IRUGO | S_IWUSR, static int venc_panel_probe(struct omap_dss_device *dssdev) { + struct omap_video_timings timings; + mutex_init(&venc_panel.lock); - /* set initial timings to PAL */ - dssdev->panel.timings = (struct omap_video_timings) - { 720, 574, 13500, 64, 12, 68, 5, 5, 41, - OMAPDSS_SIG_ACTIVE_HIGH, OMAPDSS_SIG_ACTIVE_HIGH, - true, - }; + omapdss_venc_get_timings(dssdev, &timings); + + dssdev->panel.timings = timings; return device_create_file(&dssdev->dev, &dev_attr_output_type); } -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <archit@ti.com> To: tomi.valkeinen@ti.com Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, sumit.semwal@ti.com, rob@ti.com, Archit Taneja <archit@ti.com> Subject: [RFC 17/17] OMAPDSS: VENC: Add a get_timing function for VENC interface Date: Wed, 1 Aug 2012 16:01:28 +0530 [thread overview] Message-ID: <1343817088-29645-18-git-send-email-archit@ti.com> (raw) In-Reply-To: <1343817088-29645-1-git-send-email-archit@ti.com> Add function omapdss_venc_get_timing() which returns the timings maintained by the VENC interface driver in it's driver data. This is just used once by the driver during it's probe. This prevents the need for the panel driver to configure default timings in it's probe. Int the VENC interface's probe, the timings field is set to PAL as a default value. The get_timing op makes more sense for interfaces which can be configured to a default timing. Signed-off-by: Archit Taneja <archit@ti.com> --- drivers/video/omap2/dss/dss.h | 2 ++ drivers/video/omap2/dss/venc.c | 13 +++++++++++++ drivers/video/omap2/dss/venc_panel.c | 11 +++++------ 3 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/dss.h b/drivers/video/omap2/dss/dss.h index 69b6ab9..3fe76c0 100644 --- a/drivers/video/omap2/dss/dss.h +++ b/drivers/video/omap2/dss/dss.h @@ -474,6 +474,8 @@ int omapdss_venc_display_enable(struct omap_dss_device *dssdev); void omapdss_venc_display_disable(struct omap_dss_device *dssdev); void omapdss_venc_set_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings); +void omapdss_venc_get_timings(struct omap_dss_device *dssdev, + struct omap_video_timings *timings); int omapdss_venc_check_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings); u32 omapdss_venc_get_wss(struct omap_dss_device *dssdev); diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c index d96025e..42f97ac 100644 --- a/drivers/video/omap2/dss/venc.c +++ b/drivers/video/omap2/dss/venc.c @@ -579,6 +579,18 @@ void omapdss_venc_set_timings(struct omap_dss_device *dssdev, mutex_unlock(&venc.venc_lock); } +void omapdss_venc_get_timings(struct omap_dss_device *dssdev, + struct omap_video_timings *timings) +{ + DSSDBG("venc_set_timings\n"); + + mutex_lock(&venc.venc_lock); + + *timings = venc.timings; + + mutex_unlock(&venc.venc_lock); +} + int omapdss_venc_check_timings(struct omap_dss_device *dssdev, struct omap_video_timings *timings) { @@ -768,6 +780,7 @@ static int __init omap_venchw_probe(struct platform_device *pdev) mutex_init(&venc.venc_lock); venc.wss_data = 0; + venc.timings = omap_dss_pal_timings; venc_mem = platform_get_resource(venc.pdev, IORESOURCE_MEM, 0); if (!venc_mem) { diff --git a/drivers/video/omap2/dss/venc_panel.c b/drivers/video/omap2/dss/venc_panel.c index 350b0d9..fe9958d 100644 --- a/drivers/video/omap2/dss/venc_panel.c +++ b/drivers/video/omap2/dss/venc_panel.c @@ -84,14 +84,13 @@ static DEVICE_ATTR(output_type, S_IRUGO | S_IWUSR, static int venc_panel_probe(struct omap_dss_device *dssdev) { + struct omap_video_timings timings; + mutex_init(&venc_panel.lock); - /* set initial timings to PAL */ - dssdev->panel.timings = (struct omap_video_timings) - { 720, 574, 13500, 64, 12, 68, 5, 5, 41, - OMAPDSS_SIG_ACTIVE_HIGH, OMAPDSS_SIG_ACTIVE_HIGH, - true, - }; + omapdss_venc_get_timings(dssdev, &timings); + + dssdev->panel.timings = timings; return device_create_file(&dssdev->dev, &dev_attr_output_type); } -- 1.7.9.5
next prev parent reply other threads:[~2012-08-01 10:43 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-01 10:31 [RFC 00/17] OMAPDSS: Change way of passing timings from panel driver to interface Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 01/17] OMAPDSS: APPLY: Constify timings argument in dss_mgr_set_timings Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 02/17] OMAPDSS: DPI: Remove omap_dss_device arguments in dpi_set_dsi_clk/dpi_set_dispc_clk Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 03/17] OMAPDSS: HDMI: Remove omap_dss_device argument from hdmi_compute_pll Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 04/17] OMAPDSS: DPI: Add locking for DPI interface Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 05/17] OMAPDSS: DPI: Maintain our own timings field in driver data Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 06/17] OMAPDSS: DPI displays: Take care of panel timings in the driver itself Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 07/17] OMAPDSS: Displays: Add locking in generic DPI panel driver Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 08/17] OMAPDSS: DSI: Maintain own copy of timings in driver data Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-07 14:07 ` Tomi Valkeinen 2012-08-07 14:07 ` Tomi Valkeinen 2012-08-08 5:57 ` Archit Taneja 2012-08-08 6:09 ` Archit Taneja 2012-08-08 6:15 ` Tomi Valkeinen 2012-08-08 6:15 ` Tomi Valkeinen 2012-08-08 6:29 ` Archit Taneja 2012-08-08 6:41 ` Archit Taneja 2012-08-08 7:10 ` Tomi Valkeinen 2012-08-08 7:10 ` Tomi Valkeinen 2012-08-08 7:54 ` Archit Taneja 2012-08-08 8:06 ` Archit Taneja 2012-08-01 10:31 ` [RFC 09/17] OMAPDSS: HDMI: Use our own omap_video_timings field when setting interface timings Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 10/17] OMAPDSS: HDMI: Add a get_timing function for HDMI interface Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 11/17] OMAPDSS: HDMI: Add locking for hdmi interface get/set timing functions Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 12/17] OMAPDSS: SDI: Create a separate function for timing/clock configurations Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 13/17] OMAPDSS: SDI: Create a function to set timings Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-07 14:20 ` Tomi Valkeinen 2012-08-07 14:20 ` Tomi Valkeinen 2012-08-08 5:58 ` Archit Taneja 2012-08-08 6:10 ` Archit Taneja 2012-08-01 10:31 ` [RFC 14/17] OMAPDSS: SDI: Maintain our own timings field in driver data Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 15/17] OMAPDSS: VENC: Split VENC into interface and panel driver Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` [RFC 16/17] OMAPDSS: VENC: Maintain our own timings field in driver data Archit Taneja 2012-08-01 10:43 ` Archit Taneja 2012-08-01 10:31 ` Archit Taneja [this message] 2012-08-01 10:43 ` [RFC 17/17] OMAPDSS: VENC: Add a get_timing function for VENC interface Archit Taneja 2012-08-01 10:35 ` [RFC 00/17] OMAPDSS: Change way of passing timings from panel driver to interface Archit Taneja 2012-08-01 10:47 ` Archit Taneja 2012-08-07 14:32 ` Tomi Valkeinen 2012-08-07 14:32 ` Tomi Valkeinen 2012-08-08 6:05 ` Archit Taneja 2012-08-08 6:17 ` Archit Taneja 2012-08-08 6:25 ` Tomi Valkeinen 2012-08-08 6:25 ` Tomi Valkeinen 2012-08-08 6:47 ` Archit Taneja 2012-08-08 6:59 ` Archit Taneja 2012-08-08 7:27 ` Tomi Valkeinen 2012-08-08 7:27 ` Tomi Valkeinen 2012-08-08 7:59 ` Archit Taneja 2012-08-08 8:11 ` Archit Taneja 2012-08-08 8:13 ` Tomi Valkeinen 2012-08-08 8:13 ` Tomi Valkeinen 2012-08-08 8:38 ` Archit Taneja 2012-08-08 8:50 ` Archit Taneja 2012-08-08 8:48 ` Tomi Valkeinen 2012-08-08 8:48 ` Tomi Valkeinen 2012-08-08 9:24 ` Archit Taneja 2012-08-08 9:36 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 00/13] " Archit Taneja 2012-08-09 11:55 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 01/13] OMAPDSS: DPI: Maintain our own timings field in driver data Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 02/13] OMAPDSS: DPI displays: Take care of panel timings in the driver itself Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 03/13] OMAPDSS: DSI: Maintain own copy of timings in driver data Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 04/13] OMAPDSS: DSI: Add function to set panel size for command mode panels Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 05/13] OMAPDSS: DSI: Update manager timings on a manual update Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 06/13] OMAPDSS: HDMI: Use our own omap_video_timings field when setting interface timings Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 07/13] OMAPDSS: HDMI: Add a get_timing function for HDMI interface Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-14 13:02 ` Tomi Valkeinen 2012-08-14 13:02 ` Tomi Valkeinen 2012-08-14 13:15 ` Archit Taneja 2012-08-14 13:27 ` Archit Taneja 2012-08-14 14:10 ` Tomi Valkeinen 2012-08-14 14:10 ` Tomi Valkeinen 2012-08-14 17:16 ` Archit Taneja 2012-08-14 17:28 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 08/13] OMAPDSS: HDMI: Add locking for hdmi interface get/set timing functions Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 09/13] OMAPDSS: SDI: Create a function to set timings Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-14 13:44 ` Tomi Valkeinen 2012-08-14 13:44 ` Tomi Valkeinen 2012-08-14 16:56 ` Archit Taneja 2012-08-14 17:08 ` Archit Taneja 2012-08-14 17:33 ` Tomi Valkeinen 2012-08-14 17:33 ` Tomi Valkeinen 2012-08-14 19:08 ` Archit Taneja 2012-08-14 19:20 ` Archit Taneja 2012-08-15 6:43 ` Tomi Valkeinen 2012-08-15 6:43 ` Tomi Valkeinen 2012-08-14 19:26 ` Rob Clark 2012-08-14 19:26 ` Rob Clark 2012-08-09 11:49 ` [PATCH v2 10/13] OMAPDSS: SDI: Maintain our own timings field in driver data Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 11/13] OMAPDSS: VENC: Split VENC into interface and panel driver Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 12/13] OMAPDSS: VENC: Maintain our own timings field in driver data Archit Taneja 2012-08-09 11:56 ` Archit Taneja 2012-08-09 11:49 ` [PATCH v2 13/13] OMAPDSS: VENC: Add a get_timing function for VENC interface Archit Taneja 2012-08-09 11:56 ` Archit Taneja
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1343817088-29645-18-git-send-email-archit@ti.com \ --to=archit@ti.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=rob@ti.com \ --cc=sumit.semwal@ti.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.