[PATCH] dlm: convert add_sock routine return value type to void

[PATCH] dlm: convert add_sock routine return value type to void

[Ying Xue]

Since add_sock() always returns a success code - 0, its return
value type should be changed from integer to void.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
---
 fs/dlm/lowcomms.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index e7b0ac0..8789309 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -348,7 +348,7 @@ int dlm_lowcomms_connect_node(int nodeid)
 }
 
 /* Make a socket active */
-static int add_sock(struct socket *sock, struct connection *con)
+static void add_sock(struct socket *sock, struct connection *con)
 {
 	con->sock = sock;
 
@@ -358,7 +358,6 @@ static int add_sock(struct socket *sock, struct connection *con)
 	con->sock->sk->sk_state_change = lowcomms_state_change;
 	con->sock->sk->sk_user_data = con;
 	con->sock->sk->sk_allocation = GFP_NOFS;
-	return 0;
 }
 
 /* Add the port number to an IPv6 or 4 sockaddr and return the address
-- 
1.7.11

Re: [PATCH] dlm: convert add_sock routine return value type to void

[David Teigland]

On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote:
> Since add_sock() always returns a success code - 0, its return
> value type should be changed from integer to void.

Thanks, I've pushed those to my next branch.
Dave