[PATCH] extcon: checkpatch warning removal

[PATCH] extcon: checkpatch warning removal

[anish kumar]

From: anish kumar <anish198519851985@gmail.com>

without this patch we get below warning:
WARNING: externs should be avoided in .c files
132: FILE: extcon/extcon-class.c:
int extcon_set_state(struct extcon_dev *edev, u32 state);

So just removed the declaration.

Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
 drivers/extcon/extcon-class.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 06df95a..6f3391b 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -129,7 +129,6 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
 	return count;
 }
 
-int extcon_set_state(struct extcon_dev *edev, u32 state);
 static ssize_t state_store(struct device *dev, struct device_attribute *attr,
 			   const char *buf, size_t count)
 {
-- 
1.7.1

Re: [PATCH] extcon: checkpatch warning removal

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1337 bytes --]

> From: anish kumar <anish198519851985@gmail.com>
> 
> without this patch we get below warning:
> WARNING: externs should be avoided in .c files
> 132: FILE: extcon/extcon-class.c:
> int extcon_set_state(struct extcon_dev *edev, u32 state);
> 
> So just removed the declaration.
> 
> Signed-off-by: anish kumar <anish198519851985@gmail.com>

Ah.. yes.. I thought removing it could emit compiler errors.
But, we have it declared in the header file. Good.

Thanks.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/extcon/extcon-class.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index 06df95a..6f3391b 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -129,7 +129,6 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  	return count;
>  }
>  
> -int extcon_set_state(struct extcon_dev *edev, u32 state);
>  static ssize_t state_store(struct device *dev, struct device_attribute *attr,
>  			   const char *buf, size_t count)
>  {
> -- 
> 1.7.1
> 
> 
> 
> 
>        
>   
>          
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥