* [PATCH 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-05 2:48 Tetsuyuki Kobayshi
2012-09-06 5:30 ` Tetsuyuki Kobayshi
0 siblings, 1 reply; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-05 2:48 UTC (permalink / raw)
To: linux-sh
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Hello, Simon-san
ARM core has hardware performance counters and perf command uses these counters for detailed profiling information.
The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Tetsuyuki Kobayashi (2):
ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
arch/arm/mach-shmobile/setup-emev2.c | 26 ++++++++++++++++++++++++++
arch/arm/mach-shmobile/setup-sh73a0.c | 26 ++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-05 2:48 [PATCH 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit) Tetsuyuki Kobayshi
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Hello, Simon-san
ARM core has hardware performance counters and perf command uses these counters for detailed profiling information.
The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Tetsuyuki Kobayashi (2):
ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 22 ++++++++++++++++++++++
arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
4 files changed, 46 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Hello, Simon-san
ARM core has hardware performance counters and perf command uses these counters for detailed profiling information.
The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Tetsuyuki Kobayashi (2):
ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 22 ++++++++++++++++++++++
arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
4 files changed, 46 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
2012-09-06 5:30 ` Tetsuyuki Kobayshi
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for sh73a0.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9g_defconfig
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
index 2388c86..5d0c667 100644
--- a/arch/arm/configs/kzm9g_defconfig
+++ b/arch/arm/configs/kzm9g_defconfig
@@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_MODULE_FORCE_LOAD=y
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
index d230af6..8186a08 100644
--- a/arch/arm/mach-shmobile/setup-sh73a0.c
+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
@@ -39,6 +39,7 @@
#include <asm/mach/map.h>
#include <asm/mach/arch.h>
#include <asm/mach/time.h>
+#include <asm/pmu.h>
static struct map_desc sh73a0_io_desc[] __initdata = {
/* create a 1:1 entity map for 0xe6xxxxxx
@@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = gic_spi(55),
+ .end = gic_spi(55),
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = gic_spi(56),
+ .end = gic_spi(56),
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = ARM_PMU_DEVICE_CPU,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *sh73a0_early_devices[] __initdata = {
&scif0_device,
&scif1_device,
@@ -757,6 +778,7 @@ static struct platform_device *sh73a0_late_devices[] __initdata = {
&i2c4_device,
&dma0_device,
&mpdma0_device,
+ &pmu_device,
};
#define SRCR2 0xe61580b0
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for sh73a0.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9g_defconfig
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
index 2388c86..5d0c667 100644
--- a/arch/arm/configs/kzm9g_defconfig
+++ b/arch/arm/configs/kzm9g_defconfig
@@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_MODULE_FORCE_LOAD=y
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
index d230af6..8186a08 100644
--- a/arch/arm/mach-shmobile/setup-sh73a0.c
+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
@@ -39,6 +39,7 @@
#include <asm/mach/map.h>
#include <asm/mach/arch.h>
#include <asm/mach/time.h>
+#include <asm/pmu.h>
static struct map_desc sh73a0_io_desc[] __initdata = {
/* create a 1:1 entity map for 0xe6xxxxxx
@@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = gic_spi(55),
+ .end = gic_spi(55),
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = gic_spi(56),
+ .end = gic_spi(56),
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = ARM_PMU_DEVICE_CPU,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *sh73a0_early_devices[] __initdata = {
&scif0_device,
&scif1_device,
@@ -757,6 +778,7 @@ static struct platform_device *sh73a0_late_devices[] __initdata = {
&i2c4_device,
&dma0_device,
&mpdma0_device,
+ &pmu_device,
};
#define SRCR2 0xe61580b0
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
2012-09-06 5:30 ` Tetsuyuki Kobayshi
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for emev2.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9d_defconfig
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 22 ++++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
index 26146ff..8c49df6 100644
--- a/arch/arm/configs/kzm9d_defconfig
+++ b/arch/arm/configs/kzm9d_defconfig
@@ -8,6 +8,7 @@ CONFIG_LOG_BUF_SHIFT\x16
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_IOSCHED_DEADLINE is not set
diff --git a/arch/arm/mach-shmobile/setup-emev2.c b/arch/arm/mach-shmobile/setup-emev2.c
index dae9aa6..e1219a3 100644
--- a/arch/arm/mach-shmobile/setup-emev2.c
+++ b/arch/arm/mach-shmobile/setup-emev2.c
@@ -36,6 +36,7 @@
#include <asm/mach/map.h>
#include <asm/mach/time.h>
#include <asm/hardware/gic.h>
+#include <asm/pmu.h>
static struct map_desc emev2_io_desc[] __initdata = {
#ifdef CONFIG_SMP
@@ -356,6 +357,26 @@ static struct platform_device gio4_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = 152,
+ .end = 152,
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = 153,
+ .end = 153,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = ARM_PMU_DEVICE_CPU,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *emev2_early_devices[] __initdata = {
&uart0_device,
&uart1_device,
@@ -370,6 +391,7 @@ static struct platform_device *emev2_late_devices[] __initdata = {
&gio2_device,
&gio3_device,
&gio4_device,
+ &pmu_device,
};
void __init emev2_add_standard_devices(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 5:30 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 5:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for emev2.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9d_defconfig
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 22 ++++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
index 26146ff..8c49df6 100644
--- a/arch/arm/configs/kzm9d_defconfig
+++ b/arch/arm/configs/kzm9d_defconfig
@@ -8,6 +8,7 @@ CONFIG_LOG_BUF_SHIFT=16
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_IOSCHED_DEADLINE is not set
diff --git a/arch/arm/mach-shmobile/setup-emev2.c b/arch/arm/mach-shmobile/setup-emev2.c
index dae9aa6..e1219a3 100644
--- a/arch/arm/mach-shmobile/setup-emev2.c
+++ b/arch/arm/mach-shmobile/setup-emev2.c
@@ -36,6 +36,7 @@
#include <asm/mach/map.h>
#include <asm/mach/time.h>
#include <asm/hardware/gic.h>
+#include <asm/pmu.h>
static struct map_desc emev2_io_desc[] __initdata = {
#ifdef CONFIG_SMP
@@ -356,6 +357,26 @@ static struct platform_device gio4_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = 152,
+ .end = 152,
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = 153,
+ .end = 153,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = ARM_PMU_DEVICE_CPU,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *emev2_early_devices[] __initdata = {
&uart0_device,
&uart1_device,
@@ -370,6 +391,7 @@ static struct platform_device *emev2_late_devices[] __initdata = {
&gio2_device,
&gio3_device,
&gio4_device,
+ &pmu_device,
};
void __init emev2_add_standard_devices(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
2012-09-06 5:30 ` Tetsuyuki Kobayshi
@ 2012-09-06 9:11 ` Will Deacon
-1 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-06 9:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 06:30:46AM +0100, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> This patch enables PMU(Performance Monitoring Unit) for sh73a0.
>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
> Changes for v2:
> - Removed #ifdef CONFIG_HW_PERF_EVENTS
> - Added kzm9g_defconfig
>
> arch/arm/configs/kzm9g_defconfig | 1 +
> arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
> index 2388c86..5d0c667 100644
> --- a/arch/arm/configs/kzm9g_defconfig
> +++ b/arch/arm/configs/kzm9g_defconfig
> @@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> CONFIG_SYSCTL_SYSCALL=y
> CONFIG_EMBEDDED=y
> +CONFIG_PERF_EVENTS=y
> CONFIG_SLAB=y
> CONFIG_MODULES=y
> CONFIG_MODULE_FORCE_LOAD=y
> diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> index d230af6..8186a08 100644
> --- a/arch/arm/mach-shmobile/setup-sh73a0.c
> +++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> @@ -39,6 +39,7 @@
> #include <asm/mach/map.h>
> #include <asm/mach/arch.h>
> #include <asm/mach/time.h>
> +#include <asm/pmu.h>
>
> static struct map_desc sh73a0_io_desc[] __initdata = {
> /* create a 1:1 entity map for 0xe6xxxxxx
> @@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
> },
> };
>
> +static struct resource pmu_resources[] = {
> + [0] = {
> + .start = gic_spi(55),
> + .end = gic_spi(55),
> + .flags = IORESOURCE_IRQ,
> + },
> + [1] = {
> + .start = gic_spi(56),
> + .end = gic_spi(56),
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device pmu_device = {
> + .name = "arm-pmu",
> + .id = ARM_PMU_DEVICE_CPU,
> + .num_resources = ARRAY_SIZE(pmu_resources),
> + .resource = pmu_resources,
> +};
Please check my latest perf stuff to go into arm-soc (pmu/cleanup). The
ARM_PMU_DEVICE_CPU crap has disappeared and you won't need to include
asm/pmu.h anymore.
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 9:11 ` Will Deacon
0 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-06 9:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 06:30:46AM +0100, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> This patch enables PMU(Performance Monitoring Unit) for sh73a0.
>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
> Changes for v2:
> - Removed #ifdef CONFIG_HW_PERF_EVENTS
> - Added kzm9g_defconfig
>
> arch/arm/configs/kzm9g_defconfig | 1 +
> arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
> index 2388c86..5d0c667 100644
> --- a/arch/arm/configs/kzm9g_defconfig
> +++ b/arch/arm/configs/kzm9g_defconfig
> @@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> CONFIG_SYSCTL_SYSCALL=y
> CONFIG_EMBEDDED=y
> +CONFIG_PERF_EVENTS=y
> CONFIG_SLAB=y
> CONFIG_MODULES=y
> CONFIG_MODULE_FORCE_LOAD=y
> diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> index d230af6..8186a08 100644
> --- a/arch/arm/mach-shmobile/setup-sh73a0.c
> +++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> @@ -39,6 +39,7 @@
> #include <asm/mach/map.h>
> #include <asm/mach/arch.h>
> #include <asm/mach/time.h>
> +#include <asm/pmu.h>
>
> static struct map_desc sh73a0_io_desc[] __initdata = {
> /* create a 1:1 entity map for 0xe6xxxxxx
> @@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
> },
> };
>
> +static struct resource pmu_resources[] = {
> + [0] = {
> + .start = gic_spi(55),
> + .end = gic_spi(55),
> + .flags = IORESOURCE_IRQ,
> + },
> + [1] = {
> + .start = gic_spi(56),
> + .end = gic_spi(56),
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device pmu_device = {
> + .name = "arm-pmu",
> + .id = ARM_PMU_DEVICE_CPU,
> + .num_resources = ARRAY_SIZE(pmu_resources),
> + .resource = pmu_resources,
> +};
Please check my latest perf stuff to go into arm-soc (pmu/cleanup). The
ARM_PMU_DEVICE_CPU crap has disappeared and you won't need to include
asm/pmu.h anymore.
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
2012-09-06 9:11 ` Will Deacon
@ 2012-09-06 9:57 ` Tetsuyuki Kobayashi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-09-06 9:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello, Will
(2012/09/06 18:11), Will Deacon wrote:
> On Thu, Sep 06, 2012 at 06:30:46AM +0100, Tetsuyuki Kobayshi wrote:
>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>
>> This patch enables PMU(Performance Monitoring Unit) for sh73a0.
>>
>> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>> ---
>> Changes for v2:
>> - Removed #ifdef CONFIG_HW_PERF_EVENTS
>> - Added kzm9g_defconfig
>>
>> arch/arm/configs/kzm9g_defconfig | 1 +
>> arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
>> 2 files changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
>> index 2388c86..5d0c667 100644
>> --- a/arch/arm/configs/kzm9g_defconfig
>> +++ b/arch/arm/configs/kzm9g_defconfig
>> @@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
>> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>> CONFIG_SYSCTL_SYSCALL=y
>> CONFIG_EMBEDDED=y
>> +CONFIG_PERF_EVENTS=y
>> CONFIG_SLAB=y
>> CONFIG_MODULES=y
>> CONFIG_MODULE_FORCE_LOAD=y
>> diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
>> index d230af6..8186a08 100644
>> --- a/arch/arm/mach-shmobile/setup-sh73a0.c
>> +++ b/arch/arm/mach-shmobile/setup-sh73a0.c
>> @@ -39,6 +39,7 @@
>> #include <asm/mach/map.h>
>> #include <asm/mach/arch.h>
>> #include <asm/mach/time.h>
>> +#include <asm/pmu.h>
>>
>> static struct map_desc sh73a0_io_desc[] __initdata = {
>> /* create a 1:1 entity map for 0xe6xxxxxx
>> @@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
>> },
>> };
>>
>> +static struct resource pmu_resources[] = {
>> + [0] = {
>> + .start = gic_spi(55),
>> + .end = gic_spi(55),
>> + .flags = IORESOURCE_IRQ,
>> + },
>> + [1] = {
>> + .start = gic_spi(56),
>> + .end = gic_spi(56),
>> + .flags = IORESOURCE_IRQ,
>> + },
>> +};
>> +
>> +static struct platform_device pmu_device = {
>> + .name = "arm-pmu",
>> + .id = ARM_PMU_DEVICE_CPU,
>> + .num_resources = ARRAY_SIZE(pmu_resources),
>> + .resource = pmu_resources,
>> +};
>
> Please check my latest perf stuff to go into arm-soc (pmu/cleanup). The
> ARM_PMU_DEVICE_CPU crap has disappeared and you won't need to include
> asm/pmu.h anymore.
>
Thak you, Will. I'm checking out pmu/cleanup branch of arm-soc.
I will post v3 patch based on it.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 9:57 ` Tetsuyuki Kobayashi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-09-06 9:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello, Will
(2012/09/06 18:11), Will Deacon wrote:
> On Thu, Sep 06, 2012 at 06:30:46AM +0100, Tetsuyuki Kobayshi wrote:
>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>
>> This patch enables PMU(Performance Monitoring Unit) for sh73a0.
>>
>> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>> ---
>> Changes for v2:
>> - Removed #ifdef CONFIG_HW_PERF_EVENTS
>> - Added kzm9g_defconfig
>>
>> arch/arm/configs/kzm9g_defconfig | 1 +
>> arch/arm/mach-shmobile/setup-sh73a0.c | 22 ++++++++++++++++++++++
>> 2 files changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
>> index 2388c86..5d0c667 100644
>> --- a/arch/arm/configs/kzm9g_defconfig
>> +++ b/arch/arm/configs/kzm9g_defconfig
>> @@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
>> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>> CONFIG_SYSCTL_SYSCALL=y
>> CONFIG_EMBEDDED=y
>> +CONFIG_PERF_EVENTS=y
>> CONFIG_SLAB=y
>> CONFIG_MODULES=y
>> CONFIG_MODULE_FORCE_LOAD=y
>> diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
>> index d230af6..8186a08 100644
>> --- a/arch/arm/mach-shmobile/setup-sh73a0.c
>> +++ b/arch/arm/mach-shmobile/setup-sh73a0.c
>> @@ -39,6 +39,7 @@
>> #include <asm/mach/map.h>
>> #include <asm/mach/arch.h>
>> #include <asm/mach/time.h>
>> +#include <asm/pmu.h>
>>
>> static struct map_desc sh73a0_io_desc[] __initdata = {
>> /* create a 1:1 entity map for 0xe6xxxxxx
>> @@ -734,6 +735,26 @@ static struct platform_device mpdma0_device = {
>> },
>> };
>>
>> +static struct resource pmu_resources[] = {
>> + [0] = {
>> + .start = gic_spi(55),
>> + .end = gic_spi(55),
>> + .flags = IORESOURCE_IRQ,
>> + },
>> + [1] = {
>> + .start = gic_spi(56),
>> + .end = gic_spi(56),
>> + .flags = IORESOURCE_IRQ,
>> + },
>> +};
>> +
>> +static struct platform_device pmu_device = {
>> + .name = "arm-pmu",
>> + .id = ARM_PMU_DEVICE_CPU,
>> + .num_resources = ARRAY_SIZE(pmu_resources),
>> + .resource = pmu_resources,
>> +};
>
> Please check my latest perf stuff to go into arm-soc (pmu/cleanup). The
> ARM_PMU_DEVICE_CPU crap has disappeared and you won't need to include
> asm/pmu.h anymore.
>
Thak you, Will. I'm checking out pmu/cleanup branch of arm-soc.
I will post v3 patch based on it.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-06 9:57 ` Tetsuyuki Kobayashi
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Hello, Will
Could you apply this patch set to your pmu/cleanup branch on arm-soc?
The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Tetsuyuki Kobayashi (2):
ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 21 +++++++++++++++++++++
arch/arm/mach-shmobile/setup-sh73a0.c | 21 +++++++++++++++++++++
4 files changed, 44 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Hello, Will
Could you apply this patch set to your pmu/cleanup branch on arm-soc?
The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Tetsuyuki Kobayashi (2):
ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 21 +++++++++++++++++++++
arch/arm/mach-shmobile/setup-sh73a0.c | 21 +++++++++++++++++++++
4 files changed, 44 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
2012-09-06 11:14 ` Tetsuyuki Kobayshi
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for sh73a0.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9g_defconfig
Changes for v3:
- Rebased to pmu/clean on arm-soc.
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-sh73a0.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
index 2388c86..5d0c667 100644
--- a/arch/arm/configs/kzm9g_defconfig
+++ b/arch/arm/configs/kzm9g_defconfig
@@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_MODULE_FORCE_LOAD=y
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
index d230af6..38ed2dd 100644
--- a/arch/arm/mach-shmobile/setup-sh73a0.c
+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
@@ -734,6 +734,26 @@ static struct platform_device mpdma0_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = gic_spi(55),
+ .end = gic_spi(55),
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = gic_spi(56),
+ .end = gic_spi(56),
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = -1,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *sh73a0_early_devices[] __initdata = {
&scif0_device,
&scif1_device,
@@ -757,6 +777,7 @@ static struct platform_device *sh73a0_late_devices[] __initdata = {
&i2c4_device,
&dma0_device,
&mpdma0_device,
+ &pmu_device,
};
#define SRCR2 0xe61580b0
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 1/2] ARM: shmobile: sh73a0: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for sh73a0.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9g_defconfig
Changes for v3:
- Rebased to pmu/clean on arm-soc.
arch/arm/configs/kzm9g_defconfig | 1 +
arch/arm/mach-shmobile/setup-sh73a0.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
index 2388c86..5d0c667 100644
--- a/arch/arm/configs/kzm9g_defconfig
+++ b/arch/arm/configs/kzm9g_defconfig
@@ -14,6 +14,7 @@ CONFIG_NAMESPACES=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_MODULE_FORCE_LOAD=y
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
index d230af6..38ed2dd 100644
--- a/arch/arm/mach-shmobile/setup-sh73a0.c
+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
@@ -734,6 +734,26 @@ static struct platform_device mpdma0_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = gic_spi(55),
+ .end = gic_spi(55),
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = gic_spi(56),
+ .end = gic_spi(56),
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = -1,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *sh73a0_early_devices[] __initdata = {
&scif0_device,
&scif1_device,
@@ -757,6 +777,7 @@ static struct platform_device *sh73a0_late_devices[] __initdata = {
&i2c4_device,
&dma0_device,
&mpdma0_device,
+ &pmu_device,
};
#define SRCR2 0xe61580b0
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 2/2] ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
2012-09-06 11:14 ` Tetsuyuki Kobayshi
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for emev2.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9d_defconfig
Changes for v3:
- Rebased to pmu/clean on arm-soc.
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
index 26146ff..8c49df6 100644
--- a/arch/arm/configs/kzm9d_defconfig
+++ b/arch/arm/configs/kzm9d_defconfig
@@ -8,6 +8,7 @@ CONFIG_LOG_BUF_SHIFT\x16
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_IOSCHED_DEADLINE is not set
diff --git a/arch/arm/mach-shmobile/setup-emev2.c b/arch/arm/mach-shmobile/setup-emev2.c
index dae9aa6..61446f3 100644
--- a/arch/arm/mach-shmobile/setup-emev2.c
+++ b/arch/arm/mach-shmobile/setup-emev2.c
@@ -356,6 +356,26 @@ static struct platform_device gio4_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = 152,
+ .end = 152,
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = 153,
+ .end = 153,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = -1,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *emev2_early_devices[] __initdata = {
&uart0_device,
&uart1_device,
@@ -370,6 +390,7 @@ static struct platform_device *emev2_late_devices[] __initdata = {
&gio2_device,
&gio3_device,
&gio4_device,
+ &pmu_device,
};
void __init emev2_add_standard_devices(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 2/2] ARM: shmobile: emev2: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 11:14 ` Tetsuyuki Kobayshi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-09-06 11:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
This patch enables PMU(Performance Monitoring Unit) for emev2.
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- Removed #ifdef CONFIG_HW_PERF_EVENTS
- Added kzm9d_defconfig
Changes for v3:
- Rebased to pmu/clean on arm-soc.
arch/arm/configs/kzm9d_defconfig | 1 +
arch/arm/mach-shmobile/setup-emev2.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
index 26146ff..8c49df6 100644
--- a/arch/arm/configs/kzm9d_defconfig
+++ b/arch/arm/configs/kzm9d_defconfig
@@ -8,6 +8,7 @@ CONFIG_LOG_BUF_SHIFT=16
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_EMBEDDED=y
+CONFIG_PERF_EVENTS=y
CONFIG_SLAB=y
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_IOSCHED_DEADLINE is not set
diff --git a/arch/arm/mach-shmobile/setup-emev2.c b/arch/arm/mach-shmobile/setup-emev2.c
index dae9aa6..61446f3 100644
--- a/arch/arm/mach-shmobile/setup-emev2.c
+++ b/arch/arm/mach-shmobile/setup-emev2.c
@@ -356,6 +356,26 @@ static struct platform_device gio4_device = {
},
};
+static struct resource pmu_resources[] = {
+ [0] = {
+ .start = 152,
+ .end = 152,
+ .flags = IORESOURCE_IRQ,
+ },
+ [1] = {
+ .start = 153,
+ .end = 153,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device pmu_device = {
+ .name = "arm-pmu",
+ .id = -1,
+ .num_resources = ARRAY_SIZE(pmu_resources),
+ .resource = pmu_resources,
+};
+
static struct platform_device *emev2_early_devices[] __initdata = {
&uart0_device,
&uart1_device,
@@ -370,6 +390,7 @@ static struct platform_device *emev2_late_devices[] __initdata = {
&gio2_device,
&gio3_device,
&gio4_device,
+ &pmu_device,
};
void __init emev2_add_standard_devices(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-06 11:14 ` Tetsuyuki Kobayshi
@ 2012-09-06 11:21 ` Will Deacon
-1 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-06 11:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Hello, Will
Hi,
Thanks for updating the patches.
> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
Actually, it's better if you just base your branch against that one when you
send it to arm-soc for merging. That way, other SoCs can also develop
against that branch without having to worry about each other.
Cheers,
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-06 11:21 ` Will Deacon
0 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-06 11:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Hello, Will
Hi,
Thanks for updating the patches.
> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
Actually, it's better if you just base your branch against that one when you
send it to arm-soc for merging. That way, other SoCs can also develop
against that branch without having to worry about each other.
Cheers,
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-06 11:21 ` Will Deacon
@ 2012-09-07 1:50 ` Tetsuyuki Kobayashi
-1 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-09-07 1:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Will
Hi, Simon
(2012/09/06 20:21), Will Deacon wrote:
> On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>
>> Hello, Will
>
> Hi,
>
> Thanks for updating the patches.
>
>> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
>
> Actually, it's better if you just base your branch against that one when you
> send it to arm-soc for merging. That way, other SoCs can also develop
> against that branch without having to worry about each other.
>
I see.
I thought that removing ARM_PMU_DEVICE_CPU depends on your pmu/cleanup
branch, but I found it does not.
I verified this v3 patch can apply cleanly to soc branch on renesus.git
and works fine.
Simon-san, could you apply this v3 patch to soc branch after review ?
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-07 1:50 ` Tetsuyuki Kobayashi
0 siblings, 0 replies; 27+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-09-07 1:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Will
Hi, Simon
(2012/09/06 20:21), Will Deacon wrote:
> On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>
>> Hello, Will
>
> Hi,
>
> Thanks for updating the patches.
>
>> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
>
> Actually, it's better if you just base your branch against that one when you
> send it to arm-soc for merging. That way, other SoCs can also develop
> against that branch without having to worry about each other.
>
I see.
I thought that removing ARM_PMU_DEVICE_CPU depends on your pmu/cleanup
branch, but I found it does not.
I verified this v3 patch can apply cleanly to soc branch on renesus.git
and works fine.
Simon-san, could you apply this v3 patch to soc branch after review ?
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-07 1:50 ` Tetsuyuki Kobayashi
@ 2012-09-07 8:46 ` Will Deacon
-1 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-07 8:46 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 07, 2012 at 02:50:47AM +0100, Tetsuyuki Kobayashi wrote:
> (2012/09/06 20:21), Will Deacon wrote:
> > On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> >> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> > Actually, it's better if you just base your branch against that one when you
> > send it to arm-soc for merging. That way, other SoCs can also develop
> > against that branch without having to worry about each other.
> >
> I see.
> I thought that removing ARM_PMU_DEVICE_CPU depends on your pmu/cleanup
> branch, but I found it does not.
It will probably build alright for you without my patches, but I don't
thinkt it will work correctly as we'll fail to reserve the PMU.
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-07 8:46 ` Will Deacon
0 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2012-09-07 8:46 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 07, 2012 at 02:50:47AM +0100, Tetsuyuki Kobayashi wrote:
> (2012/09/06 20:21), Will Deacon wrote:
> > On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> >> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> > Actually, it's better if you just base your branch against that one when you
> > send it to arm-soc for merging. That way, other SoCs can also develop
> > against that branch without having to worry about each other.
> >
> I see.
> I thought that removing ARM_PMU_DEVICE_CPU depends on your pmu/cleanup
> branch, but I found it does not.
It will probably build alright for you without my patches, but I don't
thinkt it will work correctly as we'll fail to reserve the PMU.
Will
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-07 1:50 ` Tetsuyuki Kobayashi
@ 2012-09-07 13:25 ` Simon Horman
-1 siblings, 0 replies; 27+ messages in thread
From: Simon Horman @ 2012-09-07 13:25 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 07, 2012 at 10:50:47AM +0900, Tetsuyuki Kobayashi wrote:
> Hi, Will
> Hi, Simon
>
> (2012/09/06 20:21), Will Deacon wrote:
> >On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> >>From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> >>
> >>Hello, Will
> >
> >Hi,
> >
> >Thanks for updating the patches.
> >
> >>Could you apply this patch set to your pmu/cleanup branch on arm-soc?
> >
> >Actually, it's better if you just base your branch against that one when you
> >send it to arm-soc for merging. That way, other SoCs can also develop
> >against that branch without having to worry about each other.
> >
> I see.
> I thought that removing ARM_PMU_DEVICE_CPU depends on your
> pmu/cleanup branch, but I found it does not.
> I verified this v3 patch can apply cleanly to soc branch on renesus.git
> and works fine.
>
> Simon-san, could you apply this v3 patch to soc branch after review ?
Sure, will do.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-07 13:25 ` Simon Horman
0 siblings, 0 replies; 27+ messages in thread
From: Simon Horman @ 2012-09-07 13:25 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 07, 2012 at 10:50:47AM +0900, Tetsuyuki Kobayashi wrote:
> Hi, Will
> Hi, Simon
>
> (2012/09/06 20:21), Will Deacon wrote:
> >On Thu, Sep 06, 2012 at 12:14:05PM +0100, Tetsuyuki Kobayshi wrote:
> >>From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> >>
> >>Hello, Will
> >
> >Hi,
> >
> >Thanks for updating the patches.
> >
> >>Could you apply this patch set to your pmu/cleanup branch on arm-soc?
> >
> >Actually, it's better if you just base your branch against that one when you
> >send it to arm-soc for merging. That way, other SoCs can also develop
> >against that branch without having to worry about each other.
> >
> I see.
> I thought that removing ARM_PMU_DEVICE_CPU depends on your
> pmu/cleanup branch, but I found it does not.
> I verified this v3 patch can apply cleanly to soc branch on renesus.git
> and works fine.
>
> Simon-san, could you apply this v3 patch to soc branch after review ?
Sure, will do.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
2012-09-06 11:14 ` Tetsuyuki Kobayshi
@ 2012-09-11 8:10 ` Simon Horman
-1 siblings, 0 replies; 27+ messages in thread
From: Simon Horman @ 2012-09-11 8:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 08:14:05PM +0900, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Hello, Will
>
> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
>
> The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Thanks, I have pushed this to the pmu/cleanup branch of my renesas tree
and sent a pull-request to Will.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit)
@ 2012-09-11 8:10 ` Simon Horman
0 siblings, 0 replies; 27+ messages in thread
From: Simon Horman @ 2012-09-11 8:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 08:14:05PM +0900, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Hello, Will
>
> Could you apply this patch set to your pmu/cleanup branch on arm-soc?
>
> The follewing patches enables PMU(Performance Monitoring Unit) for sh73a0 and emev2 SoCs. I tested these patches on kzm9g board and kzm9d board.
Thanks, I have pushed this to the pmu/cleanup branch of my renesas tree
and sent a pull-request to Will.
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2012-09-11 8:10 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-05 2:48 [PATCH 0/2] ARM: shmobile: enable PMU(Performance Monitoring Unit) Tetsuyuki Kobayshi
2012-09-06 5:30 ` [PATCH v2 " Tetsuyuki Kobayshi
2012-09-06 5:30 ` Tetsuyuki Kobayshi
2012-09-06 5:30 ` [PATCH v2 1/2] ARM: shmobile: sh73a0: " Tetsuyuki Kobayshi
2012-09-06 5:30 ` Tetsuyuki Kobayshi
2012-09-06 9:11 ` Will Deacon
2012-09-06 9:11 ` Will Deacon
2012-09-06 9:57 ` Tetsuyuki Kobayashi
2012-09-06 9:57 ` Tetsuyuki Kobayashi
2012-09-06 11:14 ` [PATCH v3 0/2] ARM: shmobile: " Tetsuyuki Kobayshi
2012-09-06 11:14 ` Tetsuyuki Kobayshi
2012-09-06 11:14 ` [PATCH v3 1/2] ARM: shmobile: sh73a0: " Tetsuyuki Kobayshi
2012-09-06 11:14 ` Tetsuyuki Kobayshi
2012-09-06 11:14 ` [PATCH v3 2/2] ARM: shmobile: emev2: " Tetsuyuki Kobayshi
2012-09-06 11:14 ` Tetsuyuki Kobayshi
2012-09-06 11:21 ` [PATCH v3 0/2] ARM: shmobile: " Will Deacon
2012-09-06 11:21 ` Will Deacon
2012-09-07 1:50 ` Tetsuyuki Kobayashi
2012-09-07 1:50 ` Tetsuyuki Kobayashi
2012-09-07 8:46 ` Will Deacon
2012-09-07 8:46 ` Will Deacon
2012-09-07 13:25 ` Simon Horman
2012-09-07 13:25 ` Simon Horman
2012-09-11 8:10 ` Simon Horman
2012-09-11 8:10 ` Simon Horman
2012-09-06 5:30 ` [PATCH v2 2/2] ARM: shmobile: emev2: " Tetsuyuki Kobayshi
2012-09-06 5:30 ` Tetsuyuki Kobayshi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.