* [PATCH] hob/packageselectionpage: restore selected packages
@ 2012-09-10 12:49 Cristiana Voicu
2012-09-10 20:55 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Cristiana Voicu @ 2012-09-10 12:49 UTC (permalink / raw)
To: bitbake-devel
After "Cancel" action, selected packages are restored to default.
[YOCTO #2984]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
bitbake/lib/bb/ui/crumbs/builder.py | 2 +-
bitbake/lib/bb/ui/crumbs/packageselectionpage.py | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
index 833577f..18261c2 100755
--- a/bitbake/lib/bb/ui/crumbs/builder.py
+++ b/bitbake/lib/bb/ui/crumbs/builder.py
@@ -660,6 +660,7 @@ class Builder(gtk.Window):
self.recipe_details_page.set_recipe_curr_tab(self.recipe_details_page.INCLUDED)
elif next_step == self.PACKAGE_SELECTION:
+ self.configuration.initial_selected_packages = self.configuration.selected_packages
if self.recipe_model.get_selected_image() == self.recipe_model.__custom_image__:
self.package_details_page.set_packages_curr_tab(self.package_details_page.ALL)
else:
@@ -672,7 +673,6 @@ class Builder(gtk.Window):
self.build_details_page.show_page(next_step)
elif next_step == self.PACKAGE_GENERATED:
- self.configuration.initial_selected_packages = self.configuration.selected_packages
if self.recipe_model.get_selected_image() == self.recipe_model.__custom_image__:
self.package_details_page.set_packages_curr_tab(self.package_details_page.ALL)
else:
diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
index c73697b..e3d35ef 100755
--- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
@@ -187,12 +187,11 @@ class PackageSelectionPage (HobPage):
self.builder.build_image()
def back_button_clicked_cb(self, button):
- self.builder.restore_initial_selected_packages()
- self.refresh_selection()
-
if self.builder.current_step == self.builder.PACKAGE_GENERATED:
self.builder.show_recipes()
elif self.builder.previous_step == self.builder.IMAGE_GENERATED:
+ self.builder.restore_initial_selected_packages()
+ self.refresh_selection()
self.builder.show_image_details()
def _expand_all(self):
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hob/packageselectionpage: restore selected packages
2012-09-10 12:49 [PATCH] hob/packageselectionpage: restore selected packages Cristiana Voicu
@ 2012-09-10 20:55 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-09-10 20:55 UTC (permalink / raw)
To: Cristiana Voicu; +Cc: bitbake-devel
On Mon, 2012-09-10 at 15:49 +0300, Cristiana Voicu wrote:
> After "Cancel" action, selected packages are restored to default.
>
> [YOCTO #2984]
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
> bitbake/lib/bb/ui/crumbs/builder.py | 2 +-
> bitbake/lib/bb/ui/crumbs/packageselectionpage.py | 5 ++---
> 2 files changed, 3 insertions(+), 4 deletions(-)
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-10 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-10 12:49 [PATCH] hob/packageselectionpage: restore selected packages Cristiana Voicu
2012-09-10 20:55 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.