All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] s390/kvm: misc fixes
@ 2012-10-02 14:25 Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 1/3] s390/kvm: Interrupt injection bugfix Christian Borntraeger
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Christian Borntraeger @ 2012-10-02 14:25 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tossati
  Cc: Alexander Graf, Jens Freimann, Cornelia Huck, Heiko Carstens,
	Martin Schwidefsky, Heinz Graalfs, KVM, Christian Borntraeger


Avi, Marcelo,

here are some fixes for kvm on s390.
Would be good if we could add "s390/kvm: dont announce RRBM support" for
3.7 since the current kvm claims a feature that we currently dont support.

Everything else can be queued for the next merge window. Thanks


Christian Borntraeger (1):
  s390/kvm: dont announce RRBM support

Cornelia Huck (1):
  s390/kvm: Add documentation for KVM_S390_INTERRUPT.

Jason J. Herne (1):
  s390/kvm: Interrupt injection bugfix

 Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
 arch/s390/kvm/interrupt.c         | 19 ++++++++++++++++++-
 arch/s390/kvm/kvm-s390.c          |  2 +-
 3 files changed, 52 insertions(+), 2 deletions(-)

-- 
1.7.11.7


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] s390/kvm: Interrupt injection bugfix
  2012-10-02 14:25 [PATCH 0/3] s390/kvm: misc fixes Christian Borntraeger
@ 2012-10-02 14:25 ` Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 3/3] s390/kvm: dont announce RRBM support Christian Borntraeger
  2 siblings, 0 replies; 10+ messages in thread
From: Christian Borntraeger @ 2012-10-02 14:25 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tossati
  Cc: Alexander Graf, Jens Freimann, Cornelia Huck, Heiko Carstens,
	Martin Schwidefsky, Heinz Graalfs, KVM, Jason J. Herne,
	Christian Borntraeger

From: "Jason J. Herne" <jjherne@us.ibm.com>

EXTERNAL_CALL and EMERGENCY type interrupts need to preserve their interrupt
code parameter when being injected from user space.

Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 arch/s390/kvm/interrupt.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 7556231..744ac1b 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -631,10 +631,27 @@ int kvm_s390_inject_vcpu(struct kvm_vcpu *vcpu,
 		break;
 	case KVM_S390_SIGP_STOP:
 	case KVM_S390_RESTART:
+		VCPU_EVENT(vcpu, 3, "inject: type %x", s390int->type);
+		inti->type = s390int->type;
+		break;
 	case KVM_S390_INT_EXTERNAL_CALL:
+		if (s390int->parm & 0xffff0000) {
+			kfree(inti);
+			return -EINVAL;
+		}
+		VCPU_EVENT(vcpu, 3, "inject: external call source-cpu:%u",
+			   s390int->parm);
+		inti->type = s390int->type;
+		inti->extcall.code = s390int->parm;
+		break;
 	case KVM_S390_INT_EMERGENCY:
-		VCPU_EVENT(vcpu, 3, "inject: type %x", s390int->type);
+		if (s390int->parm & 0xffff0000) {
+			kfree(inti);
+			return -EINVAL;
+		}
+		VCPU_EVENT(vcpu, 3, "inject: emergency %u\n", s390int->parm);
 		inti->type = s390int->type;
+		inti->emerg.code = s390int->parm;
 		break;
 	case KVM_S390_INT_VIRTIO:
 	case KVM_S390_INT_SERVICE:
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-02 14:25 [PATCH 0/3] s390/kvm: misc fixes Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 1/3] s390/kvm: Interrupt injection bugfix Christian Borntraeger
@ 2012-10-02 14:25 ` Christian Borntraeger
  2012-10-10 16:27   ` Marcelo Tosatti
  2012-10-02 14:25 ` [PATCH 3/3] s390/kvm: dont announce RRBM support Christian Borntraeger
  2 siblings, 1 reply; 10+ messages in thread
From: Christian Borntraeger @ 2012-10-02 14:25 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tossati
  Cc: Alexander Graf, Jens Freimann, Cornelia Huck, Heiko Carstens,
	Martin Schwidefsky, Heinz Graalfs, KVM, Christian Borntraeger

From: Cornelia Huck <cornelia.huck@de.ibm.com>

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 36befa7..c533338 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
 the virtualized real-mode area (VRMA) facility, the kernel will
 re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
 
+4.77 KVM_S390_INTERRUPT
+
+Capability: basic
+Archtectures: s390
+Type: vm ioctl, vcpu ioctl
+Parameters: struct kvm_s390_interrupt (in)
+Returns: 0 on success, -1 on error
+
+Allows to inject an interrupt to the guest. Interrupts can be floating
+(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
+
+Interrupt parameters are passed via kvm_s390_interrupt:
+
+struct kvm_s390_interrupt {
+	__u32 type;
+	__u32 parm;
+	__u64 parm64;
+};
+
+type can be one of the following:
+
+KVM_S390_SIGP_STOP (vcpu) - sigp restart
+KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
+KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
+KVM_S390_RESTART (vcpu) - restart
+KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
+			   parameters in parm and parm64
+KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
+KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
+KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
+
+Note that the vcpu ioctl is asynchronous to vpcu execution.
+
 
 5. The kvm_run structure
 ------------------------
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 3/3] s390/kvm: dont announce RRBM support
  2012-10-02 14:25 [PATCH 0/3] s390/kvm: misc fixes Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 1/3] s390/kvm: Interrupt injection bugfix Christian Borntraeger
  2012-10-02 14:25 ` [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT Christian Borntraeger
@ 2012-10-02 14:25 ` Christian Borntraeger
  2 siblings, 0 replies; 10+ messages in thread
From: Christian Borntraeger @ 2012-10-02 14:25 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tossati
  Cc: Alexander Graf, Jens Freimann, Cornelia Huck, Heiko Carstens,
	Martin Schwidefsky, Heinz Graalfs, KVM, Christian Borntraeger,
	stable

Newer kernels (linux-next with the transparent huge page patches)
use rrbm if the feature is announced via feature bit 66.
RRBM will cause intercepts, so KVM does not handle it right now,
causing an illegal instruction in the guest.
The  easy solution is to disable the feature bit for the guest.

This fixes bugs like:
Kernel BUG at 0000000000124c2a [verbose debug info unavailable]
illegal operation: 0001 [#1] SMP
Modules linked in: virtio_balloon virtio_net ipv6 autofs4
CPU: 0 Not tainted 3.5.4 #1
Process fmempig (pid: 659, task: 000000007b712fd0, ksp: 000000007bed3670)
Krnl PSW : 0704d00180000000 0000000000124c2a (pmdp_clear_flush_young+0x5e/0x80)
     R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:1 PM:0 EA:3
     00000000003cc000 0000000000000004 0000000000000000 0000000079800000
     0000000000040000 0000000000000000 000000007bed3918 000000007cf40000
     0000000000000001 000003fff7f00000 000003d281a94000 000000007bed383c
     000000007bed3918 00000000005ecbf8 00000000002314a6 000000007bed36e0
 Krnl Code:>0000000000124c2a: b9810025          ogr     %r2,%r5
           0000000000124c2e: 41343000           la      %r3,0(%r4,%r3)
           0000000000124c32: a716fffa           brct    %r1,124c26
           0000000000124c36: b9010022           lngr    %r2,%r2
           0000000000124c3a: e3d0f0800004       lg      %r13,128(%r15)
           0000000000124c40: eb22003f000c       srlg    %r2,%r2,63
[ 2150.713198] Call Trace:
[ 2150.713223] ([<00000000002312c4>] page_referenced_one+0x6c/0x27c)
[ 2150.713749]  [<0000000000233812>] page_referenced+0x32a/0x410
[...]

CC: stable@vger.kernel.org
CC: Alex Graf <agraf@suse.de>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index ecced9d..38883f0 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -997,7 +997,7 @@ static int __init kvm_s390_init(void)
 	}
 	memcpy(facilities, S390_lowcore.stfle_fac_list, 16);
 	facilities[0] &= 0xff00fff3f47c0000ULL;
-	facilities[1] &= 0x201c000000000000ULL;
+	facilities[1] &= 0x001c000000000000ULL;
 	return 0;
 }
 
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-02 14:25 ` [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT Christian Borntraeger
@ 2012-10-10 16:27   ` Marcelo Tosatti
  2012-10-10 16:32     ` Alexander Graf
  2012-10-10 16:37     ` Cornelia Huck
  0 siblings, 2 replies; 10+ messages in thread
From: Marcelo Tosatti @ 2012-10-10 16:27 UTC (permalink / raw)
  To: Christian Borntraeger
  Cc: Avi Kivity, Alexander Graf, Jens Freimann, Cornelia Huck,
	Heiko Carstens, Martin Schwidefsky, Heinz Graalfs, KVM

On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 36befa7..c533338 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
>  the virtualized real-mode area (VRMA) facility, the kernel will
>  re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
>  
> +4.77 KVM_S390_INTERRUPT
> +
> +Capability: basic
> +Archtectures: s390

typo.

> +Type: vm ioctl, vcpu ioctl
> +Parameters: struct kvm_s390_interrupt (in)
> +Returns: 0 on success, -1 on error
> +
> +Allows to inject an interrupt to the guest. Interrupts can be floating
> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
> +
> +Interrupt parameters are passed via kvm_s390_interrupt:
> +
> +struct kvm_s390_interrupt {
> +	__u32 type;
> +	__u32 parm;
> +	__u64 parm64;
> +};

No need for a reserved area for extensibility?

> +
> +type can be one of the following:
> +
> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
> +KVM_S390_RESTART (vcpu) - restart
> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
> +			   parameters in parm and parm64
> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
> +
> +Note that the vcpu ioctl is asynchronous to vpcu execution.

typo



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-10 16:27   ` Marcelo Tosatti
@ 2012-10-10 16:32     ` Alexander Graf
  2012-10-10 16:38       ` Cornelia Huck
  2012-10-10 16:37     ` Cornelia Huck
  1 sibling, 1 reply; 10+ messages in thread
From: Alexander Graf @ 2012-10-10 16:32 UTC (permalink / raw)
  To: Marcelo Tosatti
  Cc: Christian Borntraeger, Avi Kivity, Jens Freimann, Cornelia Huck,
	Heiko Carstens, Martin Schwidefsky, Heinz Graalfs, KVM


On 10.10.2012, at 18:27, Marcelo Tosatti wrote:

> On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
>> From: Cornelia Huck <cornelia.huck@de.ibm.com>
>> 
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>> 
>> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
>> index 36befa7..c533338 100644
>> --- a/Documentation/virtual/kvm/api.txt
>> +++ b/Documentation/virtual/kvm/api.txt
>> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
>> the virtualized real-mode area (VRMA) facility, the kernel will
>> re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
>> 
>> +4.77 KVM_S390_INTERRUPT
>> +
>> +Capability: basic
>> +Archtectures: s390
> 
> typo.
> 
>> +Type: vm ioctl, vcpu ioctl
>> +Parameters: struct kvm_s390_interrupt (in)
>> +Returns: 0 on success, -1 on error
>> +
>> +Allows to inject an interrupt to the guest. Interrupts can be floating
>> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
>> +
>> +Interrupt parameters are passed via kvm_s390_interrupt:
>> +
>> +struct kvm_s390_interrupt {
>> +	__u32 type;
>> +	__u32 parm;
>> +	__u64 parm64;
>> +};
> 
> No need for a reserved area for extensibility?

This is documentation for an existing ioctl, no?
And yes, a reserved area would've been nice ;). But it's too late for that one now.


Alex

> 
>> +
>> +type can be one of the following:
>> +
>> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
>> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
>> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
>> +KVM_S390_RESTART (vcpu) - restart
>> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
>> +			   parameters in parm and parm64
>> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
>> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
>> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
>> +
>> +Note that the vcpu ioctl is asynchronous to vpcu execution.
> 
> typo
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-10 16:27   ` Marcelo Tosatti
  2012-10-10 16:32     ` Alexander Graf
@ 2012-10-10 16:37     ` Cornelia Huck
  2012-10-10 18:43       ` Marcelo Tosatti
  1 sibling, 1 reply; 10+ messages in thread
From: Cornelia Huck @ 2012-10-10 16:37 UTC (permalink / raw)
  To: Marcelo Tosatti
  Cc: Christian Borntraeger, Avi Kivity, Alexander Graf, Jens Freimann,
	Heiko Carstens, Martin Schwidefsky, Heinz Graalfs, KVM

On Wed, 10 Oct 2012 13:27:09 -0300
Marcelo Tosatti <mtosatti@redhat.com> wrote:

> > +Archtectures: s390
> 
> typo.

> > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> 
> typo
> 
> 

Would you like a respin with the typos fixed?


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-10 16:32     ` Alexander Graf
@ 2012-10-10 16:38       ` Cornelia Huck
  0 siblings, 0 replies; 10+ messages in thread
From: Cornelia Huck @ 2012-10-10 16:38 UTC (permalink / raw)
  To: Alexander Graf
  Cc: Marcelo Tosatti, Christian Borntraeger, Avi Kivity,
	Jens Freimann, Heiko Carstens, Martin Schwidefsky, Heinz Graalfs,
	KVM

On Wed, 10 Oct 2012 18:32:14 +0200
Alexander Graf <agraf@suse.de> wrote:

> 
> On 10.10.2012, at 18:27, Marcelo Tosatti wrote:
> 
> > On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
> >> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> 
> >> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >> ---
> >> Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
> >> 1 file changed, 33 insertions(+)
> >> 
> >> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> >> index 36befa7..c533338 100644
> >> --- a/Documentation/virtual/kvm/api.txt
> >> +++ b/Documentation/virtual/kvm/api.txt
> >> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
> >> the virtualized real-mode area (VRMA) facility, the kernel will
> >> re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
> >> 
> >> +4.77 KVM_S390_INTERRUPT
> >> +
> >> +Capability: basic
> >> +Archtectures: s390
> > 
> > typo.
> > 
> >> +Type: vm ioctl, vcpu ioctl
> >> +Parameters: struct kvm_s390_interrupt (in)
> >> +Returns: 0 on success, -1 on error
> >> +
> >> +Allows to inject an interrupt to the guest. Interrupts can be floating
> >> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
> >> +
> >> +Interrupt parameters are passed via kvm_s390_interrupt:
> >> +
> >> +struct kvm_s390_interrupt {
> >> +	__u32 type;
> >> +	__u32 parm;
> >> +	__u64 parm64;
> >> +};
> > 
> > No need for a reserved area for extensibility?
> 
> This is documentation for an existing ioctl, no?
> And yes, a reserved area would've been nice ;). But it's too late for that one now.

Indeed. We'll have to keep this for backward compatibility and introduce
a new mechanism for larger interrupt structures.

> 
> 
> Alex
> 
> > 
> >> +
> >> +type can be one of the following:
> >> +
> >> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
> >> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
> >> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
> >> +KVM_S390_RESTART (vcpu) - restart
> >> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
> >> +			   parameters in parm and parm64
> >> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
> >> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
> >> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
> >> +
> >> +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > 
> > typo
> > 
> > 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-10 16:37     ` Cornelia Huck
@ 2012-10-10 18:43       ` Marcelo Tosatti
  2012-10-10 18:57         ` Marcelo Tosatti
  0 siblings, 1 reply; 10+ messages in thread
From: Marcelo Tosatti @ 2012-10-10 18:43 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Christian Borntraeger, Avi Kivity, Alexander Graf, Jens Freimann,
	Heiko Carstens, Martin Schwidefsky, Heinz Graalfs, KVM

On Wed, Oct 10, 2012 at 06:37:57PM +0200, Cornelia Huck wrote:
> On Wed, 10 Oct 2012 13:27:09 -0300
> Marcelo Tosatti <mtosatti@redhat.com> wrote:
> 
> > > +Archtectures: s390
> > 
> > typo.
> 
> > > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > 
> > typo
> > 
> > 
> 
> Would you like a respin with the typos fixed?

No.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.
  2012-10-10 18:43       ` Marcelo Tosatti
@ 2012-10-10 18:57         ` Marcelo Tosatti
  0 siblings, 0 replies; 10+ messages in thread
From: Marcelo Tosatti @ 2012-10-10 18:57 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Christian Borntraeger, Avi Kivity, Alexander Graf, Jens Freimann,
	Heiko Carstens, Martin Schwidefsky, Heinz Graalfs, KVM

On Wed, Oct 10, 2012 at 03:43:10PM -0300, Marcelo Tosatti wrote:
> On Wed, Oct 10, 2012 at 06:37:57PM +0200, Cornelia Huck wrote:
> > On Wed, 10 Oct 2012 13:27:09 -0300
> > Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > 
> > > > +Archtectures: s390
> > > 
> > > typo.
> > 
> > > > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > > 
> > > typo
> > > 
> > > 
> > 
> > Would you like a respin with the typos fixed?
> 
> No.

Applied, thanks.


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-10-10 18:58 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-02 14:25 [PATCH 0/3] s390/kvm: misc fixes Christian Borntraeger
2012-10-02 14:25 ` [PATCH 1/3] s390/kvm: Interrupt injection bugfix Christian Borntraeger
2012-10-02 14:25 ` [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT Christian Borntraeger
2012-10-10 16:27   ` Marcelo Tosatti
2012-10-10 16:32     ` Alexander Graf
2012-10-10 16:38       ` Cornelia Huck
2012-10-10 16:37     ` Cornelia Huck
2012-10-10 18:43       ` Marcelo Tosatti
2012-10-10 18:57         ` Marcelo Tosatti
2012-10-02 14:25 ` [PATCH 3/3] s390/kvm: dont announce RRBM support Christian Borntraeger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.