* [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix
@ 2012-10-04 17:49 Damien Lespiau
2012-10-04 17:49 ` [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell Damien Lespiau
2012-10-04 17:58 ` [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Paulo Zanoni
0 siblings, 2 replies; 6+ messages in thread
From: Damien Lespiau @ 2012-10-04 17:49 UTC (permalink / raw)
To: intel-gfx
From: Damien Lespiau <damien.lespiau@intel.com>
For the next person that checks these kind of things, without having to
dig up the register definition.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 62fe848..3d219ec 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3541,6 +3541,7 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
I915_WRITE(_3D_CHICKEN3,
_MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
+ /* WaDisableBackToBackFlipFix */
I915_WRITE(IVB_CHICKEN3,
CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
CHICKEN3_DGMG_DONE_FIX_DISABLE);
@@ -3621,6 +3622,7 @@ static void valleyview_init_clock_gating(struct drm_device *dev)
I915_WRITE(_3D_CHICKEN3,
_MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
+ /* WaDisableBackToBackFlipFix */
I915_WRITE(IVB_CHICKEN3,
CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
CHICKEN3_DGMG_DONE_FIX_DISABLE);
--
1.7.7.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell
2012-10-04 17:49 [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Damien Lespiau
@ 2012-10-04 17:49 ` Damien Lespiau
2012-10-04 18:02 ` Paulo Zanoni
2012-10-04 17:58 ` [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Paulo Zanoni
1 sibling, 1 reply; 6+ messages in thread
From: Damien Lespiau @ 2012-10-04 17:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
From: Damien Lespiau <damien.lespiau@intel.com>
This workaround is only valid for IVB and VLV and the write triggers an
error on HSW.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3d219ec..d0403e8 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3479,10 +3479,6 @@ static void haswell_init_clock_gating(struct drm_device *dev)
I915_WRITE(_3D_CHICKEN3,
_MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
- I915_WRITE(IVB_CHICKEN3,
- CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
- CHICKEN3_DGMG_DONE_FIX_DISABLE);
-
/* Apply the WaDisableRHWOOptimizationForRenderHang workaround. */
I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1,
GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC);
--
1.7.7.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix
2012-10-04 17:49 [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Damien Lespiau
2012-10-04 17:49 ` [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell Damien Lespiau
@ 2012-10-04 17:58 ` Paulo Zanoni
2012-10-08 16:44 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Paulo Zanoni @ 2012-10-04 17:58 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
2012/10/4 Damien Lespiau <damien.lespiau@gmail.com>:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> For the next person that checks these kind of things, without having to
> dig up the register definition.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 62fe848..3d219ec 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3541,6 +3541,7 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
> I915_WRITE(_3D_CHICKEN3,
> _MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
>
> + /* WaDisableBackToBackFlipFix */
> I915_WRITE(IVB_CHICKEN3,
> CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
> CHICKEN3_DGMG_DONE_FIX_DISABLE);
> @@ -3621,6 +3622,7 @@ static void valleyview_init_clock_gating(struct drm_device *dev)
> I915_WRITE(_3D_CHICKEN3,
> _MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
>
> + /* WaDisableBackToBackFlipFix */
> I915_WRITE(IVB_CHICKEN3,
> CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
> CHICKEN3_DGMG_DONE_FIX_DISABLE);
> --
> 1.7.7.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Paulo Zanoni
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell
2012-10-04 17:49 ` [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell Damien Lespiau
@ 2012-10-04 18:02 ` Paulo Zanoni
2012-10-05 13:28 ` Lespiau, Damien
0 siblings, 1 reply; 6+ messages in thread
From: Paulo Zanoni @ 2012-10-04 18:02 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx, Paulo Zanoni
2012/10/4 Damien Lespiau <damien.lespiau@gmail.com>:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> This workaround is only valid for IVB and VLV and the write triggers an
> error on HSW.
In other words: the register does not exist anymore.
It would be nice if we could volunteer someone to check the other
workarounds on the same function. The registers may exist but the WAs
may not be needed anymore.
Reviewed-by: Paulo Zanoni <paulo.r.zanonI@intel.com>
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 3d219ec..d0403e8 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3479,10 +3479,6 @@ static void haswell_init_clock_gating(struct drm_device *dev)
> I915_WRITE(_3D_CHICKEN3,
> _MASKED_BIT_ENABLE(_3D_CHICKEN_SF_DISABLE_OBJEND_CULL));
>
> - I915_WRITE(IVB_CHICKEN3,
> - CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
> - CHICKEN3_DGMG_DONE_FIX_DISABLE);
> -
> /* Apply the WaDisableRHWOOptimizationForRenderHang workaround. */
> I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1,
> GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC);
> --
> 1.7.7.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Paulo Zanoni
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell
2012-10-04 18:02 ` Paulo Zanoni
@ 2012-10-05 13:28 ` Lespiau, Damien
0 siblings, 0 replies; 6+ messages in thread
From: Lespiau, Damien @ 2012-10-05 13:28 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: Damien Lespiau, intel-gfx, Paulo Zanoni
On Thu, Oct 4, 2012 at 7:02 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> It would be nice if we could volunteer someone to check the other
> workarounds on the same function. The registers may exist but the WAs
> may not be needed anymore.
I've done a pass this morning and with the new patch posted list, I
think we're good.
--
Damien
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix
2012-10-04 17:58 ` [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Paulo Zanoni
@ 2012-10-08 16:44 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2012-10-08 16:44 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: Damien Lespiau, intel-gfx
On Thu, Oct 04, 2012 at 02:58:04PM -0300, Paulo Zanoni wrote:
> 2012/10/4 Damien Lespiau <damien.lespiau@gmail.com>:
> > From: Damien Lespiau <damien.lespiau@intel.com>
> >
> > For the next person that checks these kind of things, without having to
> > dig up the register definition.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Both patches merged into dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-08 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-04 17:49 [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Damien Lespiau
2012-10-04 17:49 ` [PATCH 2/2] drm/i915: Remove the WaDisableBackToBackFlipFix w/a for Haswell Damien Lespiau
2012-10-04 18:02 ` Paulo Zanoni
2012-10-05 13:28 ` Lespiau, Damien
2012-10-04 17:58 ` [PATCH 1/2] drm/i915: Document that we are implementing WaDisableBackToBackFlipFix Paulo Zanoni
2012-10-08 16:44 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.