[Qemu-devel] [PATCH] versatilepb: Use symbolic indices for ARM PIC

[Qemu-devel] [PATCH] versatilepb: Use symbolic indices for ARM PIC

[Stefan Weil]

It is more readable, and all other code does it like that, too.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/versatilepb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 7a92034..b3f8077 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -211,7 +211,8 @@ static void versatile_init(ram_addr_t ram_size,
 
     cpu_pic = arm_pic_init_cpu(cpu);
     dev = sysbus_create_varargs("pl190", 0x10140000,
-                                cpu_pic[0], cpu_pic[1], NULL);
+                                cpu_pic[ARM_PIC_CPU_IRQ],
+                                cpu_pic[ARM_PIC_CPU_FIQ], NULL);
     for (n = 0; n < 32; n++) {
         pic[n] = qdev_get_gpio_in(dev, n);
     }
-- 
1.7.10

Re: [Qemu-devel] [PATCH] versatilepb: Use symbolic indices for ARM PIC

[Peter Maydell]

On 4 October 2012 21:49, Stefan Weil <sw@weilnetz.de> wrote:
> It is more readable, and all other code does it like that, too.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

The right long term fix is named pins.

-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] versatilepb: Use symbolic indices for ARM PIC

[Stefan Hajnoczi]

On Thu, Oct 04, 2012 at 10:49:43PM +0200, Stefan Weil wrote:
> It is more readable, and all other code does it like that, too.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/versatilepb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan