All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: winbond: wbusb: Fixed coding style issue
@ 2012-10-09 16:10 Adil Mujeeb
  2012-10-09 16:22 ` Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Adil Mujeeb @ 2012-10-09 16:10 UTC (permalink / raw)
  To: pavel; +Cc: gregkh, devel, linux-kernel, Adil Mujeeb

Repalces printk's with pr_debug

Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com>
---
 linux-3.6-rc7/drivers/staging/winbond/wbusb.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
index 0ca857a..48fe622 100644
--- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
+++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
@@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
 static void wbsoft_remove_interface(struct ieee80211_hw *dev,
 				    struct ieee80211_vif *vif)
 {
-	printk("wbsoft_remove interface called\n");
+	pr_debug("wbsoft_remove interface called\n");
 }
 
 static void wbsoft_stop(struct ieee80211_hw *hw)
 {
-	printk(KERN_INFO "%s called\n", __func__);
+	pr_debug("%s called\n", __func__);
 }
 
 static int wbsoft_get_stats(struct ieee80211_hw *hw,
 			    struct ieee80211_low_level_stats *stats)
 {
-	printk(KERN_INFO "%s called\n", __func__);
+	pr_debug("%s called\n", __func__);
 	return 0;
 }
 
@@ -177,7 +177,7 @@ static void hal_set_current_channel_ex(struct hw_data *pHwData, struct chan_info
 	if (pHwData->SurpriseRemove)
 		return;
 
-	printk("Going to channel: %d/%d\n", channel.band, channel.ChanNo);
+	pr_debug("Going to channel: %d/%d\n", channel.band, channel.ChanNo);
 
 	RFSynthesizer_SwitchingChannel(pHwData, channel); /* Switch channel */
 	pHwData->Channel = channel.ChanNo;
@@ -262,7 +262,7 @@ static int wbsoft_config(struct ieee80211_hw *dev, u32 changed)
 	struct wbsoft_priv *priv = dev->priv;
 	struct chan_info ch;
 
-	printk("wbsoft_config called\n");
+	pr_debug("wbsoft_config called\n");
 
 	/* Should use channel_num, or something, as that is already pre-translated */
 	ch.band = 1;
@@ -280,7 +280,7 @@ static int wbsoft_config(struct ieee80211_hw *dev, u32 changed)
 
 static u64 wbsoft_get_tsf(struct ieee80211_hw *dev, struct ieee80211_vif *vif)
 {
-	printk("wbsoft_get_tsf called\n");
+	pr_debug("wbsoft_get_tsf called\n");
 	return 0;
 }
 
@@ -781,7 +781,7 @@ static int wb35_probe(struct usb_interface *intf,
 	endpoint = &interface->endpoint[0].desc;
 
 	if (endpoint[2].wMaxPacketSize == 512)
-		printk("[w35und] Working on USB 2.0\n");
+		pr_debug("[w35und] Working on USB 2.0\n");
 
 	err = wb35_hw_init(dev);
 	if (err)
-- 
1.7.7.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue
  2012-10-09 16:10 [PATCH] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
@ 2012-10-09 16:22 ` Joe Perches
  2012-10-09 16:46   ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2012-10-09 16:22 UTC (permalink / raw)
  To: Adil Mujeeb; +Cc: pavel, gregkh, devel, linux-kernel

On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> Repalces printk's with pr_debug
[]
> diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> index 0ca857a..48fe622 100644
> --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
>  static void wbsoft_remove_interface(struct ieee80211_hw *dev,
>  				    struct ieee80211_vif *vif)
>  {
> -	printk("wbsoft_remove interface called\n");
> +	pr_debug("wbsoft_remove interface called\n");

It'd be more consistent to use
	pr_debug("%s called\n", __func__);
everywhere.

It might be even nicer to remove almost all of these.



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue
  2012-10-09 16:22 ` Joe Perches
@ 2012-10-09 16:46   ` Greg KH
  2012-10-09 18:02     ` Adil Mujeeb
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-10-09 16:46 UTC (permalink / raw)
  To: Joe Perches; +Cc: Adil Mujeeb, pavel, devel, linux-kernel

On Tue, Oct 09, 2012 at 09:22:18AM -0700, Joe Perches wrote:
> On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> > Repalces printk's with pr_debug
> []
> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > index 0ca857a..48fe622 100644
> > --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
> >  static void wbsoft_remove_interface(struct ieee80211_hw *dev,
> >  				    struct ieee80211_vif *vif)
> >  {
> > -	printk("wbsoft_remove interface called\n");
> > +	pr_debug("wbsoft_remove interface called\n");
> 
> It'd be more consistent to use
> 	pr_debug("%s called\n", __func__);
> everywhere.
> 
> It might be even nicer to remove almost all of these.
> 

Yes, "tracing" type debug calls like this should all be removed, now
that we have built-in function call tracing in the core kernel itself.

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue
  2012-10-09 16:46   ` Greg KH
@ 2012-10-09 18:02     ` Adil Mujeeb
  0 siblings, 0 replies; 6+ messages in thread
From: Adil Mujeeb @ 2012-10-09 18:02 UTC (permalink / raw)
  To: Greg KH; +Cc: Joe Perches, pavel, devel, linux-kernel

On Tue, Oct 9, 2012 at 10:16 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Oct 09, 2012 at 09:22:18AM -0700, Joe Perches wrote:
>> On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
>> > Repalces printk's with pr_debug
>> []
>> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
>> > index 0ca857a..48fe622 100644
>> > --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
>> > +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
>> > @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
>> >  static void wbsoft_remove_interface(struct ieee80211_hw *dev,
>> >                                 struct ieee80211_vif *vif)
>> >  {
>> > -   printk("wbsoft_remove interface called\n");
>> > +   pr_debug("wbsoft_remove interface called\n");
>>
>> It'd be more consistent to use
>>       pr_debug("%s called\n", __func__);
>> everywhere.
>>
>> It might be even nicer to remove almost all of these.
>>
>
> Yes, "tracing" type debug calls like this should all be removed, now
> that we have built-in function call tracing in the core kernel itself.

Thanks Joe and Greg for your quick comments. I will remove such
tracing calls and resubmit the patch.

Regards,
Adil

>
> greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue
  2012-10-10 10:35 Adil Mujeeb
@ 2012-10-10 10:53 ` Pavel Machek
  0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2012-10-10 10:53 UTC (permalink / raw)
  To: Adil Mujeeb; +Cc: gregkh, devel, linux-kernel

On Wed 2012-10-10 16:05:29, Adil Mujeeb wrote:
> Removed unnecessary printk and pr_debug tracing calls
> 
> Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com>

ACK.
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Staging: winbond: wbusb: Fixed coding style issue
@ 2012-10-10 10:35 Adil Mujeeb
  2012-10-10 10:53 ` Pavel Machek
  0 siblings, 1 reply; 6+ messages in thread
From: Adil Mujeeb @ 2012-10-10 10:35 UTC (permalink / raw)
  To: pavel; +Cc: gregkh, devel, linux-kernel, Adil Mujeeb

Removed unnecessary printk and pr_debug tracing calls

Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com>
---
 linux-3.6-rc7/drivers/staging/winbond/wbusb.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
index 0ca857a..a0497ea 100644
--- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
+++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
@@ -79,18 +79,15 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
 static void wbsoft_remove_interface(struct ieee80211_hw *dev,
 				    struct ieee80211_vif *vif)
 {
-	printk("wbsoft_remove interface called\n");
 }
 
 static void wbsoft_stop(struct ieee80211_hw *hw)
 {
-	printk(KERN_INFO "%s called\n", __func__);
 }
 
 static int wbsoft_get_stats(struct ieee80211_hw *hw,
 			    struct ieee80211_low_level_stats *stats)
 {
-	printk(KERN_INFO "%s called\n", __func__);
 	return 0;
 }
 
@@ -177,12 +174,9 @@ static void hal_set_current_channel_ex(struct hw_data *pHwData, struct chan_info
 	if (pHwData->SurpriseRemove)
 		return;
 
-	printk("Going to channel: %d/%d\n", channel.band, channel.ChanNo);
-
 	RFSynthesizer_SwitchingChannel(pHwData, channel); /* Switch channel */
 	pHwData->Channel = channel.ChanNo;
 	pHwData->band = channel.band;
-	pr_debug("Set channel is %d, band =%d\n", pHwData->Channel, pHwData->band);
 	reg->M28_MacControl &= ~0xff;	/* Clean channel information field */
 	reg->M28_MacControl |= channel.ChanNo;
 	Wb35Reg_WriteWithCallbackValue(pHwData, 0x0828, reg->M28_MacControl,
@@ -262,8 +256,6 @@ static int wbsoft_config(struct ieee80211_hw *dev, u32 changed)
 	struct wbsoft_priv *priv = dev->priv;
 	struct chan_info ch;
 
-	printk("wbsoft_config called\n");
-
 	/* Should use channel_num, or something, as that is already pre-translated */
 	ch.band = 1;
 	ch.ChanNo = 1;
@@ -280,7 +272,6 @@ static int wbsoft_config(struct ieee80211_hw *dev, u32 changed)
 
 static u64 wbsoft_get_tsf(struct ieee80211_hw *dev, struct ieee80211_vif *vif)
 {
-	printk("wbsoft_get_tsf called\n");
 	return 0;
 }
 
@@ -714,7 +705,6 @@ static int wb35_hw_init(struct ieee80211_hw *hw)
 	}
 
 	priv->sLocalPara.bAntennaNo = hal_get_antenna_number(pHwData);
-	pr_debug("Driver init, antenna no = %d\n", priv->sLocalPara.bAntennaNo);
 	hal_get_hw_radio_off(pHwData);
 
 	/* Waiting for HAL setting OK */
@@ -780,9 +770,6 @@ static int wb35_probe(struct usb_interface *intf,
 	interface = intf->cur_altsetting;
 	endpoint = &interface->endpoint[0].desc;
 
-	if (endpoint[2].wMaxPacketSize == 512)
-		printk("[w35und] Working on USB 2.0\n");
-
 	err = wb35_hw_init(dev);
 	if (err)
 		goto error_free_hw;
@@ -834,7 +821,6 @@ static void wb35_hw_halt(struct wbsoft_priv *adapter)
 {
 	/* Turn off Rx and Tx hardware ability */
 	hal_stop(&adapter->sHwData);
-	pr_debug("[w35und] Hal_stop O.K.\n");
 	/* Waiting Irp completed */
 	msleep(100);
 
-- 
1.7.7.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-10 10:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 16:10 [PATCH] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-09 16:22 ` Joe Perches
2012-10-09 16:46   ` Greg KH
2012-10-09 18:02     ` Adil Mujeeb
2012-10-10 10:35 Adil Mujeeb
2012-10-10 10:53 ` Pavel Machek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.