All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remove obsolete TODO from grub-install
@ 2012-10-09 17:23 Andrey Borzenkov
  2012-12-10 16:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Borzenkov @ 2012-10-09 17:23 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

It does use efibootmgr, so TODO is misleading.



[-- Attachment #2: grub-install-does-use-efibootmgr.patch --]
[-- Type: text/x-patch, Size: 385 bytes --]

=== modified file 'util/grub-install.in'
--- util/grub-install.in	2012-09-24 17:50:35 +0000
+++ util/grub-install.in	2012-10-09 17:15:52 +0000
@@ -486,8 +486,6 @@
 		*)
 		    efi_file=grub.efi ;;
 	    esac
-	   # TODO: We should also use efibootmgr, if available, to add a Boot
-	   # entry for ourselves.
 	fi
 	efidir="$efidir/EFI/$efi_distributor"
 	mkdir -p "$efidir" || exit 1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remove obsolete TODO from grub-install
  2012-10-09 17:23 [PATCH] remove obsolete TODO from grub-install Andrey Borzenkov
@ 2012-12-10 16:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-12-10 16:00 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On 09.10.2012 19:23, Andrey Borzenkov wrote:

> 
> === modified file 'util/grub-install.in'
> --- util/grub-install.in	2012-09-24 17:50:35 +0000
> +++ util/grub-install.in	2012-10-09 17:15:52 +0000
> @@ -486,8 +486,6 @@
>  		*)
>  		    efi_file=grub.efi ;;
>  	    esac
> -	   # TODO: We should also use efibootmgr, if available, to add a Boot
> -	   # entry for ourselves.
>  	fi
>  	efidir="$efidir/EFI/$efi_distributor"
>  	mkdir -p "$efidir" || exit 1
> 
> 
> 

Applied, thanks.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-10 16:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 17:23 [PATCH] remove obsolete TODO from grub-install Andrey Borzenkov
2012-12-10 16:00 ` Vladimir 'φ-coder/phcoder' Serbinenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.