All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers
Date: Mon, 15 Oct 2012 16:39:41 -0400	[thread overview]
Message-ID: <1350333581.19292.10.camel@pippen.local.home> (raw)
In-Reply-To: <CAFTL4hzLtYZsc_JCVCGW2gWbxp5APgq8P7F-D+76kVOyrTKvRA@mail.gmail.com>

On Mon, 2012-10-15 at 22:23 +0200, Frederic Weisbecker wrote:
> 2012/10/15 Steven Rostedt <rostedt@goodmis.org>:
> > On Mon, 2012-10-15 at 17:11 +0100, Catalin Marinas wrote:
> >> On 12 October 2012 19:09, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >> > diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h
> >> > new file mode 100644
> >> > index 0000000..f1bffa2
> >> > --- /dev/null
> >> > +++ b/arch/arm/include/asm/irq_work.h
> >> > @@ -0,0 +1 @@
> >> > +#include <asm-generic/irq_work.h>
> >> > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
> >> > new file mode 100644
> >> > index 0000000..f1bffa2
> >> > --- /dev/null
> >> > +++ b/arch/arm64/include/asm/irq_work.h
> >> > @@ -0,0 +1 @@
> >> > +#include <asm-generic/irq_work.h>
> >>
> >> Just add generic-y += irq_work.h to arch/*/include/asm/Kbuild to avoid
> >> creating new files.
> >>
> >
> > BTW, is there any rational reason that the include path lookup doesn't
> > just check for the files in include/asm-generic after looking in
> > arch/*/include/asm?
> >
> > Really, the best way would be just to add the default asm files into
> > include/asm-generic and be done with it. I hate the fact that we need to
> > touch every arch for every generic default file.
> 
> Agreed. I'm including Arnd in the conversation.

As David Howells is doing user space header work, I'll include him too.
Maybe someone can shed some light onto this.

-- Steve

> 
> >
> > I'd be willing to take a look at fixing this too, when I get a chance.
> >
> > -- Steve
> >
> >



  reply	other threads:[~2012-10-15 20:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 18:09 [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers Frederic Weisbecker
2012-10-15 16:11   ` Catalin Marinas
2012-10-15 20:02     ` Steven Rostedt
2012-10-15 20:23       ` Frederic Weisbecker
2012-10-15 20:39         ` Steven Rostedt [this message]
2012-10-15 21:34           ` Arnd Bergmann
2012-10-15 22:18             ` Frederic Weisbecker
2012-10-16  3:12               ` Mark Brown
2012-10-16  9:25                 ` Arnd Bergmann
2012-10-16 15:40                   ` Mark Brown
2012-10-12 18:09 ` [RFC PATCH 2/5] irq_work: Only run irq_work from tick if arch needs it Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 3/5] x86: Implement arch_irq_work_use_tick Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 4/5] nohz: Add API to check tick state Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 5/5] printk: Wake up klogd with irq_work on nohz CPU Frederic Weisbecker
2012-10-19 15:50 ` [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350333581.19292.10.camel@pippen.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.