All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers
Date: Tue, 16 Oct 2012 16:40:09 +0100	[thread overview]
Message-ID: <20121016154009.GA2260@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201210160925.11891.arnd@arndb.de>

On Tue, Oct 16, 2012 at 09:25:11AM +0000, Arnd Bergmann wrote:
> On Tuesday 16 October 2012, Mark Brown wrote:

> > That'd work, but I assume there is some reason why we've got this system
> > of explicitly adding each file.  It's not like cpp can test for the
> > presence of include files.  If we can't figure out why we're not doing
> > this I'd propose we start.

> We discussed renaming asm-generic to asm before, but some people objected
> to the use of #include_next. There is a smaller problem with opening the
> asm/*.h namespace to header files that are not relevant for architctures,
> so I'd prefer to have a well-defined list of headers that are implicitly
> shared, but it's not a technical argument.

Perhaps what we need here is a more elegantly named
asm-default-implementation which is for the headers which almost every
architecture should be using (like clk and gpio) since the APIs should
be at least stubbed in order to avoid making the architecture terminally
annoying.

Alternatively we go to the gpiolib approach where I just made
architectures that want to do fun stuff select a Kconfig symbol and
otherwise the default is directly in the linux/ header.  This was
massively easier to deploy all round.

The case where the current situation is really annoying is the case
where we want to allow some sort of performance optimisation in
something that's normally there and probably doesn't need it; right now
the cost is on the API users to convince every single architecture
maintainer to adopt the API.

  reply	other threads:[~2012-10-16 15:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 18:09 [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers Frederic Weisbecker
2012-10-15 16:11   ` Catalin Marinas
2012-10-15 20:02     ` Steven Rostedt
2012-10-15 20:23       ` Frederic Weisbecker
2012-10-15 20:39         ` Steven Rostedt
2012-10-15 21:34           ` Arnd Bergmann
2012-10-15 22:18             ` Frederic Weisbecker
2012-10-16  3:12               ` Mark Brown
2012-10-16  9:25                 ` Arnd Bergmann
2012-10-16 15:40                   ` Mark Brown [this message]
2012-10-12 18:09 ` [RFC PATCH 2/5] irq_work: Only run irq_work from tick if arch needs it Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 3/5] x86: Implement arch_irq_work_use_tick Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 4/5] nohz: Add API to check tick state Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 5/5] printk: Wake up klogd with irq_work on nohz CPU Frederic Weisbecker
2012-10-19 15:50 ` [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016154009.GA2260@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.