All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 21/24] pmic: Extend PMIC framework to support battery related commands
Date: Fri, 19 Oct 2012 17:44:08 +0200	[thread overview]
Message-ID: <1350661451-1273-22-git-send-email-l.majewski@samsung.com> (raw)
In-Reply-To: <1350661451-1273-1-git-send-email-l.majewski@samsung.com>

Two extra commands:
"pmic name bat state" and "pmic name bat charge" has been added to
pmic framework. Those provides state display and charge capabilities
to named batteries.

The pmic_core.c file has been refactored to more consistent name scheme.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Stefano Babic <sbabic@denx.de>
---
Changes for v2:
- New patch to v2.
Changes for v3:
- change code according to struct pmic redesign
---
 drivers/power/pmic_core.c |   51 ++++++++++++++++++++++++++++++++++++--------
 1 files changed, 41 insertions(+), 10 deletions(-)

diff --git a/drivers/power/pmic_core.c b/drivers/power/pmic_core.c
index 2908f66..01a240f 100644
--- a/drivers/power/pmic_core.c
+++ b/drivers/power/pmic_core.c
@@ -124,35 +124,46 @@ struct pmic *pmic_get(const char *s)
 	return NULL;
 }
 
+const char *power_get_interface(int interface)
+{
+	const char *power_interface[] = {"I2C", "SPI", "|+|-|"};
+	return power_interface[interface];
+}
+
 static void pmic_list_names(void)
 {
 	struct pmic *p;
 
 	puts("PMIC devices:\n");
 	list_for_each_entry(p, &pmic_list, list) {
-		printf("name: %s\n", p->name);
+		printf("name: %s bus: %s_%d\n", p->name,
+		       power_get_interface(p->interface), p->bus);
 	}
 }
 
 int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	u32 ret, reg, val;
+	char *cmd, *name;
 	struct pmic *p;
-	char *cmd;
 
 	/* at least two arguments please */
 	if (argc < 2)
 		return CMD_RET_USAGE;
 
-	cmd = argv[1];
-
-	if (strcmp(cmd, "list") == 0) {
+	if (strcmp(argv[1], "list") == 0) {
 		pmic_list_names();
 		return CMD_RET_SUCCESS;
 	}
 
+	name = argv[1];
+	cmd = argv[2];
+
+	debug("%s: name: %s cmd: %s\n", __func__, name, cmd);
+	p = pmic_get(name);
+
 	if (strcmp(cmd, "dump") == 0) {
-		if (pmic_dump(pmic_get(argv[2])))
+		if (pmic_dump(p))
 			return CMD_RET_FAILURE;
 		return CMD_RET_SUCCESS;
 	}
@@ -162,7 +173,6 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			return CMD_RET_USAGE;
 
 		reg = simple_strtoul(argv[3], NULL, 16);
-		p = pmic_get(argv[2]);
 		ret = pmic_reg_read(p, reg, &val);
 
 		if (ret)
@@ -179,12 +189,31 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 		reg = simple_strtoul(argv[3], NULL, 16);
 		val = simple_strtoul(argv[4], NULL, 16);
-		p = pmic_get(argv[2]);
 		pmic_reg_write(p, reg, val);
 
 		return CMD_RET_SUCCESS;
 	}
 
+	if (strcmp(cmd, "bat") == 0) {
+		if (argc < 4)
+			return CMD_RET_USAGE;
+
+		if (strcmp(argv[3], "state") == 0)
+			p->fg->fg_battery_check(p->pbat->fg, p);
+
+		if (strcmp(argv[3], "charge") == 0) {
+			if (p->pbat) {
+				printf("PRINT BAT charge %s\n", p->name);
+				if (p->low_power_mode)
+					p->low_power_mode();
+				if (p->pbat->battery_charge)
+					p->pbat->battery_charge(p);
+			}
+		}
+
+		return CMD_RET_SUCCESS;
+	}
+
 	/* No subcommand found */
 	return CMD_RET_SUCCESS;
 }
@@ -193,7 +222,9 @@ U_BOOT_CMD(
 	pmic,	CONFIG_SYS_MAXARGS, 1, do_pmic,
 	"PMIC",
 	"list - list available PMICs\n"
-	"pmic dump name - dump named PMIC registers\n"
+	"pmic name dump - dump named PMIC registers\n"
 	"pmic name read <reg> - read register\n"
-	"pmic name write <reg> <value> - write register"
+	"pmic name write <reg> <value> - write register\n"
+	"pmic name bat state - write register\n"
+	"pmic name bat charge - write register\n"
 );
-- 
1.7.2.3

  parent reply	other threads:[~2012-10-19 15:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 15:43 [U-Boot] [PATCH v3 00/24] pmic: Redesign PMIC framework to support multiple instances of devices Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 01/24] pmic:i2c: Handle PMIC I2C transmission comprising of two bytes Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 02/24] pmic:i2c: Add I2C sensor byte order (big/little) to PMIC framework Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 03/24] pmic:max8997: Switch the MAX8997 PMIC to be used with multibus I2C Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 04/24] pmic: Extend PMIC framework to support multiple instances of PMIC devices Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 05/24] pmic: Introduce power_init_board() method at ./lib/board.c file Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 06/24] pmic: Enable power_board_init() support at TRATS Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 07/24] pmic:chrg: Common information about charger and battery (power_chrg.h) Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 08/24] pmic: Move pmic related code to ./drivers/power directory Lukasz Majewski
2012-10-26 21:25   ` Tom Rini
2012-10-27 21:01     ` Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 09/24] pmic: Extend struct pmic to support battery and charger related operations Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 10/24] pmic:battery: Support for Trats Battery at PMIC framework Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 11/24] pmic:muic: Support for MUIC built into MAX8997 device Lukasz Majewski
2012-10-19 15:43 ` [U-Boot] [PATCH v3 12/24] pmic:fuel-gauge: Support for MAX17042 fuel-gauge Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 13/24] pmic:max8997: Function for calculating LDO internal register value Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 14/24] arm:trats:pmic: Default PMIC(MAX8997) initialization for Samsung's TRATS board Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 15/24] arm:trats:pmic: Enable MUIC (MAX8997) at " Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 16/24] arm:trats:pmic: Enable fuel-gauge (MAX17042) " Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 17/24] arm:trats:pmic: Enable battery support " Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 18/24] pmic:max8997: Support for MAX8997 internal charger control Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 19/24] arm:trats:pmic: Power consumption reduction state for Samsung's TRATS board Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 20/24] arm:trats:pmic: Support for charging battery at " Lukasz Majewski
2012-10-19 15:44 ` Lukasz Majewski [this message]
2012-10-19 15:44 ` [U-Boot] [PATCH v3 22/24] power:pmic: Rename ./drivers/power/pmic_* to ./drivers/power/power_* files Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 23/24] power:pmic: Rename CONFIG_PMIC* defines to CONFIG_POWER Lukasz Majewski
2012-10-19 15:44 ` [U-Boot] [PATCH v3 24/24] power:pmic: Rename CONFIG_DIALOG_PMIC defines to CONFIG_DIALOG_POWER Lukasz Majewski
2012-10-26  7:29 ` [U-Boot] [PATCH v3 00/24] pmic: Redesign PMIC framework to support multiple instances of devices Lukasz Majewski
2012-10-26 10:34   ` Stefano Babic
2012-10-26 10:43     ` Lukasz Majewski
2012-10-26 17:32       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350661451-1273-22-git-send-email-l.majewski@samsung.com \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.