All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Venkatraman S <svenkatr@ti.com>,
	khilman@ti.com, linux-omap@vger.kernel.org,
	linux-mmc@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	Chris Ball <cjb@laptop.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: OMAP baseline test results for v3.7-rc1
Date: Mon, 22 Oct 2012 19:13:55 +0300	[thread overview]
Message-ID: <1350922435.2143.66.camel@sokoban> (raw)
In-Reply-To: <alpine.DEB.2.00.1210201628420.24497@utopia.booyaka.com>

On Sat, 2012-10-20 at 17:20 +0000, Paul Walmsley wrote:
> Hello Venkatraman,
> 
> On Thu, 18 Oct 2012, Paul Walmsley wrote:
> 
> > Here are some basic OMAP test results for Linux v3.7-rc1.
> > Logs and other details at http://www.pwsan.com/omap/testlogs/test_v3.7-rc1/
> 
> ...
> 
> > Failing tests: needing investigation
> > ------------------------------------
> 
> ...
> 
> > PM tests:
> > 
> > * 3530es3beagle: hangs during off-mode dynamic idle test
> >   - Unknown cause; not investigated
> 
> Looks like this commit is causing some of our power management tests to 
> fail on v3.7-rc1:
> 
> commit 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c
> Author: Venkatraman S <svenkatr@ti.com>
> Date:   Wed Aug 8 14:26:52 2012 +0530
> 
>     mmc: omap_hsmmc: remove access to SYSCONFIG register
> 
> ...
> 
> The failure can be seen in the following test log:
> 
> http://www.pwsan.com/omap/transcripts/20121020-3530es3beagle-off-mode-fail-pre-revert.txt
> 
> and with commit 6c31b215 reverted, the test succeeds:
> 
> http://www.pwsan.com/omap/transcripts/20121020-3530es3beagle-off-mode-fail-post-revert.txt
> 
> 
> Could you please take a look and fix the problem?

Root cause for this issue is that the MMC IP is reset during off-mode,
but the driver doesn't expect this in its current form. There are a
couple of alternative ways to fix this. Either add a reset timeout to
the MMC driver code (which was removed by the bisected patch), or
alternatively add a global reset check to the hwmod code. I'll send a
patch for the global reset purpose in a bit for commenting.

-Tero



WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP baseline test results for v3.7-rc1
Date: Mon, 22 Oct 2012 19:13:55 +0300	[thread overview]
Message-ID: <1350922435.2143.66.camel@sokoban> (raw)
In-Reply-To: <alpine.DEB.2.00.1210201628420.24497@utopia.booyaka.com>

On Sat, 2012-10-20 at 17:20 +0000, Paul Walmsley wrote:
> Hello Venkatraman,
> 
> On Thu, 18 Oct 2012, Paul Walmsley wrote:
> 
> > Here are some basic OMAP test results for Linux v3.7-rc1.
> > Logs and other details at http://www.pwsan.com/omap/testlogs/test_v3.7-rc1/
> 
> ...
> 
> > Failing tests: needing investigation
> > ------------------------------------
> 
> ...
> 
> > PM tests:
> > 
> > * 3530es3beagle: hangs during off-mode dynamic idle test
> >   - Unknown cause; not investigated
> 
> Looks like this commit is causing some of our power management tests to 
> fail on v3.7-rc1:
> 
> commit 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c
> Author: Venkatraman S <svenkatr@ti.com>
> Date:   Wed Aug 8 14:26:52 2012 +0530
> 
>     mmc: omap_hsmmc: remove access to SYSCONFIG register
> 
> ...
> 
> The failure can be seen in the following test log:
> 
> http://www.pwsan.com/omap/transcripts/20121020-3530es3beagle-off-mode-fail-pre-revert.txt
> 
> and with commit 6c31b215 reverted, the test succeeds:
> 
> http://www.pwsan.com/omap/transcripts/20121020-3530es3beagle-off-mode-fail-post-revert.txt
> 
> 
> Could you please take a look and fix the problem?

Root cause for this issue is that the MMC IP is reset during off-mode,
but the driver doesn't expect this in its current form. There are a
couple of alternative ways to fix this. Either add a reset timeout to
the MMC driver code (which was removed by the bisected patch), or
alternatively add a global reset check to the hwmod code. I'll send a
patch for the global reset purpose in a bit for commenting.

-Tero

  reply	other threads:[~2012-10-22 16:14 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  5:20 OMAP baseline test results for v3.7-rc1 Paul Walmsley
2012-10-18  5:20 ` Paul Walmsley
2012-10-18  6:48 ` Paul Walmsley
2012-10-18  6:48   ` Paul Walmsley
2012-10-18  8:37   ` Tero Kristo
2012-10-18  8:37     ` Tero Kristo
2012-10-18  8:48     ` Santosh Shilimkar
2012-10-18  8:48       ` Santosh Shilimkar
2012-10-20 17:30       ` Paul Walmsley
2012-10-20 17:30         ` Paul Walmsley
2012-10-19 16:55 ` Paul Walmsley
2012-10-19 16:55   ` Paul Walmsley
2012-10-19 17:01   ` Felipe Balbi
2012-10-19 17:01     ` Felipe Balbi
2012-10-19 17:56     ` Paul Walmsley
2012-10-19 17:56       ` Paul Walmsley
2012-10-19 18:10       ` Felipe Balbi
2012-10-19 18:10         ` Felipe Balbi
2012-10-19 19:03   ` Aaro Koskinen
2012-10-19 19:03     ` Aaro Koskinen
2012-10-19 19:01     ` Felipe Balbi
2012-10-19 19:01       ` Felipe Balbi
2012-10-19 19:38       ` Aaro Koskinen
2012-10-19 19:38         ` Aaro Koskinen
2012-10-22 17:21         ` Kevin Hilman
2012-10-22 17:21           ` Kevin Hilman
2012-10-22 20:43           ` Kevin Hilman
2012-10-22 20:43             ` Kevin Hilman
2012-10-20  6:14   ` Paul Walmsley
2012-10-20  6:14     ` Paul Walmsley
2012-10-22 16:12     ` Jean Pihet
2012-10-22 16:12       ` Jean Pihet
2012-10-22 17:26       ` Jean Pihet
2012-10-22 17:26         ` Jean Pihet
2012-10-23 19:19         ` Paul Walmsley
2012-10-23 19:19           ` Paul Walmsley
2012-10-23 19:23           ` Jean Pihet
2012-10-23 19:23             ` Jean Pihet
2012-10-25 10:12             ` Felipe Balbi
2012-10-25 10:12               ` Felipe Balbi
2012-10-26 20:15               ` Felipe Balbi
2012-10-26 20:15                 ` Felipe Balbi
2012-10-26 22:03                 ` Paul Walmsley
2012-10-26 22:03                   ` Paul Walmsley
2012-10-29 20:00                   ` Felipe Balbi
2012-10-29 20:00                     ` Felipe Balbi
2012-10-30 12:17                     ` Paul Walmsley
2012-10-30 12:17                       ` Paul Walmsley
2012-10-30 12:32                       ` Felipe Balbi
2012-10-30 12:32                         ` Felipe Balbi
2012-10-30 12:50                         ` Paul Walmsley
2012-10-30 12:50                           ` Paul Walmsley
2012-10-30 12:54                           ` Felipe Balbi
2012-10-30 12:54                             ` Felipe Balbi
2012-10-30 13:17                             ` Paul Walmsley
2012-10-30 13:17                               ` Paul Walmsley
2012-10-30 14:04                               ` Paul Walmsley
2012-10-30 14:04                                 ` Paul Walmsley
2012-10-31  8:34                                 ` Jean Pihet
2012-10-31  8:34                                   ` Jean Pihet
2012-10-31  9:05                                   ` Rafael J. Wysocki
2012-10-31  9:05                                     ` Rafael J. Wysocki
2012-10-31  8:22                               ` Jean Pihet
2012-10-31  8:22                                 ` Jean Pihet
2012-10-31 10:49                                 ` Kevin Hilman
2012-10-31 10:49                                   ` Kevin Hilman
2012-10-31 21:11                                   ` Jean Pihet
2012-10-31 21:11                                     ` Jean Pihet
2012-11-01  2:44                                     ` Paul Walmsley
2012-11-01  2:44                                       ` Paul Walmsley
2012-11-01  7:51                                       ` Jean Pihet
2012-11-01  7:51                                         ` Jean Pihet
2012-11-03 21:39                                         ` Jean Pihet
2012-11-03 21:39                                           ` Jean Pihet
2012-11-05  3:15                                           ` Paul Walmsley
2012-11-05  3:15                                             ` Paul Walmsley
2012-11-05  9:26                                             ` Jean Pihet
2012-11-05  9:26                                               ` Jean Pihet
2012-11-06  0:01                                               ` Kevin Hilman
2012-11-06  0:01                                                 ` Kevin Hilman
2012-11-06  9:27                                                 ` Jean Pihet
2012-11-06  9:27                                                   ` Jean Pihet
2012-11-06 16:13                                                   ` Paul Walmsley
2012-11-06 16:13                                                     ` Paul Walmsley
2012-11-06 10:06                                                 ` Shubhrajyoti Datta
2012-11-06 10:06                                                   ` Shubhrajyoti Datta
2012-10-30  4:16             ` Paul Walmsley
2012-10-30  4:16               ` Paul Walmsley
2012-10-30  8:54               ` Jean Pihet
2012-10-30  8:54                 ` Jean Pihet
2012-10-30 11:23                 ` Paul Walmsley
2012-10-30 11:23                   ` Paul Walmsley
2012-10-31  8:18                   ` Jean Pihet
2012-10-31  8:18                     ` Jean Pihet
2012-10-23 19:17       ` Kevin Hilman
2012-10-23 19:17         ` Kevin Hilman
2012-10-23 19:18       ` Paul Walmsley
2012-10-23 19:18         ` Paul Walmsley
2012-10-20  6:24   ` Paul Walmsley
2012-10-20  6:24     ` Paul Walmsley
2012-10-22 17:53     ` Kevin Hilman
2012-10-22 17:53       ` Kevin Hilman
2012-10-22 20:44       ` Kevin Hilman
2012-10-22 20:44         ` Kevin Hilman
2012-10-20 14:11 ` Richard Cochran
2012-10-20 14:11   ` Richard Cochran
2012-10-20 16:27   ` Paul Walmsley
2012-10-20 16:27     ` Paul Walmsley
2012-10-20 18:01     ` Richard Cochran
2012-10-20 18:01       ` Richard Cochran
2012-10-20 18:12       ` Paul Walmsley
2012-10-20 18:12         ` Paul Walmsley
2012-10-20 18:37         ` Richard Cochran
2012-10-20 18:37           ` Richard Cochran
2012-10-20 18:58           ` Paul Walmsley
2012-10-20 18:58             ` Paul Walmsley
2012-10-21 13:51             ` Matt Porter
2012-10-21 13:51               ` Matt Porter
2012-10-21 16:26               ` Paul Walmsley
2012-10-21 16:26                 ` Paul Walmsley
2012-10-22 21:56               ` Kevin Hilman
2012-10-22 21:56                 ` Kevin Hilman
2012-10-21  7:35     ` Richard Cochran
2012-10-21  7:35       ` Richard Cochran
2012-10-21  8:23       ` Paul Walmsley
2012-10-21  8:23         ` Paul Walmsley
2012-10-21 11:44         ` Richard Cochran
2012-10-21 11:44           ` Richard Cochran
2012-10-21 16:24           ` Paul Walmsley
2012-10-21 16:24             ` Paul Walmsley
2012-10-21 12:29       ` Mohammed, Afzal
2012-10-21 12:29         ` Mohammed, Afzal
2012-10-21 12:36         ` Richard Cochran
2012-10-21 12:36           ` Richard Cochran
2012-10-20 17:20 ` Paul Walmsley
2012-10-20 17:20   ` Paul Walmsley
2012-10-22 16:13   ` Tero Kristo [this message]
2012-10-22 16:13     ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350922435.2143.66.camel@sokoban \
    --to=t-kristo@ti.com \
    --cc=balbi@ti.com \
    --cc=cjb@laptop.org \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=svenkatr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.