From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> To: "David S. Miller" <davem@davemloft.net>, Lennert Buytenhek <kernel@wantstofly.org> Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@free-electrons.com>, Lior Amsalem <alior@marvell.com>, Maen Suleiman <maen@marvell.com> Subject: [PATCH v3] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Date: Tue, 23 Oct 2012 18:54:56 +0200 [thread overview] Message-ID: <1351011300-26964-1-git-send-email-thomas.petazzoni@free-electrons.com> (raw) David, Lennert, This patch set adds a new network driver for the network unit available in the newest Marvell ARM SoCs Armada 370 and Armada XP, as well as the necessary Device Tree information to use this driver in the two evaluation platforms of those SoCs. In details: * Patch 1 contains the driver itself. The commit log contains a detailed explanation about why a new driver is needed for this new Marvell SoC, compared to older Marvell SoCs (Orion, Kirkwood, Dove) that use the mv643xx_eth driver. * Patch 2 adds the necessary entry to the MAINTAINERS file. * Patch 3 adds the SoC-level Device Tree information for Armada 370 and Armada XP. * Patch 4 adds the board-level Device Tree information for the Marvell evaluation boards of Armada 370 and Armada XP. Changes since v2: * Change compatible string from 'marvell,neta' to 'marvell,armada-370-neta'. Requested by Rob Herring. * Rename Ethernet DT nodes from eth@... to ethernet@... Requested by Rob Herring. * Remove device_type DT property. Requested by Rob Herring. * Change the PHY interface for eth0/eth1 to be rgmii-id, which allows to enable TX/RX delay mechanisms at the PHY level. This fixes CRC errors on received packets during iperf tests (it was a bug in v2). * Remove the mvneta_ prefix from module parameters. Requested by Baruch Siach. * Many code style improvements suggested by François Romieu. * Properly stop/restart the TX queue when the number of TX descriptors available becomes low, instead of returning NETDEV_TX_BUSY. Requested by François Romieu. * Properly drop packets on the TX path when DMA mapping functions return an error, instead of returning NETDEV_TX_BUSY. Requested by François Romieu. * Rebased on top of Linux 3.7-rc2. Changes since v1: * Reduced the Cc: list in order to make the patch set acceptable for the netdev@ mailing list. * Merge the mvneta.h contents into mvneta.c, since the header was only used by the driver. Requested by Arnd Bergmann. * Completely reorganize the organization of the register list and register values, in order to make it more consistent, and hopefully easier to read (especially easier to match register values with the corresponding register). * Integrate with the phylib, as suggested by Florian Fainelli, and remove the link management code that has become useless as the result of this integration * Fix many small details suggested by Florian Fainelli in his review of the first driver * Simplify various parts of the driver (descriptors array allocation, data structures, etc.) Thanks, Thomas Petazzoni
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Date: Tue, 23 Oct 2012 18:54:56 +0200 [thread overview] Message-ID: <1351011300-26964-1-git-send-email-thomas.petazzoni@free-electrons.com> (raw) David, Lennert, This patch set adds a new network driver for the network unit available in the newest Marvell ARM SoCs Armada 370 and Armada XP, as well as the necessary Device Tree information to use this driver in the two evaluation platforms of those SoCs. In details: * Patch 1 contains the driver itself. The commit log contains a detailed explanation about why a new driver is needed for this new Marvell SoC, compared to older Marvell SoCs (Orion, Kirkwood, Dove) that use the mv643xx_eth driver. * Patch 2 adds the necessary entry to the MAINTAINERS file. * Patch 3 adds the SoC-level Device Tree information for Armada 370 and Armada XP. * Patch 4 adds the board-level Device Tree information for the Marvell evaluation boards of Armada 370 and Armada XP. Changes since v2: * Change compatible string from 'marvell,neta' to 'marvell,armada-370-neta'. Requested by Rob Herring. * Rename Ethernet DT nodes from eth at ... to ethernet at ... Requested by Rob Herring. * Remove device_type DT property. Requested by Rob Herring. * Change the PHY interface for eth0/eth1 to be rgmii-id, which allows to enable TX/RX delay mechanisms at the PHY level. This fixes CRC errors on received packets during iperf tests (it was a bug in v2). * Remove the mvneta_ prefix from module parameters. Requested by Baruch Siach. * Many code style improvements suggested by Fran?ois Romieu. * Properly stop/restart the TX queue when the number of TX descriptors available becomes low, instead of returning NETDEV_TX_BUSY. Requested by Fran?ois Romieu. * Properly drop packets on the TX path when DMA mapping functions return an error, instead of returning NETDEV_TX_BUSY. Requested by Fran?ois Romieu. * Rebased on top of Linux 3.7-rc2. Changes since v1: * Reduced the Cc: list in order to make the patch set acceptable for the netdev@ mailing list. * Merge the mvneta.h contents into mvneta.c, since the header was only used by the driver. Requested by Arnd Bergmann. * Completely reorganize the organization of the register list and register values, in order to make it more consistent, and hopefully easier to read (especially easier to match register values with the corresponding register). * Integrate with the phylib, as suggested by Florian Fainelli, and remove the link management code that has become useless as the result of this integration * Fix many small details suggested by Florian Fainelli in his review of the first driver * Simplify various parts of the driver (descriptors array allocation, data structures, etc.) Thanks, Thomas Petazzoni
next reply other threads:[~2012-10-23 16:55 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-23 16:54 Thomas Petazzoni [this message] 2012-10-23 16:54 ` [PATCH v3] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni 2012-10-23 16:54 ` [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni 2012-10-23 16:54 ` Thomas Petazzoni 2012-10-25 3:06 ` David Miller 2012-10-25 3:06 ` David Miller 2012-10-25 6:21 ` Thomas Petazzoni 2012-10-25 6:21 ` Thomas Petazzoni 2012-10-23 16:54 ` [PATCH 2/4] net: mvneta: update MAINTAINERS file for the mvneta maintainers Thomas Petazzoni 2012-10-23 16:54 ` Thomas Petazzoni 2012-10-23 16:54 ` [PATCH 3/4] arm: mvebu: add Ethernet controllers using mvneta driver for Armada 370/XP Thomas Petazzoni 2012-10-23 16:54 ` Thomas Petazzoni 2012-10-23 16:55 ` [PATCH 4/4] arm: mvebu: enable Ethernet controllers on Armada 370/XP eval boards Thomas Petazzoni 2012-10-23 16:55 ` Thomas Petazzoni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1351011300-26964-1-git-send-email-thomas.petazzoni@free-electrons.com \ --to=thomas.petazzoni@free-electrons.com \ --cc=alior@marvell.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=kernel@wantstofly.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maen@marvell.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.