[PATCH] systemd: prevent duplicate logging messages in journal

[PATCH] systemd: prevent duplicate logging messages in journal

[Marti Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

By default, both stderr and syslog messages go to the systemd journal,
which results in duplicate messages being logged.

Thanks to Vinicius Costa Gomes for pointing out this problem.
---
 dundee/dundee.service.in | 1 +
 src/ofono.service.in     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/dundee/dundee.service.in b/dundee/dundee.service.in
index c57c618..82c5ef1 100644
--- a/dundee/dundee.service.in
+++ b/dundee/dundee.service.in
@@ -6,6 +6,7 @@ After=syslog.target
 Type=dbus
 BusName=org.ofono.dundee
 ExecStart=@prefix@/sbin/dundee -n
+StandardError=null
 
 [Install]
 WantedBy=multi-user.target
diff --git a/src/ofono.service.in b/src/ofono.service.in
index f4531a8..c24ac28 100644
--- a/src/ofono.service.in
+++ b/src/ofono.service.in
@@ -6,6 +6,7 @@ After=syslog.target
 Type=dbus
 BusName=org.ofono
 ExecStart=@prefix@/sbin/ofonod -n
+StandardError=null
 
 [Install]
 WantedBy=multi-user.target
-- 
1.8.0

Re: [PATCH] systemd: prevent duplicate logging messages in journal

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi Marti,

> By default, both stderr and syslog messages go to the systemd journal,
> which results in duplicate messages being logged.
> 
> Thanks to Vinicius Costa Gomes for pointing out this problem.
> ---
>  dundee/dundee.service.in | 1 +
>  src/ofono.service.in     | 1 +
>  2 files changed, 2 insertions(+)

patch has been applied.

Regards

Marcel

[PATCH] systemd: prevent duplicate logging messages in journal

[Marti Raudsepp]

By default, both stdout and syslog messages go to the systemd journal,
which results in duplicate messages being logged.
---
 src/bluetooth.service.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bluetooth.service.in b/src/bluetooth.service.in
index 2a576a3..a8442a9 100644
--- a/src/bluetooth.service.in
+++ b/src/bluetooth.service.in
@@ -5,6 +5,7 @@ Description=Bluetooth service
 Type=dbus
 BusName=org.bluez
 ExecStart=@prefix@/sbin/bluetoothd -n
+StandardOutput=null
 
 [Install]
 WantedBy=bluetooth.target
-- 
1.7.12.2

Re: [PATCH] systemd: prevent duplicate logging messages in journal

[Vinicius Costa Gomes]

Hi Marti,

On 18:59 Wed 10 Oct, Marti Raudsepp wrote:
> By default, both stdout and syslog messages go to the systemd journal,
> which results in duplicate messages being logged.
> ---

Patch looks good.

Ack.

On a side note: seems that connman and ofono have the same problem, would you
be interested on sending the respective fixes?

>  src/bluetooth.service.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/bluetooth.service.in b/src/bluetooth.service.in
> index 2a576a3..a8442a9 100644
> --- a/src/bluetooth.service.in
> +++ b/src/bluetooth.service.in
> @@ -5,6 +5,7 @@ Description=Bluetooth service
>  Type=dbus
>  BusName=org.bluez
>  ExecStart=@prefix@/sbin/bluetoothd -n
> +StandardOutput=null
>  
>  [Install]
>  WantedBy=bluetooth.target
> -- 
> 1.7.12.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers,
-- 
Vinicius

Re: [PATCH] systemd: prevent duplicate logging messages in journal

[Marcel Holtmann]

Hi Marti,

> By default, both stdout and syslog messages go to the systemd journal,
> which results in duplicate messages being logged.
> ---
>  src/bluetooth.service.in | 1 +
>  1 file changed, 1 insertion(+)

patch has been applied.

Regards

Marcel