All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][8.0] nvfx: handle some unknown PIPE_CAPs
@ 2012-10-30 17:03 Andreas Boll
  2012-10-30 17:33 ` Lucas Stach
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Boll @ 2012-10-30 17:03 UTC (permalink / raw)
  To: mesa-dev; +Cc: nouveau

fixes these warnings:

nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 30
nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 55
nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 56
nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 58
nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 59

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47442
Bugzilla: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674965
Signed-off-by: Andreas Boll <andreas.boll.dev@gmail.com>
---

Note: This patch is only for the 8.0 branch.
Compile tested only.

 src/gallium/drivers/nvfx/nvfx_screen.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/gallium/drivers/nvfx/nvfx_screen.c b/src/gallium/drivers/nvfx/nvfx_screen.c
index b4a1b3a..26c2d8d 100644
--- a/src/gallium/drivers/nvfx/nvfx_screen.c
+++ b/src/gallium/drivers/nvfx/nvfx_screen.c
@@ -88,6 +88,12 @@ nvfx_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
 	case PIPE_CAP_MAX_TEXEL_OFFSET:
 	case PIPE_CAP_CONDITIONAL_RENDER:
 	case PIPE_CAP_TEXTURE_BARRIER:
+	case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
+	case PIPE_CAP_MAX_STREAM_OUTPUT_SEPARATE_COMPONENTS:
+	case PIPE_CAP_MAX_STREAM_OUTPUT_INTERLEAVED_COMPONENTS:
+	case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
+	case PIPE_CAP_TGSI_CAN_COMPACT_VARYINGS:
+	case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
                 return 0;
 	case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
                 return 0;
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH][8.0] nvfx: handle some unknown PIPE_CAPs
  2012-10-30 17:03 [PATCH][8.0] nvfx: handle some unknown PIPE_CAPs Andreas Boll
@ 2012-10-30 17:33 ` Lucas Stach
  2012-10-30 17:49   ` Andreas Boll
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2012-10-30 17:33 UTC (permalink / raw)
  To: Andreas Boll; +Cc: mesa-dev, nouveau

Am Dienstag, den 30.10.2012, 18:03 +0100 schrieb Andreas Boll:
> fixes these warnings:
> 
> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 30
> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 55
> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 56
> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 58
> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 59
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47442
> Bugzilla: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674965
> Signed-off-by: Andreas Boll <andreas.boll.dev@gmail.com>

While this doesn't really fix anything:
Reviewed-by: Lucas Stach <dev@lynxeye.de>
> ---
> 
> Note: This patch is only for the 8.0 branch.
> Compile tested only.
> 
>  src/gallium/drivers/nvfx/nvfx_screen.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/src/gallium/drivers/nvfx/nvfx_screen.c b/src/gallium/drivers/nvfx/nvfx_screen.c
> index b4a1b3a..26c2d8d 100644
> --- a/src/gallium/drivers/nvfx/nvfx_screen.c
> +++ b/src/gallium/drivers/nvfx/nvfx_screen.c
> @@ -88,6 +88,12 @@ nvfx_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>  	case PIPE_CAP_MAX_TEXEL_OFFSET:
>  	case PIPE_CAP_CONDITIONAL_RENDER:
>  	case PIPE_CAP_TEXTURE_BARRIER:
> +	case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
> +	case PIPE_CAP_MAX_STREAM_OUTPUT_SEPARATE_COMPONENTS:
> +	case PIPE_CAP_MAX_STREAM_OUTPUT_INTERLEAVED_COMPONENTS:
> +	case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
> +	case PIPE_CAP_TGSI_CAN_COMPACT_VARYINGS:
> +	case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
>                  return 0;
>  	case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>                  return 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][8.0] nvfx: handle some unknown PIPE_CAPs
  2012-10-30 17:33 ` Lucas Stach
@ 2012-10-30 17:49   ` Andreas Boll
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Boll @ 2012-10-30 17:49 UTC (permalink / raw)
  To: Lucas Stach; +Cc: mesa-dev, nouveau

2012/10/30 Lucas Stach <dev@lynxeye.de>:
> Am Dienstag, den 30.10.2012, 18:03 +0100 schrieb Andreas Boll:
>> fixes these warnings:
>>
>> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 30
>> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 55
>> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 56
>> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 58
>> nvfx_screen_get_param:95 - Warning: unknown PIPE_CAP 59
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47442
>> Bugzilla: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674965
>> Signed-off-by: Andreas Boll <andreas.boll.dev@gmail.com>
>
> While this doesn't really fix anything:
> Reviewed-by: Lucas Stach <dev@lynxeye.de>

Yeah I know, but it's pretty annoying for users who don't know it and
it's easy to fix.

>> ---
>>
>> Note: This patch is only for the 8.0 branch.
>> Compile tested only.
>>
>>  src/gallium/drivers/nvfx/nvfx_screen.c |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/gallium/drivers/nvfx/nvfx_screen.c b/src/gallium/drivers/nvfx/nvfx_screen.c
>> index b4a1b3a..26c2d8d 100644
>> --- a/src/gallium/drivers/nvfx/nvfx_screen.c
>> +++ b/src/gallium/drivers/nvfx/nvfx_screen.c
>> @@ -88,6 +88,12 @@ nvfx_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>       case PIPE_CAP_MAX_TEXEL_OFFSET:
>>       case PIPE_CAP_CONDITIONAL_RENDER:
>>       case PIPE_CAP_TEXTURE_BARRIER:
>> +     case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
>> +     case PIPE_CAP_MAX_STREAM_OUTPUT_SEPARATE_COMPONENTS:
>> +     case PIPE_CAP_MAX_STREAM_OUTPUT_INTERLEAVED_COMPONENTS:
>> +     case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
>> +     case PIPE_CAP_TGSI_CAN_COMPACT_VARYINGS:
>> +     case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
>>                  return 0;
>>       case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>>                  return 0;
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-30 17:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-30 17:03 [PATCH][8.0] nvfx: handle some unknown PIPE_CAPs Andreas Boll
2012-10-30 17:33 ` Lucas Stach
2012-10-30 17:49   ` Andreas Boll

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.