From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: linux-kernel@vger.kernel.org, sjenning@linux.vnet.ibm.com, dan.magenheimer@oracle.com, ngupta@vflare.org, minchan@kernel.org, rcj@linux.vnet.ibm.com, linux-mm@kvack.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org Cc: akpm@linux-foundation.org Subject: [RFC PATCH] zcache2 cleanups (s/int/bool + debugfs movement). Date: Mon, 5 Nov 2012 09:37:23 -0500 [thread overview] Message-ID: <1352126254-28933-1-git-send-email-konrad.wilk@oracle.com> (raw) Looking at the zcache2 code there were a couple of things that I thought would make sense to move out of the code. For one thing it makes it easier to read, and for anoter - it can be cleanly compiled out. It also allows to have a clean seperation of counters that we _need_ vs the optional ones. Which means that in the future we could get rid of the optional ones. This patchset is based on the patchset that Dan sent out (https://lkml.org/lkml/2012/10/31/790). I've stuck them (and addressed some review comments) and put them in my branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/mm.git devel/zcache.v3 I am going to repost the module loading some time later this week - Bob Liu had some comments that I want to address. So back to this patchset - it fixes some outstanding compile warnings, cleans up some of the code, and rips out the debug counters out of zcache-main.c and sticks them in a debug.c file. I was hoping it would end up with less code, but sadly it ended up with a bit more due to the empty non-debug functions. drivers/staging/ramster/Kconfig | 8 + drivers/staging/ramster/Makefile | 1 + drivers/staging/ramster/debug.c | 66 ++++++ drivers/staging/ramster/debug.h | 225 +++++++++++++++++++ drivers/staging/ramster/zcache-main.c | 384 ++++++++------------------------- 5 files changed, 389 insertions(+), 295 deletions(-) Konrad Rzeszutek Wilk (11): zcache2: s/int/bool/ on the various options. zcache: Module license is defined twice. zcache: Provide accessory functions for counter increase zcache: Provide accessory functions for counter decrease. zcache: The last of the atomic reads has now an accessory function. zcache: Fix compile warnings due to usage of debugfs_create_size_t zcache: Make the debug code use pr_debug zcache: Move debugfs code out of zcache-main.c file. zcache: Use an array to initialize/use debugfs attributes. zcache: Move the last of the debugfs counters out zcache: Coalesce all debug under CONFIG_ZCACHE2_DEBUG
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: linux-kernel@vger.kernel.org, sjenning@linux.vnet.ibm.com, dan.magenheimer@oracle.com, ngupta@vflare.org, minchan@kernel.org, rcj@linux.vnet.ibm.com, linux-mm@kvack.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org Cc: akpm@linux-foundation.org Subject: [RFC PATCH] zcache2 cleanups (s/int/bool + debugfs movement). Date: Mon, 5 Nov 2012 09:37:23 -0500 [thread overview] Message-ID: <1352126254-28933-1-git-send-email-konrad.wilk@oracle.com> (raw) Looking at the zcache2 code there were a couple of things that I thought would make sense to move out of the code. For one thing it makes it easier to read, and for anoter - it can be cleanly compiled out. It also allows to have a clean seperation of counters that we _need_ vs the optional ones. Which means that in the future we could get rid of the optional ones. This patchset is based on the patchset that Dan sent out (https://lkml.org/lkml/2012/10/31/790). I've stuck them (and addressed some review comments) and put them in my branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/mm.git devel/zcache.v3 I am going to repost the module loading some time later this week - Bob Liu had some comments that I want to address. So back to this patchset - it fixes some outstanding compile warnings, cleans up some of the code, and rips out the debug counters out of zcache-main.c and sticks them in a debug.c file. I was hoping it would end up with less code, but sadly it ended up with a bit more due to the empty non-debug functions. drivers/staging/ramster/Kconfig | 8 + drivers/staging/ramster/Makefile | 1 + drivers/staging/ramster/debug.c | 66 ++++++ drivers/staging/ramster/debug.h | 225 +++++++++++++++++++ drivers/staging/ramster/zcache-main.c | 384 ++++++++------------------------- 5 files changed, 389 insertions(+), 295 deletions(-) Konrad Rzeszutek Wilk (11): zcache2: s/int/bool/ on the various options. zcache: Module license is defined twice. zcache: Provide accessory functions for counter increase zcache: Provide accessory functions for counter decrease. zcache: The last of the atomic reads has now an accessory function. zcache: Fix compile warnings due to usage of debugfs_create_size_t zcache: Make the debug code use pr_debug zcache: Move debugfs code out of zcache-main.c file. zcache: Use an array to initialize/use debugfs attributes. zcache: Move the last of the debugfs counters out zcache: Coalesce all debug under CONFIG_ZCACHE2_DEBUG -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-11-05 14:56 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-05 14:37 Konrad Rzeszutek Wilk [this message] 2012-11-05 14:37 ` [RFC PATCH] zcache2 cleanups (s/int/bool + debugfs movement) Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 01/11] zcache2: s/int/bool/ on the various options Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 02/11] zcache: Module license is defined twice Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 03/11] zcache: Provide accessory functions for counter increase Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 04/11] zcache: Provide accessory functions for counter decrease Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 05/11] zcache: The last of the atomic reads has now an accessory function Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 06/11] zcache: Fix compile warnings due to usage of debugfs_create_size_t Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 07/11] zcache: Make the debug code use pr_debug Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 08/11] zcache: Move debugfs code out of zcache-main.c file Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 09/11] zcache: Use an array to initialize/use debugfs attributes Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 10/11] zcache: Move the last of the debugfs counters out Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk 2012-11-05 14:37 ` [PATCH 11/11] zcache: Coalesce all debug under CONFIG_ZCACHE2_DEBUG Konrad Rzeszutek Wilk 2012-11-05 14:37 ` Konrad Rzeszutek Wilk [not found] <<1352126254-28933-1-git-send-email-konrad.wilk@oracle.com> 2012-11-07 0:02 ` [RFC PATCH] zcache2 cleanups (s/int/bool + debugfs movement) Dan Magenheimer 2012-11-07 0:02 ` Dan Magenheimer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1352126254-28933-1-git-send-email-konrad.wilk@oracle.com \ --to=konrad.wilk@oracle.com \ --cc=akpm@linux-foundation.org \ --cc=dan.magenheimer@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=ngupta@vflare.org \ --cc=rcj@linux.vnet.ibm.com \ --cc=sjenning@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.