All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu CASTET <matthieu.castet@parrot.com>
To: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org
Cc: dedekind1@gmail.com, Matthieu CASTET <matthieu.castet@parrot.com>
Subject: [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode
Date: Tue,  6 Nov 2012 11:51:43 +0100	[thread overview]
Message-ID: <1352199105-30215-1-git-send-email-matthieu.castet@parrot.com> (raw)

- NAND_CMD_READID want an address that it is not scaled on x16 device (it is always 0x20)
- NAND_CMD_PARAM want 8 bits data

Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
---
 drivers/mtd/nand/nand_base.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 5894c2c..abeb8e9 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2851,6 +2851,8 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
 	int i;
 	int val;
 
+	/* ONFI need to be probed in 8 bits mode */
+	WARN_ON(chip->options & NAND_BUSWIDTH_16);
 	/* Try ONFI for unknown chip or LP */
 	chip->cmdfunc(mtd, NAND_CMD_READID, 0x20, -1);
 	if (chip->read_byte(mtd) != 'O' || chip->read_byte(mtd) != 'N' ||
-- 
1.7.10.4


WARNING: multiple messages have this Message-ID (diff)
From: Matthieu CASTET <matthieu.castet@parrot.com>
To: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org
Cc: Matthieu CASTET <matthieu.castet@parrot.com>, dedekind1@gmail.com
Subject: [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode
Date: Tue,  6 Nov 2012 11:51:43 +0100	[thread overview]
Message-ID: <1352199105-30215-1-git-send-email-matthieu.castet@parrot.com> (raw)

- NAND_CMD_READID want an address that it is not scaled on x16 device (it is always 0x20)
- NAND_CMD_PARAM want 8 bits data

Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
---
 drivers/mtd/nand/nand_base.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 5894c2c..abeb8e9 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2851,6 +2851,8 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
 	int i;
 	int val;
 
+	/* ONFI need to be probed in 8 bits mode */
+	WARN_ON(chip->options & NAND_BUSWIDTH_16);
 	/* Try ONFI for unknown chip or LP */
 	chip->cmdfunc(mtd, NAND_CMD_READID, 0x20, -1);
 	if (chip->read_byte(mtd) != 'O' || chip->read_byte(mtd) != 'N' ||
-- 
1.7.10.4

             reply	other threads:[~2012-11-06 10:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 10:51 Matthieu CASTET [this message]
2012-11-06 10:51 ` [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode Matthieu CASTET
2012-11-06 10:51 ` [PATCH 2/3] mtd nand : add NAND_BUSWIDTH_AUTO to autodetect bus width Matthieu CASTET
2012-11-06 10:51   ` Matthieu CASTET
2012-11-30 13:21   ` Artem Bityutskiy
2012-11-30 13:21     ` Artem Bityutskiy
2012-11-06 10:51 ` [PATCH 3/3] omap3 nand : use NAND_BUSWIDTH_AUTO Matthieu CASTET
2012-11-06 10:51   ` Matthieu CASTET
2012-11-06 12:37   ` Igor Grinberg
2012-11-06 12:37     ` Igor Grinberg
2012-11-06 16:47     ` Matthieu CASTET
2012-11-06 16:47       ` Matthieu CASTET
2012-11-06 18:40       ` Tony Lindgren
2012-11-06 18:40         ` Tony Lindgren
2012-11-16  8:22         ` Artem Bityutskiy
2012-11-16  8:22           ` Artem Bityutskiy
2012-11-22 17:48           ` Matthieu CASTET
2012-11-22 17:48             ` Matthieu CASTET
2012-12-03 10:20 ` [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode Artem Bityutskiy
2012-12-03 10:20   ` Artem Bityutskiy
2012-12-24  0:29   ` Paul Walmsley
2012-12-24  0:29     ` Paul Walmsley
2013-01-02  9:51     ` Matthieu CASTET
2013-01-02  9:51       ` Matthieu CASTET
2013-01-03 17:10       ` Paul Walmsley
2013-01-03 17:10         ` Paul Walmsley
2013-01-16 14:28         ` Matthieu CASTET
2013-01-16 14:28           ` Matthieu CASTET
2013-01-16 17:15           ` Paul Walmsley
2013-01-16 17:15             ` Paul Walmsley
2013-01-22  2:27             ` Paul Walmsley
2013-01-22  2:27               ` Paul Walmsley
2013-02-06 23:21               ` Paul Walmsley
2013-02-06 23:21                 ` Paul Walmsley
2013-02-07  9:47                 ` Matthieu CASTET
2013-02-07  9:47                   ` Matthieu CASTET
2013-03-01 14:02                   ` Matthieu CASTET
2013-03-01 14:02                     ` Matthieu CASTET
2013-04-02 18:28                     ` Paul Walmsley
2013-04-02 18:28                       ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352199105-30215-1-git-send-email-matthieu.castet@parrot.com \
    --to=matthieu.castet@parrot.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.