From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Andrew Morton <akpm@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, linux-mm@kvack.org Cc: Andi Kleen <ak@linux.intel.com>, "H. Peter Anvin" <hpa@linux.intel.com>, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" <kirill@shutemov.name>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCH v5 08/11] thp: setup huge zero page on non-write page fault Date: Wed, 7 Nov 2012 17:01:00 +0200 [thread overview] Message-ID: <1352300463-12627-9-git-send-email-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <1352300463-12627-1-git-send-email-kirill.shutemov@linux.intel.com> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> All code paths seems covered. Now we can map huge zero page on read page fault. We setup it in do_huge_pmd_anonymous_page() if area around fault address is suitable for THP and we've got read page fault. If we fail to setup huge zero page (ENOMEM) we fallback to handle_pte_fault() as we normally do in THP. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/huge_memory.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f36bc7d..41f05f1 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -726,6 +726,16 @@ int do_huge_pmd_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma, return VM_FAULT_OOM; if (unlikely(khugepaged_enter(vma))) return VM_FAULT_OOM; + if (!(flags & FAULT_FLAG_WRITE)) { + pgtable_t pgtable; + pgtable = pte_alloc_one(mm, haddr); + if (unlikely(!pgtable)) + goto out; + spin_lock(&mm->page_table_lock); + set_huge_zero_page(pgtable, mm, vma, haddr, pmd); + spin_unlock(&mm->page_table_lock); + return 0; + } page = alloc_hugepage_vma(transparent_hugepage_defrag(vma), vma, haddr, numa_node_id(), 0); if (unlikely(!page)) { -- 1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Andrew Morton <akpm@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, linux-mm@kvack.org Cc: Andi Kleen <ak@linux.intel.com>, "H. Peter Anvin" <hpa@linux.intel.com>, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" <kirill@shutemov.name>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCH v5 08/11] thp: setup huge zero page on non-write page fault Date: Wed, 7 Nov 2012 17:01:00 +0200 [thread overview] Message-ID: <1352300463-12627-9-git-send-email-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <1352300463-12627-1-git-send-email-kirill.shutemov@linux.intel.com> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> All code paths seems covered. Now we can map huge zero page on read page fault. We setup it in do_huge_pmd_anonymous_page() if area around fault address is suitable for THP and we've got read page fault. If we fail to setup huge zero page (ENOMEM) we fallback to handle_pte_fault() as we normally do in THP. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/huge_memory.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f36bc7d..41f05f1 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -726,6 +726,16 @@ int do_huge_pmd_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma, return VM_FAULT_OOM; if (unlikely(khugepaged_enter(vma))) return VM_FAULT_OOM; + if (!(flags & FAULT_FLAG_WRITE)) { + pgtable_t pgtable; + pgtable = pte_alloc_one(mm, haddr); + if (unlikely(!pgtable)) + goto out; + spin_lock(&mm->page_table_lock); + set_huge_zero_page(pgtable, mm, vma, haddr, pmd); + spin_unlock(&mm->page_table_lock); + return 0; + } page = alloc_hugepage_vma(transparent_hugepage_defrag(vma), vma, haddr, numa_node_id(), 0); if (unlikely(!page)) { -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-07 15:01 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-07 15:00 [PATCH v5 00/11] Introduce huge zero page Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-07 15:00 ` [PATCH v5 01/11] thp: huge zero page: basic preparation Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 22:09 ` David Rientjes 2012-11-14 22:09 ` David Rientjes 2012-11-07 15:00 ` [PATCH v5 02/11] thp: zap_huge_pmd(): zap huge zero pmd Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 22:18 ` David Rientjes 2012-11-14 22:18 ` David Rientjes 2012-11-07 15:00 ` [PATCH v5 03/11] thp: copy_huge_pmd(): copy huge zero page Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 22:33 ` David Rientjes 2012-11-14 22:33 ` David Rientjes 2012-11-15 8:01 ` Kirill A. Shutemov 2012-11-15 8:14 ` David Rientjes 2012-11-15 8:14 ` David Rientjes 2012-11-07 15:00 ` [PATCH v5 04/11] thp: do_huge_pmd_wp_page(): handle " Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 23:08 ` David Rientjes 2012-11-14 23:08 ` David Rientjes 2012-11-15 8:29 ` Kirill A. Shutemov 2012-11-07 15:00 ` [PATCH v5 05/11] thp: change_huge_pmd(): keep huge zero page write-protected Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 23:12 ` David Rientjes 2012-11-14 23:12 ` David Rientjes 2012-11-15 8:46 ` Kirill A. Shutemov 2012-11-15 21:47 ` David Rientjes 2012-11-15 21:47 ` David Rientjes 2012-11-16 18:13 ` Kirill A. Shutemov 2012-11-16 20:10 ` David Rientjes 2012-11-16 20:10 ` David Rientjes 2012-11-20 16:00 ` Kirill A. Shutemov 2012-12-03 9:53 ` Kirill A. Shutemov 2012-11-07 15:00 ` [PATCH v5 06/11] thp: change split_huge_page_pmd() interface Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 23:22 ` David Rientjes 2012-11-14 23:22 ` David Rientjes 2012-11-15 8:52 ` Kirill A. Shutemov 2012-11-07 15:00 ` [PATCH v5 07/11] thp: implement splitting pmd for huge zero page Kirill A. Shutemov 2012-11-07 15:00 ` Kirill A. Shutemov 2012-11-14 23:28 ` David Rientjes 2012-11-14 23:28 ` David Rientjes 2012-11-15 9:24 ` Kirill A. Shutemov 2012-11-07 15:01 ` Kirill A. Shutemov [this message] 2012-11-07 15:01 ` [PATCH v5 08/11] thp: setup huge zero page on non-write page fault Kirill A. Shutemov 2012-11-14 23:33 ` David Rientjes 2012-11-14 23:33 ` David Rientjes 2012-11-15 9:32 ` Kirill A. Shutemov 2012-11-15 21:52 ` David Rientjes 2012-11-15 21:52 ` David Rientjes 2012-11-16 18:20 ` Kirill A. Shutemov 2012-11-07 15:01 ` [PATCH v5 09/11] thp: lazy huge zero page allocation Kirill A. Shutemov 2012-11-07 15:01 ` Kirill A. Shutemov 2012-11-14 23:37 ` David Rientjes 2012-11-14 23:37 ` David Rientjes 2012-11-15 9:41 ` Kirill A. Shutemov 2012-12-12 21:30 ` Andrew Morton 2012-12-12 21:30 ` Andrew Morton 2012-12-12 21:48 ` H. Peter Anvin 2012-12-12 21:48 ` H. Peter Anvin 2012-12-12 22:05 ` Kirill A. Shutemov 2012-11-07 15:01 ` [PATCH v5 10/11] thp: implement refcounting for huge zero page Kirill A. Shutemov 2012-11-07 15:01 ` Kirill A. Shutemov 2012-11-14 23:40 ` David Rientjes 2012-11-14 23:40 ` David Rientjes 2012-11-15 9:50 ` Kirill A. Shutemov 2012-11-07 15:01 ` [PATCH v5 11/11] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC_FAILED events Kirill A. Shutemov 2012-11-07 15:01 ` Kirill A. Shutemov 2012-11-14 23:41 ` David Rientjes 2012-11-14 23:41 ` David Rientjes 2012-11-16 21:29 ` H. Peter Anvin 2012-11-16 21:29 ` H. Peter Anvin 2012-11-14 21:33 ` [PATCH v5 00/11] Introduce huge zero page Andrew Morton 2012-11-14 21:33 ` Andrew Morton 2012-11-14 23:20 ` Alan Cox 2012-11-14 23:20 ` Alan Cox 2012-11-14 23:32 ` Andrew Morton 2012-11-14 23:32 ` Andrew Morton 2012-11-14 23:51 ` H. Peter Anvin 2012-11-14 23:51 ` H. Peter Anvin 2012-11-15 0:29 ` David Rientjes 2012-11-15 0:29 ` David Rientjes 2012-11-15 7:29 ` Kirill A. Shutemov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1352300463-12627-9-git-send-email-kirill.shutemov@linux.intel.com \ --to=kirill.shutemov@linux.intel.com \ --cc=aarcange@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=hpa@linux.intel.com \ --cc=kirill@shutemov.name \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.