From: Michal Hocko <mhocko@suse.cz> To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>, Ying Han <yinghan@google.com>, Tejun Heo <htejun@gmail.com>, Glauber Costa <glommer@parallels.com> Subject: [RFC 1/5] memcg: synchronize per-zone iterator access by a spinlock Date: Tue, 13 Nov 2012 16:30:35 +0100 [thread overview] Message-ID: <1352820639-13521-2-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1352820639-13521-1-git-send-email-mhocko@suse.cz> per-zone per-priority iterator is aimed at coordinating concurrent reclaimers on the same hierarchy (or the global reclaim when all groups are reclaimed) so that all groups get reclaimed evenly as much as possible. iter->position holds the last css->id visited and iter->generation signals the completed tree walk (when it is incremented). Concurrent reclaimers are supposed to provide a reclaim cookie which holds the reclaim priority and the last generation they saw. If cookie's generation doesn't match the iterator's view then other concurrent reclaimer already did the job and the tree walk is done for that priority. This scheme works nicely in most cases but it is not raceless. Two racing reclaimers can see the same iter->position and so bang on the same group. iter->generation increment is not serialized as well so a reclaimer can see an updated iter->position with and old generation so the iteration might be restarted from the root of the hierarchy. The simplest way to fix this issue is to synchronise access to the iterator by a lock. This implementation uses per-zone per-priority spinlock which linearizes only directly racing reclaimers which use reclaim cookies so the effect of the new locking should be really minimal. I have to note that I haven't seen this as a real issue so far. The primary motivation for the change is different. The following patch will change the way how the iterator is implemented and css->id iteration will be replaced cgroup generic iteration which requires storing mem_cgroup pointer into iterator and that requires reference counting and so concurrent access will be a problem. Signed-off-by: Michal Hocko <mhocko@suse.cz> --- mm/memcontrol.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6136fec..0fe5177 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -146,6 +146,8 @@ struct mem_cgroup_reclaim_iter { int position; /* scan generation, increased every round-trip */ unsigned int generation; + /* lock to protect the position and generation */ + spinlock_t iter_lock; }; /* @@ -1093,8 +1095,11 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, mz = mem_cgroup_zoneinfo(root, nid, zid); iter = &mz->reclaim_iter[reclaim->priority]; - if (prev && reclaim->generation != iter->generation) + spin_lock(&iter->iter_lock); + if (prev && reclaim->generation != iter->generation) { + spin_unlock(&iter->iter_lock); return NULL; + } id = iter->position; } @@ -1113,6 +1118,7 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, iter->generation++; else if (!prev && memcg) reclaim->generation = iter->generation; + spin_unlock(&iter->iter_lock); } if (prev && !css) @@ -5871,8 +5877,12 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *memcg, int node) return 1; for (zone = 0; zone < MAX_NR_ZONES; zone++) { + int prio; + mz = &pn->zoneinfo[zone]; lruvec_init(&mz->lruvec, &NODE_DATA(node)->node_zones[zone]); + for (prio = 0; prio < DEF_PRIORITY + 1; prio++) + spin_lock_init(&mz->reclaim_iter[prio].iter_lock); mz->usage_in_excess = 0; mz->on_tree = false; mz->memcg = memcg; -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz> To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>, Ying Han <yinghan@google.com>, Tejun Heo <htejun@gmail.com>, Glauber Costa <glommer@parallels.com> Subject: [RFC 1/5] memcg: synchronize per-zone iterator access by a spinlock Date: Tue, 13 Nov 2012 16:30:35 +0100 [thread overview] Message-ID: <1352820639-13521-2-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1352820639-13521-1-git-send-email-mhocko@suse.cz> per-zone per-priority iterator is aimed at coordinating concurrent reclaimers on the same hierarchy (or the global reclaim when all groups are reclaimed) so that all groups get reclaimed evenly as much as possible. iter->position holds the last css->id visited and iter->generation signals the completed tree walk (when it is incremented). Concurrent reclaimers are supposed to provide a reclaim cookie which holds the reclaim priority and the last generation they saw. If cookie's generation doesn't match the iterator's view then other concurrent reclaimer already did the job and the tree walk is done for that priority. This scheme works nicely in most cases but it is not raceless. Two racing reclaimers can see the same iter->position and so bang on the same group. iter->generation increment is not serialized as well so a reclaimer can see an updated iter->position with and old generation so the iteration might be restarted from the root of the hierarchy. The simplest way to fix this issue is to synchronise access to the iterator by a lock. This implementation uses per-zone per-priority spinlock which linearizes only directly racing reclaimers which use reclaim cookies so the effect of the new locking should be really minimal. I have to note that I haven't seen this as a real issue so far. The primary motivation for the change is different. The following patch will change the way how the iterator is implemented and css->id iteration will be replaced cgroup generic iteration which requires storing mem_cgroup pointer into iterator and that requires reference counting and so concurrent access will be a problem. Signed-off-by: Michal Hocko <mhocko@suse.cz> --- mm/memcontrol.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6136fec..0fe5177 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -146,6 +146,8 @@ struct mem_cgroup_reclaim_iter { int position; /* scan generation, increased every round-trip */ unsigned int generation; + /* lock to protect the position and generation */ + spinlock_t iter_lock; }; /* @@ -1093,8 +1095,11 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, mz = mem_cgroup_zoneinfo(root, nid, zid); iter = &mz->reclaim_iter[reclaim->priority]; - if (prev && reclaim->generation != iter->generation) + spin_lock(&iter->iter_lock); + if (prev && reclaim->generation != iter->generation) { + spin_unlock(&iter->iter_lock); return NULL; + } id = iter->position; } @@ -1113,6 +1118,7 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, iter->generation++; else if (!prev && memcg) reclaim->generation = iter->generation; + spin_unlock(&iter->iter_lock); } if (prev && !css) @@ -5871,8 +5877,12 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *memcg, int node) return 1; for (zone = 0; zone < MAX_NR_ZONES; zone++) { + int prio; + mz = &pn->zoneinfo[zone]; lruvec_init(&mz->lruvec, &NODE_DATA(node)->node_zones[zone]); + for (prio = 0; prio < DEF_PRIORITY + 1; prio++) + spin_lock_init(&mz->reclaim_iter[prio].iter_lock); mz->usage_in_excess = 0; mz->on_tree = false; mz->memcg = memcg; -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-13 15:31 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-13 15:30 [RFC] rework mem_cgroup iterator Michal Hocko 2012-11-13 15:30 ` Michal Hocko 2012-11-13 15:30 ` Michal Hocko [this message] 2012-11-13 15:30 ` [RFC 1/5] memcg: synchronize per-zone iterator access by a spinlock Michal Hocko 2012-11-14 0:03 ` Kamezawa Hiroyuki 2012-11-14 0:03 ` Kamezawa Hiroyuki 2012-11-13 15:30 ` [RFC 2/5] memcg: rework mem_cgroup_iter to use cgroup iterators Michal Hocko 2012-11-13 15:30 ` Michal Hocko 2012-11-13 16:14 ` Tejun Heo 2012-11-13 16:14 ` Tejun Heo 2012-11-14 8:51 ` Michal Hocko 2012-11-14 8:51 ` Michal Hocko 2012-11-14 18:52 ` Tejun Heo 2012-11-14 18:52 ` Tejun Heo 2012-11-15 9:51 ` Michal Hocko 2012-11-15 9:51 ` Michal Hocko 2012-11-15 14:47 ` Tejun Heo 2012-11-15 14:47 ` Tejun Heo 2012-11-15 15:12 ` Michal Hocko 2012-11-15 15:12 ` Michal Hocko 2012-11-15 15:31 ` Tejun Heo 2012-11-15 15:31 ` Tejun Heo 2012-11-15 16:15 ` Michal Hocko 2012-11-15 16:15 ` Michal Hocko 2012-11-14 0:20 ` Kamezawa Hiroyuki 2012-11-14 0:20 ` Kamezawa Hiroyuki 2012-11-14 10:10 ` Michal Hocko 2012-11-14 10:10 ` Michal Hocko 2012-11-15 4:12 ` Kamezawa Hiroyuki 2012-11-15 4:12 ` Kamezawa Hiroyuki 2012-11-15 9:52 ` Michal Hocko 2012-11-15 9:52 ` Michal Hocko 2012-11-19 14:05 ` Michal Hocko 2012-11-19 14:05 ` Michal Hocko 2012-11-19 15:11 ` Michal Hocko 2012-11-19 15:11 ` Michal Hocko 2012-11-13 15:30 ` [RFC 3/5] memcg: simplify mem_cgroup_iter Michal Hocko 2012-11-13 15:30 ` Michal Hocko 2012-11-13 15:30 ` [RFC 4/5] memcg: clean up mem_cgroup_iter Michal Hocko 2012-11-13 15:30 ` Michal Hocko 2012-11-13 15:30 ` [RFC 5/5] cgroup: remove css_get_next Michal Hocko 2012-11-13 15:30 ` Michal Hocko 2012-11-14 0:13 ` [RFC] rework mem_cgroup iterator Kamezawa Hiroyuki 2012-11-14 0:13 ` Kamezawa Hiroyuki 2012-11-14 1:55 ` Li Zefan 2012-11-14 1:55 ` Li Zefan 2012-11-14 8:36 ` Michal Hocko 2012-11-14 8:36 ` Michal Hocko 2012-11-14 18:30 ` Tejun Heo 2012-11-14 18:30 ` Tejun Heo 2012-11-15 2:12 ` Kamezawa Hiroyuki 2012-11-15 2:12 ` Kamezawa Hiroyuki 2012-11-14 16:17 ` Glauber Costa 2012-11-14 16:17 ` Glauber Costa 2012-11-14 8:40 ` Michal Hocko 2012-11-14 8:40 ` Michal Hocko 2012-11-14 18:41 ` Tejun Heo 2012-11-14 18:41 ` Tejun Heo 2012-11-15 2:44 ` Glauber Costa 2012-11-15 2:44 ` Glauber Costa 2012-11-14 18:46 ` Tejun Heo 2012-11-14 18:46 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1352820639-13521-2-git-send-email-mhocko@suse.cz \ --to=mhocko@suse.cz \ --cc=glommer@parallels.com \ --cc=hannes@cmpxchg.org \ --cc=htejun@gmail.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=yinghan@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.