* Re: [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames
[not found] <CAAPJqkbqZhRm08N0mTfKcW1PKc=XdhqiC8-668s_ydwRAZ9M2Q@mail.gmail.com>
@ 2012-11-13 20:28 ` Johannes Berg
2012-11-22 1:03 ` Mark Phillips
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2012-11-13 20:28 UTC (permalink / raw)
To: MARK PHILLIPS; +Cc: linux-wireless
Hi Mark, sorry for the delay,
On Mon, 2012-10-29 at 11:56 +0000, MARK PHILLIPS wrote:
> I have found bug which breaks monitor mode for the Intel Centrino
> Advanced-N 6235. When in monitor mode the FCS is returned appended to
> the frames which confuses wireshark.
>
> The fix appears to be trivial, just add IEEE80211_HW_RX_INCLUDES_FCS
> to the hw->flags when in monitor mode via a change to
> drivers/net/wireless/iwlwifi/dvm/mac80211.c
Yes, this seems to be a reasonable change, unfortunately mac80211
doesn't provide a per packet flag whether the FCS is present or not.
I think I prefer doing the modification in iwlagn_mac_add_interface(),
and will also add a comment.
FWIW, this appears to be a regression introduced in
578977264199de9815ace51ade87cec4894cf010, which went into 3.5. I'm a bit
confused why this didn't appear in my tests though, so I'm trying to see
if different firmware versions behave differently.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames
2012-11-13 20:28 ` [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames Johannes Berg
@ 2012-11-22 1:03 ` Mark Phillips
0 siblings, 0 replies; 2+ messages in thread
From: Mark Phillips @ 2012-11-22 1:03 UTC (permalink / raw)
To: 'Johannes Berg'; +Cc: linux-wireless
Great, glad you are sorting it out, thanks for all your help!
Cheers
Mark
-----Original Message-----
From: Johannes Berg [mailto:johannes@sipsolutions.net]
Sent: 13 November 2012 20:29
To: MARK PHILLIPS
Cc: linux-wireless@vger.kernel.org
Subject: Re: [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames
Hi Mark, sorry for the delay,
On Mon, 2012-10-29 at 11:56 +0000, MARK PHILLIPS wrote:
> I have found bug which breaks monitor mode for the Intel Centrino
> Advanced-N 6235. When in monitor mode the FCS is returned appended to
> the frames which confuses wireshark.
>
> The fix appears to be trivial, just add IEEE80211_HW_RX_INCLUDES_FCS
> to the hw->flags when in monitor mode via a change to
> drivers/net/wireless/iwlwifi/dvm/mac80211.c
Yes, this seems to be a reasonable change, unfortunately mac80211 doesn't provide a per packet flag whether the FCS is present or not.
I think I prefer doing the modification in iwlagn_mac_add_interface(), and will also add a comment.
FWIW, this appears to be a regression introduced in 578977264199de9815ace51ade87cec4894cf010, which went into 3.5. I'm a bit confused why this didn't appear in my tests though, so I'm trying to see if different firmware versions behave differently.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-22 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAAPJqkbqZhRm08N0mTfKcW1PKc=XdhqiC8-668s_ydwRAZ9M2Q@mail.gmail.com>
2012-11-13 20:28 ` [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames Johannes Berg
2012-11-22 1:03 ` Mark Phillips
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.