All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pulseaudio patch for Danny and Master
@ 2012-11-14  0:33 Saul Wold
  2012-11-14  0:33 ` [PATCH] pulseaudio: fix string test Saul Wold
  0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2012-11-14  0:33 UTC (permalink / raw)
  To: openembedded-core

This should go to both Master and Danny

Saul Wold (1):
  pulseaudio: fix string test

 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    2 +-
 .../pulseaudio/pulseaudio_2.1.bb                   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.9.5




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pulseaudio: fix string test
  2012-11-14  0:33 [PATCH] pulseaudio patch for Danny and Master Saul Wold
@ 2012-11-14  0:33 ` Saul Wold
  2012-11-14  1:38   ` Otavio Salvador
  0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2012-11-14  0:33 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    2 +-
 .../pulseaudio/pulseaudio_2.1.bb                   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 3003eaa..2fe7918 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -53,7 +53,7 @@ do_install_append() {
 	install -d ${D}${sysconfdir}/default/volatiles
 	install -m 0644 ${WORKDIR}/volatiles.04_pulse  ${D}${sysconfdir}/default/volatiles/volatiles.04_pulse
 	
-	if [ "x${TARGET_PFPU}" == "xsoft" ] ; then 
+	if [ "x${TARGET_PFPU}" = "xsoft" ] ; then 
 	     sed -i -e s:\;\ resample-method\ =\ sinc-fastest:resample-method\ =\ trivial: ${D}${sysconfdir}/pulse/daemon.conf
 	fi
 }
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index 1c2c9f7..a10b953 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r6"
+PR = "r7"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pulseaudio: fix string test
  2012-11-14  0:33 ` [PATCH] pulseaudio: fix string test Saul Wold
@ 2012-11-14  1:38   ` Otavio Salvador
  0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2012-11-14  1:38 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Tue, Nov 13, 2012 at 10:33 PM, Saul Wold <sgw@linux.intel.com> wrote:

> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>

I agree with the fix but the commit log could be improved. Please use
something as:

pulseaudio: Remove bashism from string test

This is more accurate and give a hint why you did the change.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 1091 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-11-14  1:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-14  0:33 [PATCH] pulseaudio patch for Danny and Master Saul Wold
2012-11-14  0:33 ` [PATCH] pulseaudio: fix string test Saul Wold
2012-11-14  1:38   ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.