All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] alcatel: create sim atom with vendor alcatel
@ 2012-11-14 11:08 Cedric Jehasse
  2012-11-15 18:32 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Cedric Jehasse @ 2012-11-14 11:08 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

From: Cedric Jehasse <cedric.jehasse@softathome.com>

---
 plugins/alcatel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/alcatel.c b/plugins/alcatel.c
index 8005170..e3e7086 100644
--- a/plugins/alcatel.c
+++ b/plugins/alcatel.c
@@ -230,7 +230,7 @@ static void alcatel_pre_sim(struct ofono_modem *modem)
 	DBG("%p", modem);
 
 	ofono_devinfo_create(modem, 0, "atmodem", data->aux);
-	sim = ofono_sim_create(modem, 0, "atmodem", data->aux);
+	sim = ofono_sim_create(modem, OFONO_VENDOR_ALCATEL, "atmodem", data->aux);
 
 	if (sim && data->have_sim == TRUE)
 		ofono_sim_inserted_notify(sim, TRUE);
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] alcatel: create sim atom with vendor alcatel
  2012-11-14 11:08 [PATCH] alcatel: create sim atom with vendor alcatel Cedric Jehasse
@ 2012-11-15 18:32 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2012-11-15 18:32 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Hi Cedric,

On 11/14/2012 05:08 AM, Cedric Jehasse wrote:
> From: Cedric Jehasse<cedric.jehasse@softathome.com>
>
> ---
>   plugins/alcatel.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

Patch has been applied, but I had to amend it.

>
> diff --git a/plugins/alcatel.c b/plugins/alcatel.c
> index 8005170..e3e7086 100644
> --- a/plugins/alcatel.c
> +++ b/plugins/alcatel.c
> @@ -230,7 +230,7 @@ static void alcatel_pre_sim(struct ofono_modem *modem)
>   	DBG("%p", modem);
>
>   	ofono_devinfo_create(modem, 0, "atmodem", data->aux);
> -	sim = ofono_sim_create(modem, 0, "atmodem", data->aux);
> +	sim = ofono_sim_create(modem, OFONO_VENDOR_ALCATEL, "atmodem", data->aux);

Please make sure to stay within 80 characters per line.

>
>   	if (sim&&  data->have_sim == TRUE)
>   		ofono_sim_inserted_notify(sim, TRUE);

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-15 18:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-14 11:08 [PATCH] alcatel: create sim atom with vendor alcatel Cedric Jehasse
2012-11-15 18:32 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.