All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] curl: eliminate forced setting of -g0 when compiling
@ 2012-11-15 19:17 Joe Slater
  2012-12-11  0:04 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Slater @ 2012-11-15 19:17 UTC (permalink / raw)
  To: openembedded-core

Do not invoke CURL_SET_COMPILER_DEBUG_OPTS in configure.ac.
This will allow debug options set in our CFLAGS to be
used.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 meta/recipes-support/curl/curl/configure_ac.patch |   11 +++++++++++
 meta/recipes-support/curl/curl_7.26.0.bb          |    7 ++++++-
 2 files changed, 17 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-support/curl/curl/configure_ac.patch

diff --git a/meta/recipes-support/curl/curl/configure_ac.patch b/meta/recipes-support/curl/curl/configure_ac.patch
new file mode 100644
index 0000000..98d8387
--- /dev/null
+++ b/meta/recipes-support/curl/curl/configure_ac.patch
@@ -0,0 +1,11 @@
+--- a/configure.ac
++++ b/configure.ac
+@@ -281,7 +281,7 @@ dnl ************************************
+ 
+ CURL_CHECK_COMPILER
+ CURL_SET_COMPILER_BASIC_OPTS
+-CURL_SET_COMPILER_DEBUG_OPTS
++dnl CURL_SET_COMPILER_DEBUG_OPTS
+ CURL_SET_COMPILER_OPTIMIZE_OPTS
+ CURL_SET_COMPILER_WARNING_OPTS
+ 
diff --git a/meta/recipes-support/curl/curl_7.26.0.bb b/meta/recipes-support/curl/curl_7.26.0.bb
index 9a0e7ce..fef247c 100644
--- a/meta/recipes-support/curl/curl_7.26.0.bb
+++ b/meta/recipes-support/curl/curl_7.26.0.bb
@@ -8,11 +8,16 @@ LIC_FILES_CHKSUM = "file://COPYING;beginline=7;md5=3a34942f4ae3fbf1a303160714e66
 DEPENDS = "zlib gnutls"
 DEPENDS_class-native = "zlib-native openssl-native"
 DEPENDS_class-nativesdk = "nativesdk-zlib"
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "http://curl.haxx.se/download/curl-${PV}.tar.bz2 \
            file://pkgconfig_fix.patch"
 
+# curl likes to set -g0 in CFLAGS, so we stop it
+# from mucking around with debug options
+#
+SRC_URI += " file://configure_ac.patch"
+
 SRC_URI[md5sum] = "bfa80f01b3d300359cfb4d409b6136a3"
 SRC_URI[sha256sum] = "fced262f16eb6bfcdcea15e04a7905ffcb5ff04b14a19ca35b9df86d6720d26a"
 
-- 
1.7.3.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] curl: eliminate forced setting of -g0 when compiling
  2012-11-15 19:17 [PATCH] curl: eliminate forced setting of -g0 when compiling Joe Slater
@ 2012-12-11  0:04 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-12-11  0:04 UTC (permalink / raw)
  To: Joe Slater; +Cc: openembedded-core

On 11/15/2012 11:17 AM, Joe Slater wrote:
> Do not invoke CURL_SET_COMPILER_DEBUG_OPTS in configure.ac.
> This will allow debug options set in our CFLAGS to be
> used.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>   meta/recipes-support/curl/curl/configure_ac.patch |   11 +++++++++++
>   meta/recipes-support/curl/curl_7.26.0.bb          |    7 ++++++-
>   2 files changed, 17 insertions(+), 1 deletions(-)
>   create mode 100644 meta/recipes-support/curl/curl/configure_ac.patch
>
> diff --git a/meta/recipes-support/curl/curl/configure_ac.patch b/meta/recipes-support/curl/curl/configure_ac.patch
> new file mode 100644
> index 0000000..98d8387
> --- /dev/null
> +++ b/meta/recipes-support/curl/curl/configure_ac.patch

This patch slipped in without me catching it needed a header.

Please add Upstream-Status and Signed-off-by

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
	Sau!

> @@ -0,0 +1,11 @@
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -281,7 +281,7 @@ dnl ************************************
> +
> + CURL_CHECK_COMPILER
> + CURL_SET_COMPILER_BASIC_OPTS
> +-CURL_SET_COMPILER_DEBUG_OPTS
> ++dnl CURL_SET_COMPILER_DEBUG_OPTS
> + CURL_SET_COMPILER_OPTIMIZE_OPTS
> + CURL_SET_COMPILER_WARNING_OPTS
> +
> diff --git a/meta/recipes-support/curl/curl_7.26.0.bb b/meta/recipes-support/curl/curl_7.26.0.bb
> index 9a0e7ce..fef247c 100644
> --- a/meta/recipes-support/curl/curl_7.26.0.bb
> +++ b/meta/recipes-support/curl/curl_7.26.0.bb
> @@ -8,11 +8,16 @@ LIC_FILES_CHKSUM = "file://COPYING;beginline=7;md5=3a34942f4ae3fbf1a303160714e66
>   DEPENDS = "zlib gnutls"
>   DEPENDS_class-native = "zlib-native openssl-native"
>   DEPENDS_class-nativesdk = "nativesdk-zlib"
> -PR = "r1"
> +PR = "r2"
>
>   SRC_URI = "http://curl.haxx.se/download/curl-${PV}.tar.bz2 \
>              file://pkgconfig_fix.patch"
>
> +# curl likes to set -g0 in CFLAGS, so we stop it
> +# from mucking around with debug options
> +#
> +SRC_URI += " file://configure_ac.patch"
> +
>   SRC_URI[md5sum] = "bfa80f01b3d300359cfb4d409b6136a3"
>   SRC_URI[sha256sum] = "fced262f16eb6bfcdcea15e04a7905ffcb5ff04b14a19ca35b9df86d6720d26a"
>
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-11  0:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-15 19:17 [PATCH] curl: eliminate forced setting of -g0 when compiling Joe Slater
2012-12-11  0:04 ` Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.