[PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static

[PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static

[Sachin Kamat]

Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 130a2b5..730ce56 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -61,7 +61,7 @@ struct fimd_driver_data {
 	unsigned int timing_base;
 };
 
-struct fimd_driver_data exynos4_fimd_driver_data = {
+static struct fimd_driver_data exynos4_fimd_driver_data = {
 	.timing_base = 0x0,
 };
 
-- 
1.7.4.1

[PATCH 2/2] drm/exynos: Make exynos5_fimd_driver_data static

[Sachin Kamat]

Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:69:25: warning:
symbol 'exynos5_fimd_driver_data' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 730ce56..e08478f 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -65,7 +65,7 @@ static struct fimd_driver_data exynos4_fimd_driver_data = {
 	.timing_base = 0x0,
 };
 
-struct fimd_driver_data exynos5_fimd_driver_data = {
+static struct fimd_driver_data exynos5_fimd_driver_data = {
 	.timing_base = 0x20000,
 };
 
-- 
1.7.4.1

RE: [PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static

[Inki Dae]

Please, combine these patches.

Thanks,
Inki Dae

> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Monday, November 19, 2012 5:38 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com;
sachin.kamat@linaro.org;
> patches@linaro.org
> Subject: [PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static
> 
> Fixes the following sparse warning:
> drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
> symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 130a2b5..730ce56 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -61,7 +61,7 @@ struct fimd_driver_data {
>  	unsigned int timing_base;
>  };
> 
> -struct fimd_driver_data exynos4_fimd_driver_data = {
> +static struct fimd_driver_data exynos4_fimd_driver_data = {
>  	.timing_base = 0x0,
>  };
> 
> --
> 1.7.4.1

Re: [PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static

[Sachin Kamat]

On 19 November 2012 15:15, Inki Dae <inki.dae@samsung.com> wrote:
> Please, combine these patches.

OK. I will re-send.

>
> Thanks,
> Inki Dae
>
>> -----Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
>> Sent: Monday, November 19, 2012 5:38 PM
>> To: dri-devel@lists.freedesktop.org
>> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com;
> sachin.kamat@linaro.org;
>> patches@linaro.org
>> Subject: [PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static
>>
>> Fixes the following sparse warning:
>> drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
>> symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_fimd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> index 130a2b5..730ce56 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> @@ -61,7 +61,7 @@ struct fimd_driver_data {
>>       unsigned int timing_base;
>>  };
>>
>> -struct fimd_driver_data exynos4_fimd_driver_data = {
>> +static struct fimd_driver_data exynos4_fimd_driver_data = {
>>       .timing_base = 0x0,
>>  };
>>
>> --
>> 1.7.4.1
>



-- 
With warm regards,
Sachin