All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm tools: disable LTO by default
@ 2012-11-20  0:31 Sasha Levin
  0 siblings, 0 replies; only message in thread
From: Sasha Levin @ 2012-11-20  0:31 UTC (permalink / raw)
  To: penberg; +Cc: asias, kvm, rminnich, Sasha Levin

A bug only seen with LTO enabled was reported by Ron Minnich. Since the issue
appears to be a linker issue, we disable LTO by default until it's more stable.

We can still run LTO builds by setting LTO=1.

Reported-by: Ron Minnich <rminnich@gmail.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 tools/kvm/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
index c105de1..de11060 100644
--- a/tools/kvm/Makefile
+++ b/tools/kvm/Makefile
@@ -221,9 +221,11 @@ ifeq ($(call try-cc,$(SOURCE_AIO),$(FLAGS_AIO) -static),y)
 	LIBS_STATOPT	+= -laio
 endif
 
-FLAGS_LTO := -flto
-ifeq ($(call try-cc,$(SOURCE_HELLO),$(FLAGS_LTO)),y)
-	CFLAGS		+= $(FLAGS_LTO)
+ifeq ($(LTO),1)
+	FLAGS_LTO := -flto
+	ifeq ($(call try-cc,$(SOURCE_HELLO),$(FLAGS_LTO)),y)
+		CFLAGS		+= $(FLAGS_LTO)
+	endif
 endif
 
 ifneq ($(call try-build,$(SOURCE_STATIC),-static,),y)
-- 
1.8.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-20  0:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-20  0:31 [PATCH] kvm tools: disable LTO by default Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.