From: Joe Perches <joe@perches.com> To: Peter Senna Tschudin <peter.senna@gmail.com> Cc: mmarek@suse.cz, Julia Lawall <Julia.Lawall@lip6.fr>, Gilles Muller <Gilles.Muller@lip6.fr>, Nicolas Palix <nicolas.palix@imag.fr>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test Date: Sat, 08 Dec 2012 10:39:51 -0800 [thread overview] Message-ID: <1354991991.3198.7.camel@joe-AO722> (raw) In-Reply-To: <CA+MoWDr0JT0T-0ZUDsqceuXKbjW_mavS9t6HGkFR4dz2XUygWg@mail.gmail.com> On Sat, 2012-12-08 at 16:13 -0200, Peter Senna Tschudin wrote: > On Sat, Dec 8, 2012 at 3:45 PM, Joe Perches <joe@perches.com> wrote: > > On Sat, 2012-12-08 at 15:34 -0200, Peter Senna Tschudin wrote: > >> This semantic patch looks for semicolons that can be removed without > >> changing the semantics of the code. The confidence is moderate > >> because there are some false positives on cases like: > >> > >> b/drivers/mmc/host/cb710-mmc.c:589 > >> break; > >> case MMC_POWER_UP: > >> default: > >> - /* ignore */; > >> } > > [] > >> diff --git a/scripts/coccinelle/misc/semicolon.cocci b/scripts/coccinelle/misc/semicolon.cocci > > [] > >> +@r1@ > >> +statement S; > >> +position p1; > >> +position p != {r_default.p, r_case.p}; > >> +identifier label; > >> +@@ > >> +( > >> +label:; > >> +| > >> +S@p1;@p > >> +) > >> + > > > > I believe this also fails on this case: [] > > where gcc needs a semicolon after a label before a function exit. > > No it does not fail. This issue is switch/case specific. See how I've tested: Thanks Peter, I didn't notice the switch requirement. In this case, I'd suggest replacement of the nominally false positive ; with break; cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches) To: cocci@systeme.lip6.fr Subject: [Cocci] [PATCH] scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test Date: Sat, 08 Dec 2012 10:39:51 -0800 [thread overview] Message-ID: <1354991991.3198.7.camel@joe-AO722> (raw) In-Reply-To: <CA+MoWDr0JT0T-0ZUDsqceuXKbjW_mavS9t6HGkFR4dz2XUygWg@mail.gmail.com> On Sat, 2012-12-08 at 16:13 -0200, Peter Senna Tschudin wrote: > On Sat, Dec 8, 2012 at 3:45 PM, Joe Perches <joe@perches.com> wrote: > > On Sat, 2012-12-08 at 15:34 -0200, Peter Senna Tschudin wrote: > >> This semantic patch looks for semicolons that can be removed without > >> changing the semantics of the code. The confidence is moderate > >> because there are some false positives on cases like: > >> > >> b/drivers/mmc/host/cb710-mmc.c:589 > >> break; > >> case MMC_POWER_UP: > >> default: > >> - /* ignore */; > >> } > > [] > >> diff --git a/scripts/coccinelle/misc/semicolon.cocci b/scripts/coccinelle/misc/semicolon.cocci > > [] > >> + at r1@ > >> +statement S; > >> +position p1; > >> +position p != {r_default.p, r_case.p}; > >> +identifier label; > >> +@@ > >> +( > >> +label:; > >> +| > >> +S at p1;@p > >> +) > >> + > > > > I believe this also fails on this case: [] > > where gcc needs a semicolon after a label before a function exit. > > No it does not fail. This issue is switch/case specific. See how I've tested: Thanks Peter, I didn't notice the switch requirement. In this case, I'd suggest replacement of the nominally false positive ; with break; cheers, Joe
next prev parent reply other threads:[~2012-12-08 18:39 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-12-08 17:34 [PATCH] scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test Peter Senna Tschudin 2012-12-08 17:34 ` [Cocci] " Peter Senna Tschudin 2012-12-08 17:45 ` Joe Perches 2012-12-08 17:45 ` [Cocci] " Joe Perches 2012-12-08 18:13 ` Peter Senna Tschudin 2012-12-08 18:13 ` [Cocci] " Peter Senna Tschudin 2012-12-08 18:39 ` Joe Perches [this message] 2012-12-08 18:39 ` Joe Perches 2012-12-09 17:51 ` Peter Senna Tschudin 2012-12-09 17:51 ` [Cocci] " Peter Senna Tschudin 2012-12-10 18:08 ` [PATCH] checkpatch: Add --strict test for switch/default missing break Joe Perches 2013-01-23 21:41 ` [PATCH] scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test Peter Senna Tschudin 2013-01-23 21:41 ` [Cocci] " Peter Senna Tschudin 2013-01-24 11:11 ` Michal Marek 2013-01-24 11:11 ` [Cocci] " Michal Marek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1354991991.3198.7.camel@joe-AO722 \ --to=joe@perches.com \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=cocci@systeme.lip6.fr \ --cc=linux-kernel@vger.kernel.org \ --cc=mmarek@suse.cz \ --cc=nicolas.palix@imag.fr \ --cc=peter.senna@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.