[PATCH] telit: set baud rate to 115200

[PATCH] telit: set baud rate to 115200

[Christopher Vogl]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Telit HE910 needs the baud rate to be set.
---
 plugins/telit.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/plugins/telit.c b/plugins/telit.c
index fe2ccd6..64f763a 100644
--- a/plugins/telit.c
+++ b/plugins/telit.c
@@ -186,6 +186,7 @@ static GAtChat *open_device(struct ofono_modem *modem,
 	GAtSyntax *syntax;
 	GIOChannel *channel;
 	GAtChat *chat;
+	GHashTable *options;
 
 	device = ofono_modem_get_string(modem, key);
 	if (device == NULL)
@@ -193,7 +194,13 @@ static GAtChat *open_device(struct ofono_modem *modem,
 
 	DBG("%s %s", key, device);
 
-	channel = g_at_tty_open(device, NULL);
+	options = g_hash_table_new(g_str_hash, g_str_equal);
+	if (options == NULL)
+		return NULL;
+
+	g_hash_table_insert(options, "Baud", "115200");
+
+	channel = g_at_tty_open(device, options);
 	if (channel == NULL)
 		return NULL;
 
-- 
1.7.7.6


--
Scanned by MailScanner.

Re: [PATCH] telit: set baud rate to 115200

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

Hi Christopher,

On 12/17/2012 04:15 AM, Christopher Vogl wrote:
> Telit HE910 needs the baud rate to be set.
> ---
>   plugins/telit.c |    9 ++++++++-
>   1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/telit.c b/plugins/telit.c
> index fe2ccd6..64f763a 100644
> --- a/plugins/telit.c
> +++ b/plugins/telit.c
> @@ -186,6 +186,7 @@ static GAtChat *open_device(struct ofono_modem *modem,
>   	GAtSyntax *syntax;
>   	GIOChannel *channel;
>   	GAtChat *chat;
> +	GHashTable *options;
>
>   	device = ofono_modem_get_string(modem, key);
>   	if (device == NULL)
> @@ -193,7 +194,13 @@ static GAtChat *open_device(struct ofono_modem *modem,
>
>   	DBG("%s %s", key, device);
>
> -	channel = g_at_tty_open(device, NULL);
> +	options = g_hash_table_new(g_str_hash, g_str_equal);
> +	if (options == NULL)
> +		return NULL;
> +
> +	g_hash_table_insert(options, "Baud", "115200");
> +
> +	channel = g_at_tty_open(device, options);

Are you leaking the hash table object here?

>   	if (channel == NULL)
>   		return NULL;
>

Regards,
-Denis

[PATCH] telit: set baud rate to 115200

[Christopher Vogl]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Telit HE910 needs the baud rate to be set.
---
 plugins/telit.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/plugins/telit.c b/plugins/telit.c
index fe2ccd6..79bc421 100644
--- a/plugins/telit.c
+++ b/plugins/telit.c
@@ -186,6 +186,7 @@ static GAtChat *open_device(struct ofono_modem *modem,
 	GAtSyntax *syntax;
 	GIOChannel *channel;
 	GAtChat *chat;
+	GHashTable *options;
 
 	device = ofono_modem_get_string(modem, key);
 	if (device == NULL)
@@ -193,7 +194,16 @@ static GAtChat *open_device(struct ofono_modem *modem,
 
 	DBG("%s %s", key, device);
 
-	channel = g_at_tty_open(device, NULL);
+	options = g_hash_table_new(g_str_hash, g_str_equal);
+	if (options == NULL)
+		return NULL;
+
+	g_hash_table_insert(options, "Baud", "115200");
+
+	channel = g_at_tty_open(device, options);
+
+	g_hash_table_destroy(options);
+
 	if (channel == NULL)
 		return NULL;
 
-- 
1.7.7.6


--
Scanned by MailScanner.

Re: [PATCH] telit: set baud rate to 115200

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Hi Christopher,

On 12/17/2012 10:07 AM, Christopher Vogl wrote:
> Telit HE910 needs the baud rate to be set.
> ---
>   plugins/telit.c |   12 +++++++++++-
>   1 files changed, 11 insertions(+), 1 deletions(-)
>

Patch has been applied, thanks.

Regards,
-Denis